Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] l10n_it_fiscal_document_type: license must be AGPL since it depends on AGPL modules #2436

Merged
merged 1 commit into from
Sep 30, 2021
Merged

[FIX] l10n_it_fiscal_document_type: license must be AGPL since it depends on AGPL modules #2436

merged 1 commit into from
Sep 30, 2021

Conversation

dreispt
Copy link
Member

@dreispt dreispt commented Sep 24, 2021 •
edited
Loading

image

@dreispt dreispt requested a review from simahawk September 24, 2021 08:16
simahawk
simahawk reviewed Sep 24, 2021
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alessandrocamilli @eLBati can you check if it is ok for you and if this affects other modules?

This was referenced Sep 24, 2021
Closed
Closed
@eLBati
Copy link
Member

eLBati commented Sep 24, 2021

@simahawk it should be OK. Ref #2360 (comment)

eLBati
eLBati approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dreispt thanks!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@eLBati
Copy link
Member

eLBati commented Sep 30, 2021

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-2436-by-eLBati-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 86278e8 into OCA:14.0 Sep 30, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1164178. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk left review comments

@scigghia scigghia scigghia approved these changes

@eLBati eLBati eLBati approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dreispt @eLBati @OCA-git-bot @simahawk @scigghia