Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] l10n_it_fatturapa_out_rc #2559

Merged
merged 11 commits into from
Feb 3, 2022
Merged

[14.0][MIG] l10n_it_fatturapa_out_rc #2559

merged 11 commits into from
Feb 3, 2022

Conversation

tafaRU
Copy link
Member

@tafaRU tafaRU commented Dec 15, 2021

No description provided.

@tafaRU tafaRU marked this pull request as draft December 15, 2021 15:00
@tafaRU tafaRU mentioned this pull request Dec 15, 2021
Open
76 tasks
@tafaRU tafaRU force-pushed the 14.0-mig-l10n_it_fatturapa_out_rc branch from 38e732a to de5d3d6 Compare December 16, 2021 14:52
@tafaRU
Copy link
Member Author

tafaRU commented Dec 16, 2021

Ho proposto e405458 su #2560 trattandosi di una modifica banale. Appena viene mergiata lo rimuovo da qui.

@tafaRU tafaRU force-pushed the 14.0-mig-l10n_it_fatturapa_out_rc branch from 0fefc96 to dd1a323 Compare December 17, 2021 10:54
@marco-marchiori
Copy link

test runbot

errore nella selezione del Tipo Documento in accounting/settings/reverse change types

riporto qui

Error:
Odoo Server Error

Traceback (most recent call last):
File "/.repo_requirements/odoo/odoo/addons/base/models/ir_http.py", line 237, in _dispatch
result = request.dispatch()
File "/.repo_requirements/odoo/odoo/http.py", line 684, in dispatch
result = self._call_function(**self.params)
File "/.repo_requirements/odoo/odoo/http.py", line 360, in _call_function
return checked_call(self.db, *args, **kwargs)
File "/.repo_requirements/odoo/odoo/service/model.py", line 94, in wrapper
return f(dbname, *args, **kwargs)
File "/.repo_requirements/odoo/odoo/http.py", line 348, in checked_call
result = self.endpoint(*a, **kw)
File "/.repo_requirements/odoo/odoo/http.py", line 913, in call
return self.method(*args, **kw)
File "/.repo_requirements/odoo/odoo/http.py", line 532, in response_wrap
response = f(*args, **kw)
File "/.repo_requirements/odoo/addons/web/controllers/main.py", line 1392, in call_kw
return self._call_kw(model, method, args, kwargs)
File "/.repo_requirements/odoo/addons/web/controllers/main.py", line 1384, in _call_kw
return call_kw(request.env[model], method, args, kwargs)
File "/.repo_requirements/odoo/odoo/api.py", line 399, in call_kw
result = _call_kw_multi(method, model, args, kwargs)
File "/.repo_requirements/odoo/odoo/api.py", line 382, in _call_kw_multi
ids, args = args[0], args[1:]
Exception

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
File "/.repo_requirements/odoo/odoo/http.py", line 640, in _handle_exception
return super(JsonRequest, self)._handle_exception(exception)
File "/.repo_requirements/odoo/odoo/http.py", line 316, in _handle_exception
raise exception.with_traceback(None) from new_cause
IndexError: list index out of range

@tafaRU tafaRU force-pushed the 14.0-mig-l10n_it_fatturapa_out_rc branch from dd1a323 to 76abedc Compare December 24, 2021 08:47
@tafaRU
Copy link
Member Author

tafaRU commented Dec 24, 2021

@marco-marchiori il problema che segnali qui non si presenta più sul nuovo runbot (dopo aver fatto rebase). Puoi verificare?

marco-marchiori
marco-marchiori approved these changes Jan 31, 2022
View reviewed changes
Copy link

@marco-marchiori marco-marchiori left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provata emissione di tipo documento TD17, esporta correttamente
provato controllo con SDI, passa il controllo

@tafaRU tafaRU force-pushed the 14.0-mig-l10n_it_fatturapa_out_rc branch from 76abedc to 5c4904e Compare January 31, 2022 13:32
@tafaRU tafaRU marked this pull request as ready for review January 31, 2022 13:34
fredzamoabg
fredzamoabg suggested changes Feb 1, 2022
View reviewed changes
l10n_it_fatturapa_out_rc/models/account_move.py Outdated Show resolved Hide resolved
l10n_it_fatturapa_out_rc/models/account_move.py Outdated Show resolved Hide resolved
l10n_it_account/models/account_group.py Outdated Show resolved Hide resolved
@tafaRU tafaRU force-pushed the 14.0-mig-l10n_it_fatturapa_out_rc branch from 5c4904e to 9b38f1c Compare February 1, 2022 09:37
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@alessandrocamilli
Copy link
Contributor

@tafaRU ultimi test completati, per me puoi mergiare

@tafaRU
[FIX] l10n_it_fatturapa_out_sp: get it compatible with l10n_it_fattur…
082b5d4 
…apa_out_rc

Also note that it's not possible create a selfinvoice with split payment.

Otherwise if both modules are installed you get the following error:

2021-12-16 15:00:57,290 943831 ERROR test-l10n_it_fatturapa_out_rc_14.0 odoo.addons.l10n_it_fatturapa_out_rc.tests.test_fatturapa_xml_validation: ERROR: TestFatturaPAXMLValidation.test_intra_EU_supplier_refund
Traceback (most recent call last):
  File "/home/tafaru/dev/envs/odoo14/l10n-italy/l10n_it_fatturapa_out_rc/tests/test_fatturapa_xml_validation.py", line 192, in test_intra_EU_supplier_refund
    res = self.run_wizard(invoice.rc_self_invoice_id.id)
  File "/home/tafaru/dev/envs/odoo14/l10n-italy/l10n_it_fatturapa_out/tests/fatturapa_common.py", line 187, in run_wizard
    return wizard.with_context({"active_ids": [invoice_id]}).exportFatturaPA()
  File "/home/tafaru/dev/envs/odoo14/l10n-italy/l10n_it_fatturapa_out/wizard/wizard_export_fatturapa.py", line 151, in exportFatturaPA
    attach = self.saveAttachment(fatturapa, progressivo_invio)
  File "/home/tafaru/dev/envs/odoo14/l10n-italy/l10n_it_fatturapa_out/wizard/wizard_export_fatturapa.py", line 52, in saveAttachment
    attach_str = fatturapa.to_xml(self.env)
  File "/home/tafaru/dev/envs/odoo14/l10n-italy/l10n_it_fatturapa_out/wizard/efattura.py", line 320, in to_xml
    raise UserError("\n".join(str(e) for e in errors))
odoo.exceptions.UserError: failed validating <Element DatiGeneraliDocumento at 0x7fecc1bbbac8> with XsdGroup(model='sequence', occurs=[1, 1]):

Reason: Unexpected child with tag 'ImportoTotaleDocumento' at position 6.

Schema:

  <xs:complexType xmlns:xs="http://www.w3.org/2001/XMLSchema" name="DatiGeneraliDocumentoType">
    <xs:sequence>
      <xs:element name="TipoDocumento" type="TipoDocumentoType" />
      <xs:element name="Divisa" type="DivisaType" />
      <xs:element name="Data" type="DataFatturaType" />
      <xs:element name="Numero" type="String20Type" />
      <xs:element maxOccurs="unbounded" minOccurs="0" name="DatiRitenuta" type="DatiRitenutaType" />
      <xs:element minOccurs="0" name="DatiBollo" type="DatiBolloType" />
      <xs:element maxOccurs="unbounded" minOccurs="0" name="DatiCassaPrevidenziale" type="DatiCassaPrevidenzialeType" />
      <xs:element maxOccurs="unbounded" minOccurs="0" name="ScontoMaggiorazione" type="ScontoMaggiorazioneType" />
      <xs:element minOccurs="0" name="ImportoTotaleDocumento" type="Amount2DecimalType" />
      <xs:element minOccurs="0" name="Arrotondamento" type="Amount2DecimalType" />
      <xs:element maxOccurs="unbounded" minOccurs="0" name="Causale" type="String200LatinType" />
      <xs:element minOccurs="0" name="Art73" type="Art73Type" />
    </xs:sequence>
  </xs:complexType>

Instance (line 130):

  <DatiGeneraliDocumento xmlns:ns1="http://ivaservizi.agenziaentrate.gov.it/docs/xsd/fatture/v1.2"><TipoDocumento>TD17</TipoDocumento><Divisa>EUR</Divisa><Data>2020-12-01</Data><Numero>RSLF/2020/12/0001</Numero><ImportoTotaleDocumento>-122.00</ImportoTotaleDocumento><ImportoTotaleDocumento>122.00</ImportoTotaleDocumento><Causale>Reverse charge self invoice.</Causale><Causale>Supplier: Intra EU supplier</Causale><Causale>Reference: EU-SUPPLIER-REF</Causale><Causale>Date: 2020-12-01</Causale><Causale>Internal reference: RBILL/2020/12/0001</Causale></DatiGeneraliDocumento>

Path: /ns1:FatturaElettronica/FatturaElettronicaBody/DatiGenerali/DatiGeneraliDocumento
@tafaRU tafaRU force-pushed the 14.0-mig-l10n_it_fatturapa_out_rc branch from 9b38f1c to 082b5d4 Compare February 3, 2022 07:53
@tafaRU
Copy link
Member Author

tafaRU commented Feb 3, 2022

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-2559-by-tafaRU-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 93ffaef into OCA:14.0 Feb 3, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 97b5c80. Thanks a lot for contributing to OCA. ❤️

@tafaRU tafaRU deleted the 14.0-mig-l10n_it_fatturapa_out_rc branch February 3, 2022 08:44
@TheMule71 TheMule71 mentioned this pull request Feb 4, 2022
Merged
@eLBati eLBati mentioned this pull request Feb 17, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredzamoabg fredzamoabg fredzamoabg approved these changes

@marco-marchiori marco-marchiori marco-marchiori approved these changes

@alessandrocamilli alessandrocamilli alessandrocamilli approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tafaRU @marco-marchiori @OCA-git-bot @alessandrocamilli @fredzamoabg @francesco-ooops @eLBati @sergiocorato