Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] fix issue#279 #280

Merged
merged 1 commit into from
Dec 30, 2016
Merged

[FIX] fix issue#279 #280

merged 1 commit into from
Dec 30, 2016

Conversation

CiroBoxHub
Copy link
Contributor

No description provided.

@OpenCode
Copy link
Contributor

OpenCode commented Nov 7, 2016

@eLBati select parameter in fields declaration generate the loop. if we delete select we solve the problem. The bug is in Odoo core.
https://github.com/OCA/OCB/blob/10.0/odoo/fields.py#L462

@OpenCode OpenCode mentioned this pull request Nov 8, 2016
Closed
@eLBati
Copy link
Member

eLBati commented Nov 9, 2016 •
edited
Loading

@OpenCode I think select can be replaced by index

@OpenCode
Copy link
Contributor

@eLBati ok

@eLBati
Copy link
Member

eLBati commented Nov 15, 2016

@CiroBoxHub prevedi di utilizzare index o preferisci lasciare la PR così com'è?

@CiroBoxHub
Copy link
Contributor Author

@eLBati ho reinserito index per il field parent_id

eLBati
eLBati approved these changes Nov 16, 2016
View reviewed changes
Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CiroBoxHub grazie, puoi solo fare lo squash dei 3 commit?

@andrea4ever
Copy link
Contributor

andrea4ever commented Nov 16, 2016 •
edited
Loading

@eLBati mi sento tanto un indovino in questo momento ;-)

susport
susport reviewed Nov 21, 2016
View reviewed changes
Copy link

@susport susport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
But you must sort alphabetically according to guide

@eLBati
Copy link
Member

eLBati commented Dec 20, 2016

waiting for squash to merge

@CiroBoxHub @eLBati
[FIX] l10n_it_ateco
cc3e286 
remove select parameter

add index parameter to parent_id
@eLBati
Copy link
Member

eLBati commented Dec 30, 2016

squashed

@eLBati eLBati merged commit 8ac8abc into OCA:10.0 Dec 30, 2016
eLBati pushed a commit to eLBati/l10n-italy that referenced this pull request Mar 20, 2020
@CiroBoxHub @eLBati
[FIX] l10n_it_ateco (OCA#280)
feaa04f 
remove select parameter

add index parameter to parent_id
eLBati pushed a commit to eLBati/l10n-italy that referenced this pull request Mar 20, 2020
@CiroBoxHub @eLBati
[FIX] l10n_it_ateco (OCA#280)
f09c9f8 
remove select parameter

add index parameter to parent_id
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Mar 5, 2021
@CiroBoxHub @Borruso
[FIX] l10n_it_ateco (OCA#280)
67ee706 
remove select parameter

add index parameter to parent_id
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Apr 9, 2021
@CiroBoxHub @Borruso
[FIX] l10n_it_ateco (OCA#280)
94f1a6f 
remove select parameter

add index parameter to parent_id
tafaRU pushed a commit to tafaRU/l10n-italy that referenced this pull request Apr 9, 2021
@CiroBoxHub @tafaRU
[FIX] l10n_it_ateco (OCA#280)
fda2791 
remove select parameter

add index parameter to parent_id
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Oct 10, 2022
@CiroBoxHub @Borruso
[FIX] l10n_it_ateco (OCA#280)
00e6969 
remove select parameter

add index parameter to parent_id
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Nov 11, 2022
@CiroBoxHub @Borruso
[FIX] l10n_it_ateco (OCA#280)
558bf88 
remove select parameter

add index parameter to parent_id
tafaRU pushed a commit to tafaRU/l10n-italy that referenced this pull request Nov 11, 2022
@CiroBoxHub @tafaRU
[FIX] l10n_it_ateco (OCA#280)
67a967d 
remove select parameter

add index parameter to parent_id
TonyMasciI pushed a commit to saydigital/l10n-italy that referenced this pull request Jan 9, 2023
@CiroBoxHub @TonyMasciI
[FIX] l10n_it_ateco (OCA#280)
1752f2f 
remove select parameter

add index parameter to parent_id
TonyMasciI pushed a commit to saydigital/l10n-italy that referenced this pull request Jan 16, 2023
@CiroBoxHub @TonyMasciI
[FIX] l10n_it_ateco (OCA#280)
d891f97 
remove select parameter

add index parameter to parent_id
TonyMasciI pushed a commit to saydigital/l10n-italy that referenced this pull request Jan 27, 2023
@CiroBoxHub @TonyMasciI
[FIX] l10n_it_ateco (OCA#280)
7982036 
remove select parameter

add index parameter to parent_id
are-agilebg pushed a commit to are-agilebg/l10n-italy that referenced this pull request May 10, 2023
@CiroBoxHub @are-agilebg
[FIX] l10n_it_ateco (OCA#280)
e882134 
remove select parameter

add index parameter to parent_id
are-agilebg pushed a commit to are-agilebg/l10n-italy that referenced this pull request May 10, 2023
@CiroBoxHub @are-agilebg
[FIX] l10n_it_ateco (OCA#280)
a3e96b8 
remove select parameter

add index parameter to parent_id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susport susport susport left review comments

@eLBati eLBati eLBati approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CiroBoxHub @OpenCode @eLBati @andrea4ever @susport