Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] l10n_it_appointment_code #3001

Merged
merged 3 commits into from
Nov 25, 2022
Merged

[16.0][MIG] l10n_it_appointment_code #3001

merged 3 commits into from
Nov 25, 2022

Conversation

Borruso
Copy link
Contributor

@Borruso Borruso commented Nov 3, 2022

Migration l10n_it_appointment_code from 14.0 to 16.0

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@Borruso Borruso force-pushed the 16.0-mig-l10n_it_appointment_code branch from d3749e6 to ed17ee8 Compare November 4, 2022 10:14
@primes2h
Copy link
Contributor

primes2h commented Nov 8, 2022

/ocabot migration l10n_it_appointment_code

@Borruso Borruso mentioned this pull request Nov 10, 2022
Open
79 tasks
@Borruso Borruso force-pushed the 16.0-mig-l10n_it_appointment_code branch from ed17ee8 to 7603ac9 Compare November 10, 2022 10:42
@Borruso Borruso marked this pull request as ready for review November 10, 2022 10:43
SirTakobi
SirTakobi suggested changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@SirTakobi SirTakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie della PR!
Puoi squashare i commit amministrativi come indicato in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0#tasks-to-do-in-the-migration?
Ho trovato un problema di visualizzazione, per correggere ti ho proposto Borruso#12, puoi vedere se va bene ed eventualmente mergiarla?

@Borruso Borruso force-pushed the 16.0-mig-l10n_it_appointment_code branch 2 times, most recently from ef32c68 to 4cebbb0 Compare November 11, 2022 09:13
tafaRU
tafaRU requested changes Nov 14, 2022
View reviewed changes
Copy link
Member

@tafaRU tafaRU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In aggiunta, puoi schiacciare i tre commits seguenti in uno solo? I due amministrativi con il primo.
image

Per il resto LGTM, l'ho anche testato su runboat 👍

l10n_it_appointment_code/i18n/it.po Outdated Show resolved Hide resolved
@Borruso Borruso force-pushed the 16.0-mig-l10n_it_appointment_code branch from 4cebbb0 to 89dacab Compare November 14, 2022 13:41
tafaRU and others added 3 commits November 14, 2022 18:13
@tafaRU @Borruso
Rename module to l10n_it_appointment_code
b729e72 
Rename cannot be perfomed with hook as OCA#2220 (comment)
Also note:

* merge_modules = True is not needed when we simply rename modules
* rename_xmlids has to be executed as first to build menus_by_module properly otherwise we get:
test-l10n_it_codici_carica=# select id ,name, menus_by_module from ir_module_module where name like '%appointment%';
 id  |           name           |                   menus_by_module
-----+--------------------------+------------------------------------------------------
 488 | l10n_it_appointment_code | Invoicing/Configuration/Accounting/Appointment Codes+
     |                          | Invoicing/Configuration/Accounting/Role Codes

[UPD] Update l10n_it_appointment_code.pot

[UPD] README.rst
@Borruso
[IMP] l10n_it_appointment_code: pre-commit stuff
068c805
@Borruso
[MIG] l10n_it_appointment_code: Migration to 16.0
8db8d3c
@Borruso Borruso force-pushed the 16.0-mig-l10n_it_appointment_code branch from 89dacab to 8db8d3c Compare November 14, 2022 17:14
@tafaRU
Copy link
Member

tafaRU commented Nov 15, 2022

@SirTakobi potresti aggiornare la tua review?

warp10
warp10 approved these changes Nov 18, 2022
View reviewed changes
Copy link

@warp10 warp10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM.

SirTakobi
SirTakobi approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@SirTakobi SirTakobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revisione dei commit, del codice e provato in runboat, per me è ok

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@tafaRU
Copy link
Member

tafaRU commented Nov 25, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-3001-by-tafaRU-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c7bd567 into OCA:16.0 Nov 25, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7242684. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirTakobi SirTakobi SirTakobi approved these changes

@tafaRU tafaRU tafaRU approved these changes

@warp10 warp10 warp10 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Borruso @primes2h @tafaRU @OCA-git-bot @warp10 @SirTakobi @francesco-ooops