-
-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] l10n_it_website_sale_fiscalcode: Migration to 14.0 #3214
[MIG] l10n_it_website_sale_fiscalcode: Migration to 14.0 #3214
Conversation
…fiscalcode on checkout form [temp] temp commit [FIX] reboot
d431817
to
d79a8c6
Compare
2761b1b
to
0587c48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review, LGTM
======================= | ||
Website Sale FiscalCode | ||
======================= | ||
|
||
.. !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
!! This file is generated by oca-gen-addon-readme !! | ||
!! changes will be overwritten. !! | ||
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
|
||
.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png | ||
:target: https://odoo-community.org/page/development-status | ||
:alt: Beta | ||
.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png | ||
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html | ||
:alt: License: AGPL-3 | ||
.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fl10n--italy-lightgray.png?logo=github | ||
:target: https://github.com/OCA/l10n-italy/tree/12.0/l10n_it_website_sale_fiscalcode | ||
:alt: OCA/l10n-italy | ||
.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png | ||
:target: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_website_sale_fiscalcode | ||
:alt: Translate me on Weblate | ||
.. |badge5| image:: https://img.shields.io/badge/runbot-Try%20me-875A7B.png | ||
:target: https://runbot.odoo-community.org/runbot/122/12.0 | ||
:alt: Try me on Runbot | ||
|
||
|badge1| |badge2| |badge3| |badge4| |badge5| | ||
|
||
**Italiano** | ||
|
||
Questo modulo aggiunge il codice fiscale nel form del checkout. | ||
|
||
**English** | ||
|
||
This module adds fiscal code in the checkout form. | ||
|
||
**Table of contents** | ||
|
||
.. contents:: | ||
:local: | ||
|
||
Usage | ||
===== | ||
|
||
**Italiano** | ||
|
||
Per utilizzare questo modulo: | ||
|
||
* Andare nel negozio; | ||
* Comprare qualcosa; | ||
* Aggiungere il codice fiscale nel form del checkout. | ||
|
||
**English** | ||
|
||
To use this module, you need to: | ||
|
||
* Go to Shop; | ||
* Buy something; | ||
* Add fiscal code in the checkout form. | ||
|
||
Bug Tracker | ||
=========== | ||
|
||
Bugs are tracked on `GitHub Issues <https://github.com/OCA/l10n-italy/issues>`_. | ||
In case of trouble, please check there if your issue has already been reported. | ||
If you spotted it first, help us smashing it by providing a detailed and welcomed | ||
`feedback <https://github.com/OCA/l10n-italy/issues/new?body=module:%20l10n_it_website_sale_fiscalcode%0Aversion:%2012.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_. | ||
|
||
Do not contact contributors directly about support or help with technical issues. | ||
|
||
Credits | ||
======= | ||
|
||
Authors | ||
~~~~~~~ | ||
|
||
* Agile Business Group | ||
|
||
Contributors | ||
~~~~~~~~~~~~ | ||
|
||
* Nicola Malcontenti <nicola.malcontenti@agilebg.com> | ||
* Alessio Gerace <alessio.gerace@agilebg.com> | ||
|
||
Maintainers | ||
~~~~~~~~~~~ | ||
|
||
This module is maintained by the OCA. | ||
|
||
.. image:: https://odoo-community.org/logo.png | ||
:alt: Odoo Community Association | ||
:target: https://odoo-community.org | ||
|
||
OCA, or the Odoo Community Association, is a nonprofit organization whose | ||
mission is to support the collaborative development of Odoo features and | ||
promote its widespread use. | ||
|
||
This module is part of the `OCA/l10n-italy <https://github.com/OCA/l10n-italy/tree/12.0/l10n_it_website_sale_fiscalcode>`_ project on GitHub. | ||
|
||
You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update references to v14
for example: https://github.com/OCA/l10n-italy/tree/12.0/l10n_it_website_sale_fiscalcode
--> https://github.com/OCA/l10n-italy/tree/14.0/l10n_it_website_sale_fiscalcode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
0587c48
to
66c4223
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Funzionalmente non è come la 12, in questo video il flusso nel runbot 12 vs flusso runbot di questa PR: https://recordit.co/Mi5T9znYwb
@baba75 E' possibile riprendere il comportamento della versione precedente?
66c4223
to
5c8f4dc
Compare
Grazie @francesco-ooops, mi sembra che adesso funzioni |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional ok!
Nel frattempo sto usando questa migrazione anche su una versione 16 e funziona così com'è senza cambiare nulla 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baba75 grazie 1K per la PR!
Rimane ancora un'operazione prima di poter eseguire il merge: lo squash dei commit amministrativi (Rif. https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate).
FIX frontend checkout view and mandatory fields
[IMP] l10n_it_website_sale_fiscalcode: Assume that users are always people (same assumption of Odoo core)
…n't have a Fiscal Code
Currently translated at 100.0% (2 of 2 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_website_sale_fiscalcode Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_website_sale_fiscalcode/it/
…nstalled, it does not make sense to not install it
5c8f4dc
to
c58339a
Compare
Grazie @tafaRU, ho seguito la guida, però non capisco perché il messaggio di commit mi appare 3 volte... cosa ho sbagliato? |
puoi fare |
c58339a
to
fef91c8
Compare
@baba75 come mai hai cancellato i file |
@tafaRU Hai ragione... ero convinto di averlo letto da qualche parte. Grazie per la pazienza con i principianti ! |
a47963f
to
4c5503c
Compare
4c5503c
to
62e3a89
Compare
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 2d6bbe2. Thanks a lot for contributing to OCA. ❤️ |
No description provided.