Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] l10n_it_website_sale_fiscalcode: Migration to 14.0 #3214

Merged
merged 12 commits into from
Sep 12, 2023

Conversation

baba75
Copy link

@baba75 baba75 commented Mar 16, 2023

No description provided.

…fiscalcode on checkout form

[temp] temp commit

[FIX] reboot
@tafaRU tafaRU mentioned this pull request Mar 16, 2023
76 tasks
@baba75 baba75 force-pushed the 14.0-mig-l10n_it_website_sale_fiscalcode branch 4 times, most recently from d431817 to d79a8c6 Compare March 20, 2023 10:56
@baba75 baba75 force-pushed the 14.0-mig-l10n_it_website_sale_fiscalcode branch 3 times, most recently from 2761b1b to 0587c48 Compare March 23, 2023 15:07
Copy link
Contributor

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

Comment on lines 1 to 99
=======================
Website Sale FiscalCode
=======================

.. !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! This file is generated by oca-gen-addon-readme !!
!! changes will be overwritten. !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
:target: https://odoo-community.org/page/development-status
:alt: Beta
.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
:alt: License: AGPL-3
.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fl10n--italy-lightgray.png?logo=github
:target: https://github.com/OCA/l10n-italy/tree/12.0/l10n_it_website_sale_fiscalcode
:alt: OCA/l10n-italy
.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
:target: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_website_sale_fiscalcode
:alt: Translate me on Weblate
.. |badge5| image:: https://img.shields.io/badge/runbot-Try%20me-875A7B.png
:target: https://runbot.odoo-community.org/runbot/122/12.0
:alt: Try me on Runbot

|badge1| |badge2| |badge3| |badge4| |badge5|

**Italiano**

Questo modulo aggiunge il codice fiscale nel form del checkout.

**English**

This module adds fiscal code in the checkout form.

**Table of contents**

.. contents::
:local:

Usage
=====

**Italiano**

Per utilizzare questo modulo:

* Andare nel negozio;
* Comprare qualcosa;
* Aggiungere il codice fiscale nel form del checkout.

**English**

To use this module, you need to:

* Go to Shop;
* Buy something;
* Add fiscal code in the checkout form.

Bug Tracker
===========

Bugs are tracked on `GitHub Issues <https://github.com/OCA/l10n-italy/issues>`_.
In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us smashing it by providing a detailed and welcomed
`feedback <https://github.com/OCA/l10n-italy/issues/new?body=module:%20l10n_it_website_sale_fiscalcode%0Aversion:%2012.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.

Do not contact contributors directly about support or help with technical issues.

Credits
=======

Authors
~~~~~~~

* Agile Business Group

Contributors
~~~~~~~~~~~~

* Nicola Malcontenti <nicola.malcontenti@agilebg.com>
* Alessio Gerace <alessio.gerace@agilebg.com>

Maintainers
~~~~~~~~~~~

This module is maintained by the OCA.

.. image:: https://odoo-community.org/logo.png
:alt: Odoo Community Association
:target: https://odoo-community.org

OCA, or the Odoo Community Association, is a nonprofit organization whose
mission is to support the collaborative development of Odoo features and
promote its widespread use.

This module is part of the `OCA/l10n-italy <https://github.com/OCA/l10n-italy/tree/12.0/l10n_it_website_sale_fiscalcode>`_ project on GitHub.

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update references to v14

for example: https://github.com/OCA/l10n-italy/tree/12.0/l10n_it_website_sale_fiscalcode
--> https://github.com/OCA/l10n-italy/tree/14.0/l10n_it_website_sale_fiscalcode

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@baba75 baba75 force-pushed the 14.0-mig-l10n_it_website_sale_fiscalcode branch from 0587c48 to 66c4223 Compare May 9, 2023 16:19
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funzionalmente non è come la 12, in questo video il flusso nel runbot 12 vs flusso runbot di questa PR: https://recordit.co/Mi5T9znYwb

@baba75 E' possibile riprendere il comportamento della versione precedente?

@baba75 baba75 force-pushed the 14.0-mig-l10n_it_website_sale_fiscalcode branch from 66c4223 to 5c8f4dc Compare May 12, 2023 12:53
@baba75
Copy link
Author

baba75 commented May 12, 2023

Grazie @francesco-ooops, mi sembra che adesso funzioni

Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional ok!

@aleuffre
Copy link
Contributor

Nel frattempo sto usando questa migrazione anche su una versione 16 e funziona così com'è senza cambiare nulla 🎉

Copy link
Member

@tafaRU tafaRU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baba75 grazie 1K per la PR!

Rimane ancora un'operazione prima di poter eseguire il merge: lo squash dei commit amministrativi (Rif. https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate).

image

eLBati and others added 7 commits May 30, 2023 13:57
FIX frontend checkout view and mandatory fields
[IMP] l10n_it_website_sale_fiscalcode: Assume that users are always people (same assumption of Odoo core)
Currently translated at 100.0% (2 of 2 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_website_sale_fiscalcode
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_website_sale_fiscalcode/it/
…nstalled, it does not make sense to not install it
@baba75 baba75 force-pushed the 14.0-mig-l10n_it_website_sale_fiscalcode branch from 5c8f4dc to c58339a Compare May 30, 2023 11:57
@baba75
Copy link
Author

baba75 commented May 30, 2023

Grazie @tafaRU, ho seguito la guida, però non capisco perché il messaggio di commit mi appare 3 volte... cosa ho sbagliato?
commit

@tafaRU
Copy link
Member

tafaRU commented May 31, 2023

però non capisco perché il messaggio di commit mi appare 3 volte

puoi fare git commit --amend in modo da editare il messaggio di commit.

@baba75 baba75 force-pushed the 14.0-mig-l10n_it_website_sale_fiscalcode branch from c58339a to fef91c8 Compare May 31, 2023 08:22
@tafaRU
Copy link
Member

tafaRU commented May 31, 2023

@baba75 come mai hai cancellato i file po? Non andrebbero eliminati.

@baba75
Copy link
Author

baba75 commented May 31, 2023

@tafaRU Hai ragione... ero convinto di averlo letto da qualche parte. Grazie per la pazienza con i principianti !

@baba75 baba75 force-pushed the 14.0-mig-l10n_it_website_sale_fiscalcode branch 2 times, most recently from a47963f to 4c5503c Compare May 31, 2023 09:43
@baba75 baba75 force-pushed the 14.0-mig-l10n_it_website_sale_fiscalcode branch from 4c5503c to 62e3a89 Compare May 31, 2023 10:51
@baba75 baba75 requested a review from tafaRU June 1, 2023 07:30
@tafaRU
Copy link
Member

tafaRU commented Sep 12, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-3214-by-tafaRU-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 993774a into OCA:14.0 Sep 12, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2d6bbe2. Thanks a lot for contributing to OCA. ❤️

@baba75 baba75 deleted the 14.0-mig-l10n_it_website_sale_fiscalcode branch September 12, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants