Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] l10n_it_pos_fatturapa: Migration to 14.0 #3315

Closed
wants to merge 4 commits into from

Conversation

caiuka
Copy link

@caiuka caiuka commented May 19, 2023

Migrazione del modulo dalla v12 alla v14

Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review ok!

@francesco-ooops
Copy link
Contributor

@robyf70 che ne pensi?

@francesco-ooops
Copy link
Contributor

possiamo aggiungere a #1905 ?

@OpenCode OpenCode mentioned this pull request May 25, 2023
76 tasks
@OpenCode
Copy link
Contributor

possiamo aggiungere a #1905 ?

Fatto

Comment on lines +9 to +11
constructor() {
super(...arguments);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non mi pare sia strettamente necessario

@francesco-ooops
Copy link
Contributor

@robyf70 quando hai un momento ;)

Copy link
Contributor

@robyf70 robyf70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il resto LGTM

@api.model
def create_from_ui(self, partner):
if "electronic_invoice_subjected" in partner:
electronic_invoice_subjected = bool(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La get() non ritorna un bool?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, ritorna un None

Comment on lines +9 to +11
constructor() {
super(...arguments);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non necessario

@caiuka caiuka force-pushed the 14.0-mig-l10n_it_pos_fatturapa branch from 02b7ed3 to be4b8bb Compare June 8, 2023 06:30
@francesco-ooops
Copy link
Contributor

@robyf70 @GSLabIt ok ora?

@francesco-ooops
Copy link
Contributor

@caiuka rebase

@caiuka caiuka force-pushed the 14.0-mig-l10n_it_pos_fatturapa branch 3 times, most recently from 3b1cd83 to 321c236 Compare June 23, 2023 09:33
@caiuka caiuka closed this Jun 29, 2023
@caiuka caiuka deleted the 14.0-mig-l10n_it_pos_fatturapa branch June 29, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants