Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] l10n_it_intrastat_statement #3327

Merged
merged 43 commits into from
Oct 6, 2023
Merged

[16.0][MIG] l10n_it_intrastat_statement #3327

merged 43 commits into from
Oct 6, 2023

Conversation

Borruso
Copy link
Contributor

@Borruso Borruso commented May 25, 2023

Migration l10n_it_intrastat_statement from 14.0 to 16.0

--
Confermo di aver firmato il CLA https://odoo-community.org/page/cla e di aver letto le linee guida su https://odoo-community.org/page/contributing

@Borruso Borruso mentioned this pull request May 25, 2023
Open
79 tasks
@tafaRU
Copy link
Member

tafaRU commented May 25, 2023

/ocabot migration l10n_it_intrastat_statement

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone May 25, 2023
@Borruso Borruso force-pushed the 16.0-mig-l10n_it_intrastat_statement branch 3 times, most recently from f0e1064 to 3294771 Compare May 25, 2023 09:01
@DinamicheAziendali DinamicheAziendali mentioned this pull request Jun 29, 2023
Open
8 tasks
@Borruso Borruso force-pushed the 16.0-mig-l10n_it_intrastat_statement branch from 3294771 to c5e310a Compare July 21, 2023 12:24
@TheMule71
Copy link
Contributor

Pura curiosità, vedo https://github.com/Borruso/l10n-italy/blob/c5e310ae4fd0da8e941ed7ba6558bb3bce55755e/l10n_it_intrastat_statement/report/report_intrastat_mod1.xml#L7
che usano web.internal_layout, c'entra qualcosa con l10n_it_account.internal_layout e sarebbe meglio usare quello o non c'entra nulla?

@Borruso
Copy link
Contributor Author

Borruso commented Sep 8, 2023

Pura curiosità, vedo https://github.com/Borruso/l10n-italy/blob/c5e310ae4fd0da8e941ed7ba6558bb3bce55755e/l10n_it_intrastat_statement/report/report_intrastat_mod1.xml#L7 che usano web.internal_layout, c'entra qualcosa con l10n_it_account.internal_layout e sarebbe meglio usare quello o non c'entra nulla?

in realtà non ti so dire c'è la stessa cosa in v14

SirAionTech
SirAionTech requested changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@SirAionTech SirAionTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I test sono ❌, puoi verificare?

@Borruso Borruso force-pushed the 16.0-mig-l10n_it_intrastat_statement branch from c5e310a to c1b5b6d Compare September 29, 2023 12:53
@Borruso
Copy link
Contributor Author

Borruso commented Sep 29, 2023

I test sono ❌, puoi verificare?

fatto rabase test rossi per dipendenza

@primes2h
Copy link
Contributor

@Borruso
ci sarebbe da aggiungere qeusto commit b92edb2

@Borruso
Copy link
Contributor Author

Borruso commented Sep 30, 2023 •
edited
Loading

@Borruso ci sarebbe da aggiungere qeusto commit b92edb2

@primes2h ecco a te #3622
appena si mergia qui faccio un rebase

@primes2h
Copy link
Contributor

primes2h commented Oct 2, 2023

@Borruso ci sarebbe da aggiungere qeusto commit b92edb2

@primes2h ecco a te #3622 appena si mergia qui faccio un rebase

Grazie!

SirAionTech
SirAionTech requested changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@SirAionTech SirAionTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie della PR!
Manca qualche commit di 14.0, tipo e7c3c5e, li potresti aggiungere?

Ci sono traduzioni consecutive dello stesso traduttore, ad esempio
image
, le potresti schiacciare come indicato in https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate?

l10n_it_intrastat_statement/wizard/export_file.py Outdated
Comment on lines 31 to 38
if self.env.ref(
"l10n_it_intrastat_statement.wizard_account_intrastat_export_file"
):
view_id = self.env.ref(
"l10n_it_intrastat_statement.wizard_account_intrastat_export_file"
).id
else:
view_id = False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

È possibile evitare di cercare più volte lo stesso riferimento esterno? Va bene che sono nella cache ma è comunque un'operazione che si può evitare.
Penso che questo sia più vicino al codice del modulo prima della migrazione, cosa ne pensi?

Suggested change
if self.env.ref(
"l10n_it_intrastat_statement.wizard_account_intrastat_export_file"
):
view_id = self.env.ref(
"l10n_it_intrastat_statement.wizard_account_intrastat_export_file"
).id
else:
view_id = False
view = self.env.ref(
"l10n_it_intrastat_statement.wizard_account_intrastat_export_file"
)
view_id = view.id

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fatto

Lara Baggio and others added 13 commits October 3, 2023 08:19
@Borruso
porting l10n_it_intrastat to 11
801f7b9
@Borruso
rinominati e spostati file per pulizia
7704b65
@Borruso
[MIG] l10n_it_intrastat: Migration to 12.0
786d9a4
@SimoRubi @Borruso
[IMP] l10n_it_intrastat_statement: Add intra1-ter (#11)
b6301d4
@Borruso
[FIX] Documentation and translation review
92b6c13
@primes2h @Borruso
Translated using Weblate (Italian)
597f1d8 
Currently translated at 77.2% (149 of 193 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_intrastat_statement
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_intrastat_statement/it/
@primes2h @Borruso
[FIX] translation source terms and readme
238e6c5
@primes2h @Borruso
Translated using Weblate (Italian)
f0a2bd4 
Currently translated at 99.0% (191 of 193 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_intrastat_statement
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_intrastat_statement/it/
@Galoperd @Borruso
Added translation using Weblate (Spanish)
c94bedf
@Galoperd @Borruso
Translated using Weblate (Spanish)
8f8d41d 
Currently translated at 6.2% (12 of 193 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_intrastat_statement
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_intrastat_statement/es/
@Borruso
dichiarazione intrastat arrotondamento minimo a 1
443251d
@SimoRubi @Borruso
fix transport code value in purchase section
a3cf0b5 
Prevent following error when computing statement:
psycopg2.ProgrammingError: can't adapt type 'account.intrastat.transport'
@Galoperd @Borruso
Translated using Weblate (Spanish)
99167ff 
Currently translated at 100.0% (193 of 193 strings)

Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_intrastat_statement
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_intrastat_statement/es/
sergiocorato and others added 6 commits October 3, 2023 08:20
@sergiocorato @Borruso
[IMP] intrastat 2022
c5e744e
@SirTakobi @Borruso
[FIX] l10n_it_intrastat_statement: Align headers with columns
6fc56de
@SirTakobi @Borruso
[IMP] l10n_it_intrastat_statement: Update Intra-1 bis report to the l…
0f39bcd 
…atest specification

The new column is defined in the latest version of the specification, updated in the README
@michelerusti @Borruso
[14.0][FIX] l10n_it_intrastat_statement: make transaction_nature_b_id…
20fa39c 
… optional
@michelerusti @Borruso
[14.0][FIX]- l10n_it_intrastat_statement - weight_kg does not have to…
6187f39 
… be always 1 if not > 0
@mymage @Borruso
Translated using Weblate (Italian)
5dc737f 
Currently translated at 100.0% (196 of 196 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_intrastat_statement
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_intrastat_statement/it/
@Borruso Borruso force-pushed the 16.0-mig-l10n_it_intrastat_statement branch from c1b5b6d to 501deea Compare October 3, 2023 06:20
@Borruso
Copy link
Contributor Author

Borruso commented Oct 3, 2023

Grazie della PR! Manca qualche commit di 14.0, tipo e7c3c5e, li potresti aggiungere?

Ci sono traduzioni consecutive dello stesso traduttore, ad esempio image , le potresti schiacciare come indicato in https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate?

fatto

@SirAionTech
Copy link
Contributor

Grazie della PR! Manca qualche commit di 14.0, tipo e7c3c5e, li potresti aggiungere?
Ci sono traduzioni consecutive dello stesso traduttore, ad esempio image , le potresti schiacciare come indicato in https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate?

fatto

Grazie, quando hai finito con le modifiche ricorda per favore di chiedermi di aggiornare la revisione in
image

SirAionTech
SirAionTech requested changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@SirAionTech SirAionTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manca qualche commit di 14.0, tipo e7c3c5e, li potresti aggiungere?

@Borruso Borruso requested a review from SirAionTech October 5, 2023 13:51
@Borruso Borruso force-pushed the 16.0-mig-l10n_it_intrastat_statement branch from cba2e82 to a7d7a99 Compare October 5, 2023 14:01
andreampiovesana
andreampiovesana approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - functional test ok

MaurizioPellegrinet
MaurizioPellegrinet approved these changes Oct 5, 2023
View reviewed changes
Copy link

@MaurizioPellegrinet MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tafaRU
Copy link
Member

tafaRU commented Oct 6, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-3327-by-tafaRU-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 04e7b0b into OCA:16.0 Oct 6, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 61d271e. Thanks a lot for contributing to OCA. ❤️

@SirAionTech SirAionTech mentioned this pull request Jan 15, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirAionTech SirAionTech SirAionTech approved these changes

@MaurizioPellegrinet MaurizioPellegrinet MaurizioPellegrinet approved these changes

@andreampiovesana andreampiovesana andreampiovesana approved these changes

@tafaRU tafaRU tafaRU approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs functional review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.