Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG]l10n_it_fiscalcode_sale #3342

Closed
wants to merge 3,957 commits into from
Closed

[16.0][MIG]l10n_it_fiscalcode_sale #3342

wants to merge 3,957 commits into from

Conversation

odooNextev
Copy link
Contributor

No description provided.

matteonext and others added 30 commits April 7, 2023 13:47
@matteonext
[MIG]l10n_it_asset_history_import: Migration to 14.0
d912db5
@OCA-git-bot
Merge PR OCA#2981 into 14.0
368dc77 
Signed-off-by tafaRU
[UPD] Update l10n_it_intrastat.pot
46dd047
@OCA-git-bot
l10n_it_intrastat_statement 14.0.1.3.0
72a1a08
@OCA-git-bot
l10n_it_intrastat 14.0.1.3.0
55240fa
@OCA-git-bot
[UPD] addons table in README.md
de4c6a2
@francesco-ooops @weblate
Translated using Weblate (Italian)
c5b133d 
Currently translated at 95.2% (258 of 271 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_delivery_note
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_delivery_note/it/
@weblate
Update translation files
e71658b 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_intrastat
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_intrastat/
@OCA-git-bot
Merge PR OCA#3261 into 14.0
58cf17f 
Signed-off-by primes2h
[UPD] Update l10n_it_asset_history_import.pot
756cc6b
@OCA-git-bot
[UPD] addons table in README.md
3020121
@OCA-git-bot
[UPD] README.rst
24f0697
@OCA-git-bot
[ADD] setup.py
c9cb183
@francesco-ooops @weblate
Added translation using Weblate (Italian)
5dcffdd
@francesco-ooops @weblate
Translated using Weblate (Italian)
d0cffc9 
Currently translated at 98.1% (266 of 271 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_delivery_note
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_delivery_note/it/
@francesco-ooops @weblate
Translated using Weblate (Italian)
7ba55f2 
Currently translated at 98.2% (55 of 56 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_central_journal
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_central_journal/it/
@francesco-ooops @weblate
Translated using Weblate (Italian)
5e0083d 
Currently translated at 100.0% (4 of 4 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_vat_registries_split_payment
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_vat_registries_split_payment/it/
@francesco-ooops @weblate
Translated using Weblate (Italian)
f7bcd2d 
Currently translated at 77.7% (7 of 9 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_vat_statement_split_payment
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_vat_statement_split_payment/it/
@francesco-ooops @weblate
Translated using Weblate (Italian)
30ba819 
Currently translated at 94.7% (108 of 114 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_withholding_tax
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_withholding_tax/it/
@francesco-ooops @weblate
Translated using Weblate (Italian)
9763405 
Currently translated at 100.0% (73 of 73 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_sdi_channel
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_sdi_channel/it/
@francesco-ooops @weblate
Translated using Weblate (Italian)
3153cfa 
Currently translated at 100.0% (224 of 224 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_ricevute_bancarie
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_ricevute_bancarie/it/
@francesco-ooops @weblate
Translated using Weblate (Italian)
749ab70 
Currently translated at 100.0% (4 of 4 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_location_nuts
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_location_nuts/it/
@francesco-ooops @weblate
Translated using Weblate (Italian)
c879ab9 
Currently translated at 99.3% (443 of 446 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-assets_management
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-assets_management/it/
@francesco-ooops @weblate
Translated using Weblate (Italian)
3e9afd3 
Currently translated at 100.0% (7 of 7 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_fatturapa_sdicoop
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_fatturapa_sdicoop/it/
@primes2h @weblate
Translated using Weblate (Italian)
0cdd217 
Currently translated at 99.3% (443 of 446 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-assets_management
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-assets_management/it/
@primes2h @weblate
Translated using Weblate (Italian)
71716ee 
Currently translated at 100.0% (65 of 65 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_asset_history_import
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_asset_history_import/it/
@sysadminmatmoz @weblate
Translated using Weblate (Slovenian)
461b11e 
Currently translated at 80.4% (33 of 41 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_fiscalcode
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_fiscalcode/sl/
@sysadminmatmoz @weblate
Translated using Weblate (Slovenian)
042b54d 
Currently translated at 7.3% (19 of 260 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_fatturapa
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_fatturapa/sl/
@sysadminmatmoz @weblate
Translated using Weblate (Slovenian)
1affda7 
Currently translated at 8.0% (12 of 149 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_fatturapa_out
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_fatturapa_out/sl/
@sergiocorato @weblate
Translated using Weblate (Italian)
82c79e0 
Currently translated at 99.5% (444 of 446 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-assets_management
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-assets_management/it/
OCA-git-bot and others added 4 commits June 19, 2023 16:07
@OCA-git-bot
[UPD] README.rst
2375b4a
@OCA-git-bot
[ADD] setup.py
b9ce9eb
@mymage @weblate
Translated using Weblate (Italian)
a22d4f5 
Currently translated at 100.0% (150 of 150 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_fatturapa_out
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_fatturapa_out/it/
@mymage @weblate
Translated using Weblate (Italian)
38d5c60 
Currently translated at 100.0% (45 of 45 strings)

Translation: l10n-italy-14.0/l10n-italy-14.0-l10n_it_delivery_note_rma
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-14-0/l10n-italy-14-0-l10n_it_delivery_note_rma/it/
@odooNextev odooNextev force-pushed the 16.0-mig-l10n_it_fiscalcode_sale branch from 5372788 to dbf1d83 Compare July 6, 2023 12:55
@odooNextev
Copy link
Contributor Author

Ho appena fatto lo squash dei commit, penso servano solo test funzionali, ma è abbastanza banale

@tafaRU
Copy link
Member

tafaRU commented Jul 6, 2023

@odooNextev non vedo il commit ... pre-commit stuff: puoi verificare?

@odooNextev
Copy link
Contributor Author

@odooNextev non vedo il commit ... pre-commit stuff: puoi verificare?

Pensavo servisse solo per le operazioni preliminari e poi alla fine si squasha tutto in uno di migrazione "[MIG] nome modulo"
Se devo rimetterlo devo resettare e rifare

@tafaRU
Copy link
Member

tafaRU commented Jul 7, 2023

@odooNextev trattandosi di una migrazione di un modulo occorre seguire le indicazioni contenute in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0

@odooNextev
Copy link
Contributor Author

@tafaRU adesso ricordo...
Tecnicamente il commit "[MIG] l10n_it_fiscalcode_sale: Migration to 16.0" sarebbe ... pre-commit stuff, ma a cui ho cambiato il nome con reword perchè altrimenti avrei dovuto fare un commit vuoto per "[MIG] $module: Migration to 16.0".
L'unica modifica di cui il modulo necessità per funzionare sulla 16 è quella della version nel manifest che è obbligatoria per fare un commit con precommit attivato.

Faccio il reword per ripristinare il nome e poi un commit vuoto con "[MIG] $module: Migration to 16.0"?

@tafaRU
Copy link
Member

tafaRU commented Jul 7, 2023

perchè altrimenti avrei dovuto fare un commit vuoto per "[MIG] $module: Migration to 16.0".

il cambio della versione non è sufficiente?

@odooNextev
Copy link
Contributor Author

perchè altrimenti avrei dovuto fare un commit vuoto per "[MIG] $module: Migration to 16.0".

il cambio della versione non è sufficiente?

Precommit mi obbliga a farlo nel "suo" commit pre-commit stuff perchè fallisce altrimenti con la versione non giusta quindi dopo non abbiamo più niente da modificare

@tafaRU
Copy link
Member

tafaRU commented Jul 7, 2023

Precommit mi obbliga a farlo nel "suo" commit pre-commit stuff perchè fallisce altrimenti con la versione non giusta quindi dopo non abbiamo più niente da modificare

Ok ma se adesso sposti il cambio di versione, dovrebbe andare a posto, no?

@odooNextev odooNextev force-pushed the 16.0-mig-l10n_it_fiscalcode_sale branch from dbf1d83 to 7349dad Compare July 7, 2023 15:28
@odooNextev
Copy link
Contributor Author

Precommit mi obbliga a farlo nel "suo" commit pre-commit stuff perchè fallisce altrimenti con la versione non giusta quindi dopo non abbiamo più niente da modificare

Ok ma se adesso sposti il cambio di versione, dovrebbe andare a posto, no?

Ho capito dove sbagliavo... non mettevo --no-verify nel commit di pre-commit...
Adesso però smanettendo sul branch mi ha cancellato i commit di Lorenzo della v12...

MarcoCalcagni
MarcoCalcagni approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@MarcoCalcagni MarcoCalcagni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok test funzionali

@MarcoCalcagni
Copy link
Contributor

@tafaRU @TheMule71 @eLBati
mergiabile

@odooNextev
Copy link
Contributor Author

odooNextev commented Jul 7, 2023 via email

@odooNextev odooNextev force-pushed the 16.0-mig-l10n_it_fiscalcode_sale branch 5 times, most recently from 760d63e to 7231561 Compare July 10, 2023 07:39
@odooNextev
Copy link
Contributor Author

Ora dovrebbe essere a posto

tafaRU
tafaRU requested changes Jul 10, 2023
View reviewed changes
Copy link
Member

@tafaRU tafaRU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rimane un'ultima cosa da fare: schiacciare i commit amministrativi.

image

I blocchi evidenziati con il riquadro rosso li puoi schiacciare con il commit precedente.

Hint: utilizzare i tip presenti in https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

Grazie!

@odooNextev odooNextev closed this Jul 10, 2023
@odooNextev odooNextev force-pushed the 16.0-mig-l10n_it_fiscalcode_sale branch from 7231561 to 38d5c60 Compare July 10, 2023 08:58
@odooNextev odooNextev deleted the 16.0-mig-l10n_it_fiscalcode_sale branch July 11, 2023 11:40
@odooNextev odooNextev mentioned this pull request Jul 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tafaRU tafaRU tafaRU requested changes

@MarcoCalcagni MarcoCalcagni MarcoCalcagni approved these changes

Assignees
No one assigned
Labels
needs functional review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.