Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] l10n_it_fatturapa_import_zip #3526

Closed
wants to merge 4 commits into from
Closed

[ADD] l10n_it_fatturapa_import_zip #3526

wants to merge 4 commits into from

Conversation

SirTakobi
Copy link
Contributor

Sostituisce #2258.

Borruso and others added 4 commits August 17, 2023 09:52
@Borruso @SirTakobi
[ADD] l10n_it_fatturapa_import_zip: aggiunto modulo che permette di i…
a5c3f28 
…mportare in massa e-fatture in/out
@SirTakobi
[REF] l10n_it_fatturapa_in: Allow overrides for importing invoices
4468381 
Also allow to create withholding taxes in other tests
@SirTakobi
[IMP] l10n_it_fatturapa_import_zip: FS-Agnostic file management
582b0fa 
Do not assume there is a `/tmp` directory or that path separator is `/` so that this can also work in other FileSystems than Linux's
@SirTakobi
[REF] l10n_it_fatturapa_import_zip: Invoices creation
aefcf74 
Override exposed methods instead of duplicating
Reuse common tests data
This was referenced Aug 17, 2023
Closed
Closed
@SirTakobi SirTakobi marked this pull request as ready for review August 17, 2023 08:39
@quickpre
Copy link

Revisione funzionale effettuata su runboat, e ha superato tutti i test.

This was referenced Sep 13, 2023
Closed
Open
@SirAionTech
Copy link
Contributor

Revisione funzionale effettuata su runboat, e ha superato tutti i test.

Grazie mille della revisione! Riuscresti a scriverlo sotto forma di review in github?
È sufficiente che:

  1. apri Files Changed in alto,
  2. tasto verde Review changes in alto a destra,
  3. scrivi il commento
  4. selezioni Approve
  5. premi Submit review

C'è qualche screenshot che potrebbe aiutarti in https://www.odoo-italia.org/documentazione/14.0/sviluppo/review.html#revisione-tecnica

quickpre
quickpre approved these changes Sep 13, 2023
View reviewed changes
Copy link

@quickpre quickpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revisione funzionale effettuata su runboat, funziona perfettamente

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

micheledic
micheledic suggested changes Sep 18, 2023
View reviewed changes
l10n_it_fatturapa_import_zip/models/attachment.py
zip_data = base64.b64decode(datas)
with tempfile.NamedTemporaryFile(mode="wb") as tmp_file:
tmp_file.write(zip_data)
with zipfile.ZipFile(tmp_file.name, mode="r") as zip_ref:
Copy link
Contributor

@micheledic micheledic Sep 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

come da commento su PR sulla 16.0 bisogna mettere anche qui un tmp_file.flush() dopo il .write in quanto randomicamente non flusha i dati su file temporaneo e zipfile non riesce ad aprirlo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ho verificato che il problema di CessionarioCommittente era presente anche in questa PR e ho corretto entrambi in #3587, potresti verificare lì se sono risolti?
Grazie mille!

@SirAionTech SirAionTech mentioned this pull request Sep 19, 2023
Merged
@SirAionTech
Copy link
Contributor

Da chiudere, sostituita da #3587

@tafaRU tafaRU closed this Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirAionTech SirAionTech SirAionTech left review comments

@micheledic micheledic micheledic requested changes

@quickpre quickpre quickpre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SirTakobi @quickpre @SirAionTech @OCA-git-bot @micheledic @tafaRU @Borruso