Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX]assets_management: differentiate groups #4113

Merged
merged 2 commits into from
May 2, 2024
Merged

[14.0][FIX]assets_management: differentiate groups #4113

merged 2 commits into from
May 2, 2024

Conversation

PicchiSeba
Copy link
Contributor

@PicchiSeba PicchiSeba commented Apr 22, 2024 •
edited
Loading

Add an additional group that glues assets_management.group_asset_user and account.group_account_invoice together

@PicchiSeba PicchiSeba marked this pull request as ready for review April 22, 2024 11:49
@matteoopenf
Copy link
Contributor

puoi aprire una issue per tracciare la cosa?

@francesco-ooops francesco-ooops mentioned this pull request Apr 22, 2024
Open
2 tasks
@francesco-ooops francesco-ooops linked an issue Apr 22, 2024 that may be closed by this pull request
[BUG] - assets_management: billing user can't access invoices #4114
Open
2 tasks
@PicchiSeba PicchiSeba changed the title [14.0][FIX]assets_management: differenciate groups [14.0][FIX]assets_management: differentiate groups Apr 22, 2024
@PicchiSeba PicchiSeba force-pushed the 14.0-assets_management-fix-groups branch from 5f32e26 to d595563 Compare April 22, 2024 13:42
francesco-ooops
francesco-ooops approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aleuffre
aleuffre approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@francesco-ooops
Copy link
Contributor

@sergiocorato buona per il merge?

@sergiocorato
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-4113-by-sergiocorato-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 30, 2024
@OCA-git-bot
Merge PR #4113 into 14.0
a7f3c70 
Signed-off-by sergiocorato
@OCA-git-bot
Copy link
Contributor

@sergiocorato your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-4113-by-sergiocorato-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

1 similar comment
@OCA-git-bot
Copy link
Contributor

@sergiocorato your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-4113-by-sergiocorato-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@francesco-ooops
Copy link
Contributor

@SirAionTech dato che hai seguito la questione codecov, basta un rebase qui o c'è altro da fare? grazie!

@SirAionTech
Copy link
Contributor

@SirAionTech dato che hai seguito la questione codecov, basta un rebase qui o c'è altro da fare? grazie!

Basta un rebase perché le modifiche sono già in 14.0 (3364687).

@PicchiSeba PicchiSeba force-pushed the 14.0-assets_management-fix-groups branch from ff4eff6 to 242b8e0 Compare May 2, 2024 08:07
@PicchiSeba
Copy link
Contributor Author

@sergiocorato potresti riavviare il merge?

@francesco-ooops
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-4113-by-francesco-ooops-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 06326fd into OCA:14.0 May 2, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at db45e18. Thanks a lot for contributing to OCA. ❤️

@PicchiSeba PicchiSeba deleted the 14.0-assets_management-fix-groups branch May 2, 2024 10:52
@francesco-ooops francesco-ooops mentioned this pull request Dec 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleuffre aleuffre aleuffre approved these changes

@francesco-ooops francesco-ooops francesco-ooops approved these changes

@sergiocorato sergiocorato sergiocorato approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] - assets_management: billing user can't access invoices
7 participants
@PicchiSeba @matteoopenf @OCA-git-bot @francesco-ooops @sergiocorato @SirAionTech @aleuffre