Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] l10n_it_vat_settlement_date: Migration to 14.0 #4338

Merged
merged 11 commits into from
Sep 30, 2024
Merged

[MIG] l10n_it_vat_settlement_date: Migration to 14.0 #4338

merged 11 commits into from
Sep 30, 2024

Conversation

sergiocorato
Copy link
Contributor

@sergiocorato sergiocorato commented Aug 27, 2024 •
edited
Loading

@sergiocorato sergiocorato mentioned this pull request Aug 27, 2024
Closed
2 tasks
@SirAionTech SirAionTech added the needs fixing Has conflicts or is failing mandatory CI checks label Aug 27, 2024
@SirAionTech SirAionTech linked an issue Aug 27, 2024 that may be closed by this pull request
Retrodatare detrazione iva fatture #4034
Closed
2 tasks
@sergiocorato sergiocorato force-pushed the 14.0-mig-l10n_it_vat_settlement_date branch 5 times, most recently from 8545b1b to 681b331 Compare August 27, 2024 16:27
@eLBati
Copy link
Member

eLBati commented Aug 29, 2024

@sergiocorato grazie!

Riesci a verificare i test?

@SirAionTech
Copy link
Contributor

@sergiocorato la modifica a account_tax_balance non credo serva più come dipendenza, anche nella #4062 non serviva più dopo la rimozione dell'override di _account_tax_ids_with_moves_query in https://github.com/OCA/l10n-italy/compare/79985dd32f86ba45ddef6659ffdb88fa37e195d5..f089e24bfe83fa5fbcd490ee7b5684401d97f52f, ho aggiornato la descrizione.

@sergiocorato
Copy link
Contributor Author

@sergiocorato la modifica a account_tax_balance non credo serva più come dipendenza, anche nella #4062 non serviva più dopo la rimozione dell'override di _account_tax_ids_with_moves_query in https://github.com/OCA/l10n-italy/compare/79985dd32f86ba45ddef6659ffdb88fa37e195d5..f089e24bfe83fa5fbcd490ee7b5684401d97f52f, ho aggiornato la descrizione.

Ah, ok grazie

MaurizioPellegrinet
MaurizioPellegrinet reviewed Sep 2, 2024
View reviewed changes
Copy link

@MaurizioPellegrinet MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ho provato a fare un test funzionale ma la competenza IVA sulle liquidazioni non si aggancia al mese corretto.
Allego alcuni screen:

  • pr4338_a date indicate in fattura
  • pr4338_b registro iva acquisti
  • pr4338_c liquidazione iva agosto
  • pr4338_d liquidazione iva settembre
    Come indicato in fattura l'IVA dovrebbe essere indicata sul mese di agosto
    pr4338_a
    pr4338_b
    pr4338_c
    pr4338_d

@LorenzoC0 LorenzoC0 mentioned this pull request Sep 27, 2024
Merged
@eLBati
Copy link
Member

eLBati commented Sep 27, 2024

Ho provato a fare un test funzionale ma la competenza IVA sulle liquidazioni non si aggancia al mese corretto. Allego alcuni screen:

Correggendo con #4388

@eLBati eLBati mentioned this pull request Sep 27, 2024
Open
@eLBati
Copy link
Member

eLBati commented Sep 30, 2024

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@eLBati The rebase process failed, because command git push --force efatto tmp-pr-4338:14.0-mig-l10n_it_vat_settlement_date failed with output:

remote: Permission to efatto/l10n-italy.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/efatto/l10n-italy/': The requested URL returned error: 403

@eLBati
Copy link
Member

eLBati commented Sep 30, 2024

Ho provato a fare un test funzionale ma la competenza IVA sulle liquidazioni non si aggancia al mese corretto. Allego alcuni screen:

Correggendo con #4388

merged

TheMule71 and others added 10 commits September 30, 2024 10:51
@sergiocorato sergiocorato force-pushed the 14.0-mig-l10n_it_vat_settlement_date branch from 681b331 to 27a8947 Compare September 30, 2024 08:52
MaurizioPellegrinet
MaurizioPellegrinet approved these changes Sep 30, 2024
View reviewed changes
Copy link

@MaurizioPellegrinet MaurizioPellegrinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test: OK

@eLBati
Copy link
Member

eLBati commented Sep 30, 2024

La PR efatto#9 ora è in conflitto, ma potresti mica aggiungere direttamente queste modifiche efatto@5ba6f28#diff-8e4d85ecfb4475fcd85c4b1ec28d8639b35e1c25ff957e2fe2f16fc1a227919bL8-L13 a l10n_it_vat_settlement_date/reports/report_registro_iva.xml @sergiocorato ?

@eLBati
Copy link
Member

eLBati commented Sep 30, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-4338-by-eLBati-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 876083d into OCA:14.0 Sep 30, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a186182. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaurizioPellegrinet MaurizioPellegrinet MaurizioPellegrinet approved these changes

Assignees
No one assigned
Labels
merged 🎉 migration needs fixing Has conflicts or is failing mandatory CI checks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retrodatare detrazione iva fatture
9 participants
@sergiocorato @eLBati @SirAionTech @OCA-git-bot @MaurizioPellegrinet @francesco-ooops @TheMule71 @weblate @LorenzoC0