[MIG] l10n_it_account_stamp: Migrazione a 18.0 #4402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ocabot migration l10n_it_account_stamp |
[FIX] clean [FIX] clean [FIX] pep8 [IMP] use tax obj instead of tax code [FIX] icon path [FIX] get product with lang context [FIX] translation [FIX] product name [FIX] compute after unlink of invoice line
…OCA#818) This is needed as stamp line should be under VAT exemption
Currently translated at 100.0% (29 of 29 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_account_stamp Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_account_stamp/it/
[FIX] extra blank line [FIX] typos in source strings [IMP] readme, adapt to v.12.0 and add italian section [IMP] __manifest__.py, set ITA name and summary
Currently translated at 100.0% (29 of 29 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_account_stamp Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_account_stamp/it/
Currently translated at 100.0% (29 of 29 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_account_stamp Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_account_stamp/it/
[FIX] 2 euro image file
[IMP] image on invoice to display stamp application
and revert checkbox to previous position
[FIX] show button in draft edit mode only
Currently translated at 100.0% (30 of 30 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_account_stamp Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_account_stamp/it/
Currently translated at 100.0% (30 of 30 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_account_stamp Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_account_stamp/it/
Currently translated at 100.0% (30 of 30 strings) Translation: l10n-italy-12.0/l10n-italy-12.0-l10n_it_account_stamp Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-12-0/l10n-italy-12-0-l10n_it_account_stamp/it/
Test case: - Create a product setting VAT "fuori campo" (price 1) - Configure "Tax Stamp 2 euro" product to apply to "fuori campo" - Create an invoice, add a line selecting the previously created product and setting unit price = 100 tax_stamp field stays false
This reverts commit 112146d.
Steps: - Configure 2 companies - Company 1 - No tax stamp applied in the settings - Company 2 - Tax stamp applied in the settings - Activate "Synchronize invoices/bills" under "Inter-Company Transactions" in "General Settings" (enterprise feature) - From Company 1, create an invoice to Company 2 and try to "Confirm" the invoice Get "Missing tax stamp product in company settings" Expected behavior for Company 1 (invoice): - Since no taxstamp exists in settings for Company 1 and "Apply tax stamp" is FALSE on the invoice itself - there should be no error "Missing tax stamp". Expected behavior for Company 2 (bill): - Since taxstamp applied in the settings, it should be correctly processed.
If stamp line can be added (invoice in draft): show button to add stamp line. If stamp line can't be added (invoice not in draft): show message explaining why it can't be added. If stamp line has already been added: show message saying it has already been added (useful if invoice has many lines). Button and messages update live while updating the invoice. Better messages to user for charging stamp to customer Co-authored-by: Simone Rubino <simone.rubino@aion-tech.it>
Currently translated at 100.0% (35 of 35 strings) Translation: l10n-italy-16.0/l10n-italy-16.0-l10n_it_account_stamp Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-16-0/l10n-italy-16-0-l10n_it_account_stamp/it/
SirAionTech
force-pushed
the
18.0-mig-l10n_it_account_stamp
branch
from
6340163 to
dff90a8
Compare
primes2h
requested changes
Oct 24, 2024
SirAionTech
force-pushed
the
18.0-mig-l10n_it_account_stamp
branch
from
dff90a8 to
a6d100f
Compare
primes2h
approved these changes
Oct 24, 2024
|
This PR has the |
This comment was marked as resolved.
This comment was marked as resolved.
Align with Odoo standard terminology Co-authored-by: Sergio Zanchetta <primes2h@gmail.com>
SirAionTech
force-pushed
the
18.0-mig-l10n_it_account_stamp
branch
from
a6d100f to
4bd4fc5
Compare
SirAionTech
commented
Oct 30, 2024
There was a problem hiding this comment.
Per me è ok.
Manca solo un revisione degli script di migrazione, non posso autorevisionarmeli. 😉
Li ho guardati e secondo me vanno bene ma non posso autoapprovarmi la PR; ci accorgeremo di cosa abbiamo sbagliato quando si potranno usare.
Ho fatto le modifiche che avevamo detto in #4402 (comment), se vuoi darci un occhio così poi mergiamo 🚀
Perfetto, grazie! |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at ed47cc3. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sostituisce #4373.