Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0] porting l10n_it_financial_statement_eu #4559

Open
wants to merge 14 commits into
base: 18.0
Choose a base branch
from

Conversation

eLBati
Copy link
Member

@eLBati eLBati commented Jan 17, 2025

TennyMkt and others added 13 commits January 17, 2025 16:19
migration script

[FIX] l10n_it_financial_statement: tolta _get_xlsx_name e altre migliorie
Otherwise, when opening a line from the list view:
OwlError: An error occured in the owl lifecycle (see this Error's "cause" property)
    at handleError (http://oca-l10n-italy-16-0-pr3599-6f592ebc11da.runboat.odoo-community.org/web/assets/444-826ea0b/web.assets_common.min.js:1472:101)
    at owl.App.handleError (http://oca-l10n-italy-16-0-pr3599-6f592ebc11da.runboat.odoo-community.org/web/assets/444-826ea0b/web.assets_common.min.js:2100:29)
    at ComponentNode.initiateRender (http://oca-l10n-italy-16-0-pr3599-6f592ebc11da.runboat.odoo-community.org/web/assets/444-826ea0b/web.assets_common.min.js:1562:19)

Caused by: TypeError: Cannot read properties of undefined (reading 'type')
    at compareRecords (http://oca-l10n-italy-16-0-pr3599-6f592ebc11da.runboat.odoo-community.org/web/assets/445-43c5a33/web.assets_backend.min.js:8267:246)
    at stableCompare (http://oca-l10n-italy-16-0-pr3599-6f592ebc11da.runboat.odoo-community.org/web/assets/444-826ea0b/web.assets_common.min.js:6091:145)
    at Array.sort (<anonymous>)
    at Object.stableSort (http://oca-l10n-italy-16-0-pr3599-6f592ebc11da.runboat.odoo-community.org/web/assets/444-826ea0b/web.assets_common.min.js:6091:102)
    at Class._sortList (http://oca-l10n-italy-16-0-pr3599-6f592ebc11da.runboat.odoo-community.org/web/assets/445-43c5a33/web.assets_backend.min.js:8270:54)
    at http://oca-l10n-italy-16-0-pr3599-6f592ebc11da.runboat.odoo-community.org/web/assets/445-43c5a33/web.assets_backend.min.js:8237:113
    at async Promise.all (index 0)
    at async Promise.all (index 0)
    at async Class.load (http://oca-l10n-italy-16-0-pr3599-6f592ebc11da.runboat.odoo-community.org/web/assets/445-43c5a33/web.assets_backend.min.js:7927:244)
    at async Record.load (http://oca-l10n-italy-16-0-pr3599-6f592ebc11da.runboat.odoo-community.org/web/assets/445-43c5a33/web.assets_backend.min.js:2347:77)
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-italy-16.0/l10n-italy-16.0-l10n_it_financial_statement_eu
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-16-0/l10n-italy-16-0-l10n_it_financial_statement_eu/
Currently translated at 100.0% (98 of 98 strings)

Translation: l10n-italy-16.0/l10n-italy-16.0-l10n_it_financial_statement_eu
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-16-0/l10n-italy-16-0-l10n_it_financial_statement_eu/it/
Currently translated at 100.0% (98 of 98 strings)

Translation: l10n-italy-16.0/l10n-italy-16.0-l10n_it_financial_statement_eu
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-16-0/l10n-italy-16-0-l10n_it_financial_statement_eu/it/
Currently translated at 100.0% (98 of 98 strings)

Translation: l10n-italy-16.0/l10n-italy-16.0-l10n_it_financial_statement_eu
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-16-0/l10n-italy-16-0-l10n_it_financial_statement_eu/it/
Currently translated at 100.0% (98 of 98 strings)

Translation: l10n-italy-16.0/l10n-italy-16.0-l10n_it_financial_statement_eu
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-16-0/l10n-italy-16-0-l10n_it_financial_statement_eu/it/
Currently translated at 100.0% (98 of 98 strings)

Translation: l10n-italy-16.0/l10n-italy-16.0-l10n_it_financial_statement_eu
Translate-URL: https://translation.odoo-community.org/projects/l10n-italy-16-0/l10n-italy-16-0-l10n_it_financial_statement_eu/it/
@eLBati
Copy link
Member Author

eLBati commented Jan 17, 2025

creata PR dal lavoro di @dariodelzozzo

@eLBati
Copy link
Member Author

eLBati commented Jan 17, 2025

/ocabot migration l10n_it_financial_statement_eu

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jan 17, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 17, 2025
8 tasks
@eLBati
Copy link
Member Author

eLBati commented Jan 17, 2025

Al momento rilevo 2 problemi:

eu

UncaughtPromiseError > OwlError

Uncaught Promise > An error occured in the owl lifecycle (see this Error's "cause" property)

Occured on localhost:8069 on 2025-01-17 15:50:48 GMT

OwlError: An error occured in the owl lifecycle (see this Error's "cause" property)
    OwlError@http://localhost:8069/web/assets/debug/web.assets_web.js:8088:5 (/web/static/lib/owl/owl.js:87)
    handleError@http://localhost:8069/web/assets/debug/web.assets_web.js:9580:35 (/web/static/lib/owl/owl.js:1579)
    handleError@http://localhost:8069/web/assets/debug/web.assets_web.js:13985:20 (/web/static/lib/owl/owl.js:5984)
    _render@http://localhost:8069/web/assets/debug/web.assets_web.js:9733:30 (/web/static/lib/owl/owl.js:1732)
    render@http://localhost:8069/web/assets/debug/web.assets_web.js:9722:18 (/web/static/lib/owl/owl.js:1721)
    initiateRender@http://localhost:8069/web/assets/debug/web.assets_web.js:10402:23 (/web/static/lib/owl/owl.js:2401)

Caused by: TypeError: this._super is undefined
    setup@http://localhost:8069/web/assets/debug/web.assets_web.js:196729:9 (/l10n_it_financial_statement_eu/static/src/js/client_action.esm.js:9)
    ComponentNode@http://localhost:8069/web/assets/debug/web.assets_web.js:10380:28 (/web/static/lib/owl/owl.js:2379)
    createComponent/<@http://localhost:8069/web/assets/debug/web.assets_web.js:13976:28 (/web/static/lib/owl/owl.js:5975)
    template@http://localhost:8069/web/assets/debug/web.assets_web.js line 13700 > Function:11:27 (/web/static/lib/owl/owl.js:5699)
    _render@http://localhost:8069/web/assets/debug/web.assets_web.js:9730:38 (/web/static/lib/owl/owl.js:1729)
    render@http://localhost:8069/web/assets/debug/web.assets_web.js:9722:18 (/web/static/lib/owl/owl.js:1721)
    initiateRender@http://localhost:8069/web/assets/debug/web.assets_web.js:10402:23 (/web/static/lib/owl/owl.js:2401)

e

xbrl

RPC_ERROR

Odoo Server Error

Occured on localhost:8069 on 2025-01-17 15:52:09 GMT

Traceback (most recent call last):
  File "/opt/reporting-engine/report_xml/controllers/report.py", line 81, in report_download
    response = self.report_routes(
  File "/opt/odoo/odoo/http.py", line 727, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "/opt/reporting-engine/report_xml/controllers/report.py", line 44, in report_routes
    xml = report_Obj.with_context(**context)._render_qweb_xml(
  File "/opt/reporting-engine/report_xml/models/ir_actions_report.py", line 56, in _render_qweb_xml
    return report_model.generate_report(
  File "/opt/l10n-italy/l10n_it_financial_statement_eu/report/financial_statement_eu_report.py", line 277, in generate_report
    if self.env.company.rea_liquidation_state == "LS":
AttributeError: 'res.company' object has no attribute 'rea_liquidation_state'

The above server error caused the following client error:
RPC_ERROR: Odoo Server Error
    RPCError@http://localhost:8069/web/assets/debug/web.assets_web.js:29683:9 (/web/static/src/core/network/rpc.js:11)
    makeErrorFromResponse@http://localhost:8069/web/assets/debug/web.assets_web.js:29706:19 (/web/static/src/core/network/rpc.js:34)
    configureBlobDownloadXHR/xhr.onload/decoder.onload@http://localhost:8069/web/assets/debug/web.assets_web.js:29594:25 (/web/static/src/core/network/download.js:564)

@eLBati
Copy link
Member Author

eLBati commented Jan 17, 2025

@dariodelzozzo @TennyMkt vi dicono qualcosa questi errori ? #4559 (comment)

@TennyMkt
Copy link
Contributor

@dariodelzozzo @TennyMkt vi dicono qualcosa questi errori ? #4559 (comment)

In questo periodo purtroppo non sono in grado di lavorare su ambiente Odoo18 ma controllando i vari sorgenti, per l'errore:
Caused by: TypeError: this._super is undefined
Vedo che la parte

patch(ReportAction.prototype, "account_financial_report.ReportAction", {
    setup() {
        this._super.apply(this, arguments);
        this.isAccountFinancialReport = this.props.report_name.startsWith(
            `${MODULE_NAME}.`
        );

di della 16 (https://github.com/OCA/account-financial-reporting/blob/16.0/account_financial_report/static/src/js/report_action.esm.js ),
nella 18 (https://github.com/OCA/account-financial-reporting/blob/18.0/account_financial_report/static/src/js/report_action.esm.js ) è diventa:

patch(ReportAction.prototype, {
    setup() {
        super.setup(...arguments);
        this.isAccountFinancialReport = this.props.report_name.startsWith(
            `${MODULE_NAME}.`
        );

Quindi ipotizzo ci sia da cambiare in https://github.com/OCA/l10n-italy/pull/4559/files#diff-a191b75693668081b2b239b2b36fec7890825eb8f55ce50de304b42a7716b8a1
da
this._super.apply(this, arguments);
a
super.setup(...arguments);

@TennyMkt
Copy link
Contributor

Mentre rea_liquidation_state era un campo del modulo l10n_it_rea che non è stato migrato alla 18, c'è da capire come si chiama questo campo nella 18 e modificarlo l10n_it_financial_statement_eu/report/financial_statement_eu_report.py

@dariodelzozzo
Copy link

@dariodelzozzo @TennyMkt vi dicono qualcosa questi errori ? #4559 (comment)

In questo periodo purtroppo non sono in grado di lavorare su ambiente Odoo18 ma controllando i vari sorgenti, per l'errore: Caused by: TypeError: this._super is undefined Vedo che la parte

patch(ReportAction.prototype, "account_financial_report.ReportAction", {
    setup() {
        this._super.apply(this, arguments);
        this.isAccountFinancialReport = this.props.report_name.startsWith(
            `${MODULE_NAME}.`
        );

di della 16 (https://github.com/OCA/account-financial-reporting/blob/16.0/account_financial_report/static/src/js/report_action.esm.js ), nella 18 (https://github.com/OCA/account-financial-reporting/blob/18.0/account_financial_report/static/src/js/report_action.esm.js ) è diventa:

patch(ReportAction.prototype, {
    setup() {
        super.setup(...arguments);
        this.isAccountFinancialReport = this.props.report_name.startsWith(
            `${MODULE_NAME}.`
        );

Quindi ipotizzo ci sia da cambiare in https://github.com/OCA/l10n-italy/pull/4559/files#diff-a191b75693668081b2b239b2b36fec7890825eb8f55ce50de304b42a7716b8a1 da this._super.apply(this, arguments); a super.setup(...arguments);

Cosi ad occhio direi che sono d'accordo con @TennyMkt.
Al momento purtroppo non riesco a guardarci nemmeno io. Durante la migrazione non conoscendo il modulo mi sono limitato a migrare gli errori nei test automatici e durante l'intallazione.

Borruso added a commit to DinamicheAziendali/l10n-italy that referenced this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants