debugged error in case of wht with 0% rate #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eLBati
reviewed
May 4, 2018
| @@ -97,7 +97,7 @@ def generate_wt_moves(self): | |||
| payment_lines = wt_st.withholding_tax_id.payment_term.compute( | |||
| amount_wt, | |||
| rec_line_statement.date or False) | |||
| if payment_lines: | |||
| if payment_lines[0]: | |||
There was a problem hiding this comment.
@jackjack82 payment_lines non può essere vuoto?
Non è più sicuro un controllo del tipo
if payment_lines and payment_lines[0]
?
|
se vuoto ritorna [ [ ] ] , per quello serve mettere lo [0]
…On 4 May 2018 at 15:08, Lorenzo Battistini ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In l10n_it_withholding_tax/models/account.py
<#468 (comment)>:
> @@ -97,7 +97,7 @@ def generate_wt_moves(self):
payment_lines = wt_st.withholding_tax_id.payment_term.compute(
amount_wt,
rec_line_statement.date or False)
- if payment_lines:
+ if payment_lines[0]:
@jackjack82 <https://github.com/jackjack82> payment_lines non può essere
vuoto?
Non è più sicuro un controllo del tipo
if payment_lines and if payment_lines[0]
?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#468 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMv6EH4FZXYzxHnN0qCYhkz01CBNeB3zks5tvFLfgaJpZM4S-5tM>
.
|
eLBati
requested changes
May 4, 2018
There was a problem hiding this comment.
@jackjack82 guardando il metodo compute di account.payment.term, result è una lista di tuple, del tipo (data, importo) quindi la modifica non mi torna
jackjack82
force-pushed
the
wht_debug_0_rate
branch
from
cf4081d
to
3895e18
Compare
|
@eLBati fatto aggiornamento richiesto. thx |
eLBati
approved these changes
May 8, 2018
tafaRU
approved these changes
May 8, 2018
alessandrocamilli
pushed a commit
to alessandrocamilli/l10n-italy
that referenced
this pull request
Jun 26, 2018
alessandrocamilli
pushed a commit
to alessandrocamilli/l10n-italy
that referenced
this pull request
Aug 29, 2018
alessandrocamilli
pushed a commit
to alessandrocamilli/l10n-italy
that referenced
this pull request
Sep 24, 2018
eLBati
pushed a commit
to eLBati/l10n-italy
that referenced
this pull request
Oct 3, 2018
eLBati
pushed a commit
to eLBati/l10n-italy
that referenced
this pull request
Oct 3, 2018
eLBati
pushed a commit
to eLBati/l10n-italy
that referenced
this pull request
Oct 3, 2018
eLBati
pushed a commit
to eLBati/l10n-italy
that referenced
this pull request
Oct 3, 2018
eLBati
pushed a commit
to eLBati/l10n-italy
that referenced
this pull request
Nov 8, 2018
eLBati
pushed a commit
to eLBati/l10n-italy
that referenced
this pull request
Nov 8, 2018
eLBati
pushed a commit
to eLBati/l10n-italy
that referenced
this pull request
Nov 9, 2018
eLBati
pushed a commit
to eLBati/l10n-italy
that referenced
this pull request
Nov 21, 2018
SimoRubi
pushed a commit
to SimoRubi/l10n-italy
that referenced
this pull request
Aug 7, 2019
SimoRubi
pushed a commit
to SimoRubi/l10n-italy
that referenced
this pull request
Aug 7, 2019
TheMule71
pushed a commit
to TheMule71/l10n-italy
that referenced
this pull request
Dec 17, 2020
TheMule71
pushed a commit
to TheMule71/l10n-italy
that referenced
this pull request
May 5, 2021
TheMule71
pushed a commit
to TheMule71/l10n-italy
that referenced
this pull request
Nov 2, 2022
TheMule71
pushed a commit
to TheMule71/l10n-italy
that referenced
this pull request
Dec 16, 2022
TonyMasciI
pushed a commit
to saydigital/l10n-italy
that referenced
this pull request
Jan 9, 2023
TonyMasciI
pushed a commit
to saydigital/l10n-italy
that referenced
this pull request
Jan 16, 2023
TonyMasciI
pushed a commit
to saydigital/l10n-italy
that referenced
this pull request
Jan 27, 2023
are-agilebg
pushed a commit
to are-agilebg/l10n-italy
that referenced
this pull request
May 10, 2023
are-agilebg
pushed a commit
to are-agilebg/l10n-italy
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of withholding tax with rate of 0% the module returns an error. This PR is ment to solve it.