[11.0] A better wizard for fiscal code generation.

[Byloth]

This PR implements some little features within the wizard used for the generation of partner's fiscal code.

• The Odoo's native model res.country.state (which actually contains Italian provinces) is used for field "Birth province" (and all related logics).
• Now you won't see the same province multiple times.
• All fields required for generating the fiscal code are now really required.
• Use of the Odoo's native <group> for splitting fields in two different columns and give to the user a better experience.
• Now you can't create new (or edit) cities and provinces.
• "Male" / "Female" selection field now uses the radio widget.

---

Before (actually "Now", to be precise...)

---

Say «Hello!» to 2018!

[oca-clabot]

Hey @Byloth, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

• @Byloth (login unknown in OCA database)

Appreciation of efforts,
OCA CLAbot

[Byloth]

Ok...
Ho ricevuto la conferma da parte di OCA; ora, anche io, sono presente tra gli utenti che hanno firmato la CLA.

[eLBati]

Nel wizard del calcolo, lasciando vuoto il campo città e andando a modificare manualmente il campo provincia, ottengo

Traceback (most recent call last):
  File "/home/elbati/workspace/odoo/instances/odoo11/parts/odoo/odoo/http.py", line 650, in _handle_exception
    return super(JsonRequest, self)._handle_exception(exception)
  File "/home/elbati/workspace/odoo/instances/odoo11/parts/odoo/odoo/http.py", line 310, in _handle_exception
    raise pycompat.reraise(type(exception), exception, sys.exc_info()[2])
  File "/home/elbati/workspace/odoo/instances/odoo11/parts/odoo/odoo/tools/pycompat.py", line 87, in reraise
    raise value
  File "/home/elbati/workspace/odoo/instances/odoo11/parts/odoo/odoo/http.py", line 692, in dispatch
    result = self._call_function(**self.params)
  File "/home/elbati/workspace/odoo/instances/odoo11/parts/odoo/odoo/http.py", line 342, in _call_function
    return checked_call(self.db, *args, **kwargs)
  File "/home/elbati/workspace/odoo/instances/odoo11/parts/odoo/odoo/service/model.py", line 97, in wrapper
    return f(dbname, *args, **kwargs)
  File "/home/elbati/workspace/odoo/instances/odoo11/parts/odoo/odoo/http.py", line 335, in checked_call
    result = self.endpoint(*a, **kw)
  File "/home/elbati/workspace/odoo/instances/odoo11/parts/odoo/odoo/http.py", line 936, in __call__
    return self.method(*args, **kw)
  File "/home/elbati/workspace/odoo/instances/odoo11/parts/odoo/odoo/http.py", line 515, in response_wrap
    response = f(*args, **kw)
  File "/home/elbati/workspace/odoo/instances/odoo11/parts/odoo/addons/web/controllers/main.py", line 934, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "/home/elbati/workspace/odoo/instances/odoo11/parts/odoo/addons/web/controllers/main.py", line 926, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "/home/elbati/workspace/odoo/instances/odoo11/parts/odoo/odoo/api.py", line 689, in call_kw
    return call_kw_multi(method, model, args, kwargs)
  File "/home/elbati/workspace/odoo/instances/odoo11/parts/odoo/odoo/api.py", line 680, in call_kw_multi
    result = method(recs, *args, **kwargs)
  File "/home/elbati/workspace/odoo/instances/odoo11/parts/odoo/odoo/models.py", line 5099, in onchange
    record._onchange_eval(name, field_onchange[name], result)
  File "/home/elbati/workspace/odoo/instances/odoo11/parts/odoo/odoo/models.py", line 4994, in _onchange_eval
    method_res = method(self)
  File "/home/elbati/workspace/odoo/instances/odoo11/parts/l10n-italy/l10n_it_fiscalcode/wizard/compute_fc.py", line 88, in onchange_birth_province
    names = city_ids.mapped('names')
  File "/home/elbati/workspace/odoo/instances/odoo11/parts/odoo/odoo/models.py", line 4512, in mapped
    recs = recs._mapped_func(operator.itemgetter(name))
  File "/home/elbati/workspace/odoo/instances/odoo11/parts/odoo/odoo/models.py", line 4491, in _mapped_func
    vals = [func(rec) for rec in self]
  File "/home/elbati/workspace/odoo/instances/odoo11/parts/odoo/odoo/models.py", line 4491, in <listcomp>
    vals = [func(rec) for rec in self]
  File "/home/elbati/workspace/odoo/instances/odoo11/parts/odoo/odoo/models.py", line 4758, in __getitem__
    return self._fields[key].__get__(self, type(self))
KeyError: 'names'

Personalmente rimuoverei l'onchange onchange_birth_province , essendo sull'ultimo campo del form , la sua modifica non dovrebbe influire su campi precedenti

[eLBati]

@Byloth prevedi di portare avanti questa?

[eLBati]

@Byloth vedi https://github.com/linkitspa/l10n-italy/pull/2

[eLBati]

Ok, grazie

[eLBati]

@Byloth potresti fare squash/fixup dei 3 commit?

[Byloth]

Here you are! 😊

[SimoRubi]

Grazie! Solo qualche consiglio ma per me è ok