Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD l10n_it_vat_registries_split_payment #570

Merged
merged 1 commit into from
Sep 24, 2018
Merged

ADD l10n_it_vat_registries_split_payment #570

merged 1 commit into from
Sep 24, 2018

Conversation

eLBati
Copy link
Member

@eLBati eLBati commented Aug 16, 2018

to fix the following case

  • Configure Split Payment fiscal position and tax
  • Make a customer invoice with SP
  • Print VAT register

Split Payment VAT must not appear as deductible VAT

@eLBati eLBati mentioned this pull request Aug 16, 2018
Closed
stevech091
stevech091 approved these changes Aug 22, 2018
View reviewed changes
Copy link

@stevech091 stevech091 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Print a vat report with split payment.

@eLBati eLBati added this to the 11.0 milestone Aug 28, 2018
@tafaRU
Copy link
Member

tafaRU commented Aug 28, 2018

Potresti aggiungere un test per il caso che hai descritto?

@eLBati
Copy link
Member Author

eLBati commented Aug 31, 2018

@tafaRU fatto

hurrinico
hurrinico approved these changes Aug 31, 2018
View reviewed changes
Copy link

@hurrinico hurrinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

SimoRubi
SimoRubi approved these changes Aug 31, 2018
View reviewed changes
Copy link
Member

@SimoRubi SimoRubi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non blocking comments, just please bump the version of l10n_it_split_payment since you added a new field

l10n_it_split_payment/models/account_tax.py Outdated
for tax in self:
fp_lines = self.env['account.fiscal.position.tax'].search(
[('tax_dest_id', '=', tax.id)])
for fp_line in fp_lines:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be another way to implement that
tax.is_split_payment = any(fp_line.position_id.split_payment for fp_line in fp_lines)

l10n_it_split_payment/__manifest__.py
@@ -11,7 +11,7 @@
'summary': 'Split Payment',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump module version

l10n_it_vat_registries_split_payment/models/account_tax.py
@@ -0,0 +1,16 @@
# -*- coding: utf-8 -*-
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you can place your own copyright

@eLBati
ADD l10n_it_vat_registries_split_payment to fix the following case:
3c687c9 
 - Configure Split Payment fiscal position and tax
 - Make a customer invoice with SP
 - Print VAT register

Split Payment VAT must not appear as deductible VAT
@eLBati
Copy link
Member Author

eLBati commented Sep 3, 2018

@SimoRubi thanks, changed

@eLBati
Copy link
Member Author

eLBati commented Sep 5, 2018

🍏

@eLBati eLBati merged commit 9809e22 into OCA:10.0 Sep 24, 2018
@primes2h primes2h mentioned this pull request Nov 9, 2018
Merged
SimoRubi pushed a commit to SimoRubi/l10n-italy that referenced this pull request Aug 7, 2019
@eLBati @SimoRubi
ADD l10n_it_vat_registries_split_payment to fix the following case: (O…
66adb31 
…CA#570)

- Configure Split Payment fiscal position and tax
 - Make a customer invoice with SP
 - Print VAT register

Split Payment VAT must not appear as deductible VAT
SimoRubi pushed a commit to SimoRubi/l10n-italy that referenced this pull request Aug 7, 2019
@eLBati @SimoRubi
ADD l10n_it_vat_registries_split_payment to fix the following case: (O…
00facb0 
…CA#570)

- Configure Split Payment fiscal position and tax
 - Make a customer invoice with SP
 - Print VAT register

Split Payment VAT must not appear as deductible VAT
SimoRubi pushed a commit to SimoRubi/l10n-italy that referenced this pull request Apr 8, 2021
@eLBati @SimoRubi
ADD l10n_it_vat_registries_split_payment to fix the following case: (O…
20dca2b 
…CA#570)

- Configure Split Payment fiscal position and tax
 - Make a customer invoice with SP
 - Print VAT register

Split Payment VAT must not appear as deductible VAT
SimoRubi pushed a commit to SimoRubi/l10n-italy that referenced this pull request May 3, 2021
@eLBati @SimoRubi
ADD l10n_it_vat_registries_split_payment to fix the following case: (O…
40a3581 
…CA#570)

- Configure Split Payment fiscal position and tax
 - Make a customer invoice with SP
 - Print VAT register

Split Payment VAT must not appear as deductible VAT
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Jun 19, 2023
@eLBati @Borruso
ADD l10n_it_vat_registries_split_payment to fix the following case: (O…
e973963 
…CA#570)

- Configure Split Payment fiscal position and tax
 - Make a customer invoice with SP
 - Print VAT register

Split Payment VAT must not appear as deductible VAT
TheMule71 pushed a commit to TheMule71/l10n-italy that referenced this pull request Jun 23, 2023
@eLBati @TheMule71
ADD l10n_it_vat_registries_split_payment to fix the following case: (O…
ea7dd81 
…CA#570)

- Configure Split Payment fiscal position and tax
 - Make a customer invoice with SP
 - Print VAT register

Split Payment VAT must not appear as deductible VAT
Borruso pushed a commit to DinamicheAziendali/l10n-italy that referenced this pull request Jul 13, 2023
@eLBati @Borruso
ADD l10n_it_vat_registries_split_payment to fix the following case: (O…
1088cde 
…CA#570)

- Configure Split Payment fiscal position and tax
 - Make a customer invoice with SP
 - Print VAT register

Split Payment VAT must not appear as deductible VAT
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Oct 3, 2023
@eLBati @Borruso
ADD l10n_it_vat_registries_split_payment to fix the following case: (O…
f40e8b2 
…CA#570)

- Configure Split Payment fiscal position and tax
 - Make a customer invoice with SP
 - Print VAT register

Split Payment VAT must not appear as deductible VAT
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Oct 5, 2023
@eLBati @Borruso
ADD l10n_it_vat_registries_split_payment to fix the following case: (O…
02368a5 
…CA#570)

- Configure Split Payment fiscal position and tax
 - Make a customer invoice with SP
 - Print VAT register

Split Payment VAT must not appear as deductible VAT
@salvorapi salvorapi mentioned this pull request Jan 24, 2024
Merged
TennyMkt pushed a commit to mktsrl/l10n-italy that referenced this pull request May 10, 2024
@eLBati @TennyMkt
ADD l10n_it_vat_registries_split_payment to fix the following case: (O…
09fbbcc 
…CA#570)

- Configure Split Payment fiscal position and tax
 - Make a customer invoice with SP
 - Print VAT register

Split Payment VAT must not appear as deductible VAT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimoRubi SimoRubi SimoRubi approved these changes

@stevech091 stevech091 stevech091 approved these changes

@hurrinico hurrinico hurrinico approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.
5 participants
@eLBati @tafaRU @hurrinico @stevech091 @SimoRubi