[10.0] fix depends l10n_it_account on account_fiscal_year for date ra… #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eLBati
approved these changes
Aug 24, 2018
|
@SimoRubi done! |
SimoRubi
approved these changes
Aug 28, 2018
l10n_it_account/__manifest__.py
Outdated
| 'website': 'http://www.odoo-italia.net', | ||
| 'license': 'AGPL-3', | ||
| "depends": [ | ||
| 'account', | ||
| 'account_fiscal_year', |
There was a problem hiding this comment.
Credo che questa dipendenza sia sufficiente da sola visto che account_fiscal_year già dipende da account e date_range
tafaRU
requested changes
Aug 28, 2018
There was a problem hiding this comment.
@sergiocorato, innanzitutto grazie per la tua PR!
Mancherebbero solo un paio di nitpicking prima di poterla mergiare:
- modificare la versione a 10.0.1.2.2 invece che a 10.0.1.1.3 (vedi https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#version-numbers)
- squashare tutti i commits in uno solo
…e with the mapping
… ProgressivoInvio) (#571)
|
niente, mi si è sporcato il branch, lo rifaccio |
|
v. #581 |
sergiocorato
deleted the
10.0_fix_l10n_it_account_depend_account_fiscal_year_for_date_range
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nge menu