Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0] Print fiscal code in invoice #623

Merged
merged 1 commit into from
Oct 29, 2018
Merged

[11.0] Print fiscal code in invoice #623

merged 1 commit into from
Oct 29, 2018

Conversation

GSLabIt
Copy link
Contributor

@GSLabIt GSLabIt commented Oct 27, 2018

No description provided.

@eLBati
Copy link
Member

eLBati commented Oct 27, 2018

Hi @joezsweet thanks for your contribution.

You should rather port to 11 l10n_it_fiscalcode_invoice module.

Here is the guide https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-11.0 if needed

@eLBati eLBati closed this Oct 27, 2018
@GSLabIt
Copy link
Contributor Author

GSLabIt commented Oct 27, 2018

What's the goal to have a module just to print fiscalcode in invoice?

@eLBati
Copy link
Member

eLBati commented Oct 28, 2018

In this case , I don't see reasons to have a separate module indeed.
Reopening it

@eLBati eLBati reopened this Oct 28, 2018
@pedrobaeza pedrobaeza mentioned this pull request Oct 28, 2018
35 tasks
<?xml version="1.0" encoding="utf-8" ?>
<odoo>
<template id="print_invoice_inherit" inherit_id="account.report_invoice_document">
<xpath expr="//div[@name='invoice_address']" position="after">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joezsweet why not inside invoice_address div, along with other customer data? You would probably save space

@eLBati eLBati changed the title Print fiscal code in invoice [11.0] Print fiscal code in invoice Oct 28, 2018
@eLBati
Copy link
Member

eLBati commented Oct 28, 2018

@joezsweet thanks.

Could you squash the 3 commits in 1?

Assuming origin is https://github.com/OCA/l10n-italy.git and is up to date (git fetch origin), run git rebase -i origin/11.0. Then squash the last 2 commits in the first one. Then git push -f

@eLBati
Copy link
Member

eLBati commented Oct 28, 2018

@joezsweet it seems you created commits directly from github.com
If you prefer, I can squash the commits for you

@GSLabIt
Copy link
Contributor Author

GSLabIt commented Oct 28, 2018

Yeah, i've done directly in github because of few and fast changes; feel free to squash commits. Probably is better to use Fiscal code: as label for translation compatibility. Could u change it?

@eLBati
Copy link
Member

eLBati commented Oct 28, 2018

Done

@tafaRU
Copy link
Member

tafaRU commented Oct 29, 2018

@eLBati
Copy link
Member

eLBati commented Oct 29, 2018

@tafaRU #623 (comment)

@GSLabIt
Copy link
Contributor Author

GSLabIt commented Oct 29, 2018

@tafaRU what should be the goal to have it in another module? just to print the fiscal code in invoice?

#623 (comment)

@eLBati
Copy link
Member

eLBati commented Oct 29, 2018

Also, as l10n_it_fiscalcode_invoice has 'auto_install': True and depends on "l10n_it_fiscalcode", "account", and l10n_it_fiscalcode depends, implicitly, on account, l10n_it_fiscalcode_invoice would be always installed along with l10n_it_fiscalcode. So, there is no reason to have a separate module

@tafaRU
Copy link
Member

tafaRU commented Oct 29, 2018

ok, for consistency, I'd also apply the same changes to branch 10.0 then.

Copy link
Member

@SimoRubi SimoRubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
Ok for me

@eLBati
Copy link
Member

eLBati commented Oct 29, 2018

@tafaRU I would not remove a module from a stable branch

@eLBati eLBati merged commit 3c5208d into OCA:11.0 Oct 29, 2018
@GSLabIt GSLabIt deleted the joezsweet-patch-1 branch October 29, 2018 11:36
eLBati pushed a commit to eLBati/l10n-italy that referenced this pull request Oct 30, 2018
SimoRubi pushed a commit to SimoRubi/l10n-italy that referenced this pull request Aug 7, 2019
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Oct 30, 2020
victoralmau pushed a commit to Tecnativa/l10n-italy that referenced this pull request Jan 5, 2021
Borruso pushed a commit to Borruso/l10n-italy that referenced this pull request Apr 9, 2021
TheMule71 pushed a commit to TheMule71/l10n-italy that referenced this pull request Nov 2, 2022
TheMule71 pushed a commit to TheMule71/l10n-italy that referenced this pull request Nov 2, 2022
TheMule71 pushed a commit to TheMule71/l10n-italy that referenced this pull request Nov 2, 2022
michelerusti pushed a commit to michelerusti/l10n-italy that referenced this pull request Nov 10, 2022
michelerusti pushed a commit to michelerusti/l10n-italy that referenced this pull request Nov 10, 2022
michelerusti pushed a commit to michelerusti/l10n-italy that referenced this pull request Nov 10, 2022
michelerusti pushed a commit to michelerusti/l10n-italy that referenced this pull request Nov 10, 2022
TheMule71 pushed a commit to TheMule71/l10n-italy that referenced this pull request Nov 10, 2022
TheMule71 pushed a commit to TheMule71/l10n-italy that referenced this pull request Nov 11, 2022
TheMule71 pushed a commit to TheMule71/l10n-italy that referenced this pull request Nov 25, 2022
TonyMasciI pushed a commit to saydigital/l10n-italy that referenced this pull request Jan 9, 2023
TonyMasciI pushed a commit to saydigital/l10n-italy that referenced this pull request Jan 16, 2023
TonyMasciI pushed a commit to saydigital/l10n-italy that referenced this pull request Jan 27, 2023
are-agilebg pushed a commit to are-agilebg/l10n-italy that referenced this pull request May 10, 2023
are-agilebg pushed a commit to are-agilebg/l10n-italy that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants