-
-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0] Print fiscal code in invoice #623
Conversation
Hi @joezsweet thanks for your contribution. You should rather port to 11 l10n_it_fiscalcode_invoice module. Here is the guide https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-11.0 if needed |
What's the goal to have a module just to print fiscalcode in invoice? |
In this case , I don't see reasons to have a separate module indeed. |
<?xml version="1.0" encoding="utf-8" ?> | ||
<odoo> | ||
<template id="print_invoice_inherit" inherit_id="account.report_invoice_document"> | ||
<xpath expr="//div[@name='invoice_address']" position="after"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joezsweet why not inside invoice_address
div, along with other customer data? You would probably save space
@joezsweet thanks. Could you squash the 3 commits in 1? Assuming |
@joezsweet it seems you created commits directly from github.com |
Yeah, i've done directly in github because of few and fast changes; feel free to squash commits. Probably is better to use |
Update __manifest__.py
Done |
Shouldn't be better to migrate https://github.com/OCA/l10n-italy/tree/10.0/l10n_it_fiscalcode_invoice ? |
@tafaRU what should be the goal to have it in another module? just to print the fiscal code in invoice? |
Also, as |
ok, for consistency, I'd also apply the same changes to branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Ok for me
@tafaRU I would not remove a module from a stable branch |
Update __manifest__.py
Update __manifest__.py
Update __manifest__.py
Update __manifest__.py
Update __manifest__.py
Update __manifest__.py
Update __manifest__.py
Update __manifest__.py
Update __manifest__.py
Update __manifest__.py
Update __manifest__.py
Update __manifest__.py
Update __manifest__.py
Update __manifest__.py
Update __manifest__.py
Update __manifest__.py
Update __manifest__.py
Update __manifest__.py
Update __manifest__.py
Update __manifest__.py
No description provided.