[18.0][IMP] Remove deprecated is_l10n_ro_record field and cleanup logic
#1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminated occurrences of the `is_l10n_ro_record` field across views, models, and XML files as it was no longer in use. Adjusted related logic to rely on alternative methods and cleaned deprecated code comments. This simplifies the codebase and improves maintainability.
|
Hi @feketemihai, @mcojocaru, |
Removed unused `chart_template_ref` parameter in `setUpClass` to clean up the code and align with its intended usage. This change ensures clarity and avoids unnecessary argument passing.
Previously, inconsistent variable naming (`price_unit` vs `price`) caused incorrect behavior in price calculation and updates. This change ensures consistent usage of the `price` variable to avoid potential errors.
Ensure proper handling of products with lot valuation by updating the price unit logic. Introduced conditions to return lot-specific prices and aligned calculation with stock valuation accuracy.
Adjusted the `unit_cost` assignment to ensure it uses the correct value based on the lot ID. This change ensures accurate stock valuation in cases where the average cost method is applied.
Ensure `lot_id` is properly resolved when calculating `unit_cost`. This prevents potential errors caused by incorrect indexing and improves stock valuation accuracy.
Corrected the model name from "stoc.lot" to "stock.lot" in stock move logic. This ensures proper retrieval of stock lot data and avoids potential errors during lot processing.
Corrects the key reference when retrieving lot ID during stock valuation. This ensures accurate mapping of unit costs to specific lots, preventing potential computation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminated occurrences of the
is_l10n_ro_recordfield across views, models, and XML files as it was no longer in use. Adjusted related logic to rely on alternative methods and cleaned deprecated code comments. This simplifies the codebase and improves maintainability.