Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0][WIP][l10n_es_tgss_base][l10n_es_tgss_partner] Campos de la TGSS para res.partner, y preparado para reimplementar en otros #222

Closed
wants to merge 17 commits into from

Conversation

yajo
Copy link
Member

@yajo yajo commented Oct 1, 2015

The base module provides abstract models with fields needed to interact with
Spanish TGSS.

The partner module implements those abstract models in res.partner.

If anybody wants, for example, to implement those in hr.employee, with
sed s/res.partner/hr.employee in a copy of l10n_es_tgss_partner and a
little more adjustments should be enough.

Related to #174.

@yajo
Copy link
Member Author

yajo commented Oct 1, 2015

Oops this is incomplete, please don't review yet.

@yajo
Copy link
Member Author

yajo commented Oct 1, 2015

Now it's complete.

Runbot fails with a bug in module l10n_es_aeat_mod303, not related.

@pedrobaeza
Copy link
Member

👍, but please rename it to l10n_es_tgss to simplify things.

Waiting for l10n_es_tgss_partner and l10n_es_tgss_hr!

@yajo
Copy link
Member Author

yajo commented Oct 5, 2015

l10n_es_tgss_partner is included in this PR (there are 2 modules).

IMHO l10n_es_tgss_base seems a good name for a base module that does nothing else.

l10n_es_tgss_hr is not coming for now, but with this basis, copying & modifying l10n_es_tgss_partner should not be very hard for anyone needing it. 😉

@pedrobaeza
Copy link
Member

Oh, I didn't see that module! Checked also. The name is like l10n_es_aeat. We don't put it l10n_es_aeat_base. It's redundant.

@yajo
Copy link
Member Author

yajo commented Oct 5, 2015

Done 😊

@pedrobaeza
Copy link
Member

👍

@yajo
Copy link
Member Author

yajo commented Nov 6, 2015

Finally, I'm developing the multi-account for companies, please wait.

@rafaelbn
Copy link
Member

rafaelbn commented Dec 1, 2015

Como hemos dicho, aquí mejor no usemos en inglés porque podría limitar las posibilidades de participación. Como mandó Pedro el otro día correo a odoospain... así hay más gente que se entera y particia (supuestamente). GRacias

@yajo yajo changed the title Add modules l10n_es_tgss_base and l10n_es_tgss_partner. [8.0][WIP][l10n_es_tgss_base][l10n_es_tgss_partner] Campos de la TGSS para res.partner, y preparado para reimplementar en otros Jan 14, 2016
Jairo Llopis added 14 commits January 25, 2016 13:45
The base module provides abstract models with fields needed to interact with
Spanish TGSS.

The partner module implements those abstract models in `res.partner`.

If anybody wants, for example, to implement those in `hr.employee`, with
`sed s/res.partner/hr.employee` in a copy of `l10n_es_tgss_partner` and a
little more adjustments should be enough.
Those include affected by gender violence, by terrorism, and disability
percentage.

Add tests too, and fix docs.
Now models with contribution_account have a separate affiliation_number
field because a person hired by a company will have is personal
affiliation number but is affiliated under the hirer's contribution
account.
Allow too to select in which parent code is hired the contact.
@yajo
Copy link
Member Author

yajo commented Jan 26, 2016

  • Rebasado.
  • Las empresas pueden tener varios CCC.
  • Los contactos pueden tener un NAF.
  • Los contactos pueden estar dados de alta en un CCC.
  • La herencia de las clases abstractas se ha simplificado.

@yajo
Copy link
Member Author

yajo commented Jan 27, 2016

Error del runbot: #285.

Jairo Llopis added 2 commits January 27, 2016 12:10
The UI should **not** inform it because that could tempt the user to
replace the code just to save the record, when the main purpose of the
control digit is to avoid bad input. The failure could be in any other
part of the code and then what could seem as a "fix" to the user would
probably be a worse problem than the unability to save the record.

However, for debugging purposes, it is useful to know which code was
expected, so the logs now render it just before the exception.
@yajo
Copy link
Member Author

yajo commented Jan 28, 2016

¿Una ayudita con Travis?

Now they don't have a number to make them more reusable. Previous
numbers were being borrowed from [this 2012's
XSD](http://empresas.fundaciontripartita.org/schemas/2012/FinalizacionGrupo_Bonificada.xsd),
but [in 2016 those have
changed](http://empresas.fundaciontripartita.org/app/xml_formato2016.aspx).
Study levels are also used in other contexts than training, and each
context has its own codes, that will be implemented in submodules.

But for training we will need the numbers again, so I'm preparing this
to be reused for that upcoming module.

Also default study levels are now more specific, so they become more
compatible for any purpose.
@yajo
Copy link
Member Author

yajo commented Jan 29, 2016

Si intentáis generar una traducción para el módulo base, os toparéis con odoo/odoo#10685.

@pedrobaeza
Copy link
Member

Puesto que esto no se llegó a terminar, cierro y luego siempre se puede volver a retomar.

@pedrobaeza pedrobaeza closed this Mar 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants