Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0][IMP] l10n_es_aeat_mod303: New declaration format for 2024-10 #3785

Open
wants to merge 10 commits into
base: 11.0
Choose a base branch
from
Open

[11.0][IMP] l10n_es_aeat_mod303: New declaration format for 2024-10 #3785

wants to merge 10 commits into from

Conversation

ljsalvatierra-factorlibre
Copy link
Contributor

@ljsalvatierra-factorlibre ljsalvatierra-factorlibre commented Oct 18, 2024 •
edited
Loading

Backport de #3757 y #3770

@OCA-git-bot
Copy link
Contributor

Hi @cubells,
some modules you are maintaining are being modified, check this out!

@ljsalvatierra-factorlibre
Copy link
Contributor Author

ljsalvatierra-factorlibre commented Oct 18, 2024 •
edited
Loading

@etobella alguna idea de cómo solucionarlo?

ERROR: Could not build wheels for xmlsec which use PEP 517 and cannot be installed directly

@Shide @EmilioPascual @ljsalvatierra-factorlibre
[FIX] l10n_es_aeat_mod303: Permitir rellenar las casillas 108 y 111
61afbc5 
Co-authored-by: Emilio Pascual <53056345+EmilioPascual@users.noreply.github.com>
@cubells
Copy link
Member

cubells commented Oct 21, 2024

@etobella alguna idea de cómo solucionarlo?

ERROR: Could not build wheels for xmlsec which use PEP 517 and cannot be installed directly

Es la versión de xmlsec @ljsalvatierra-factorlibre

Prueba a poner diferentes versiones, Prueba primero con la 1.3.9 y si no la 14.

ok?

@ljsalvatierra-factorlibre
Copy link
Contributor Author

@etobella alguna idea de cómo solucionarlo?
ERROR: Could not build wheels for xmlsec which use PEP 517 and cannot be installed directly

Es la versión de xmlsec @ljsalvatierra-factorlibre

Prueba a poner diferentes versiones, Prueba primero con la 1.3.9 y si no la 14.

ok?

Pruebo, muchas gracias @cubells

@ljsalvatierra-factorlibre
Copy link
Contributor Author

@etobella alguna idea de cómo solucionarlo?
ERROR: Could not build wheels for xmlsec which use PEP 517 and cannot be installed directly

Es la versión de xmlsec @ljsalvatierra-factorlibre

Prueba a poner diferentes versiones, Prueba primero con la 1.3.9 y si no la 14.

ok?

I think there is no available version of xmlsec for Python 3.5.

@cubells
Copy link
Member

cubells commented Oct 21, 2024

@ljsalvatierra-factorlibre prueba la 1.3.13 y la 1.3.9

@ljsalvatierra-factorlibre
Copy link
Contributor Author

@ljsalvatierra-factorlibre prueba la 1.3.13 y la 1.3.9

Con la 1.3.9 no me había funcionado pero con la 1.3.13 parece que sí!

@cubells
Copy link
Member

cubells commented Oct 21, 2024

@ljsalvatierra-factorlibre has de corregir los tests pero funciona

Haces un cherry-pick a la 12.0 cuando acabes o lo hago yo?

@ljsalvatierra-factorlibre
Copy link
Contributor Author

@ljsalvatierra-factorlibre has de corregir los tests pero funciona

Haces un cherry-pick a la 12.0 cuando acabes o lo hago yo?

Quiero revisar primero los errores de los tests

@cubells
Copy link
Member

cubells commented Oct 21, 2024

Yo también quiero probar el módulo antes de mergear

@ljsalvatierra-factorlibre ljsalvatierra-factorlibre mentioned this pull request Oct 22, 2024
Open
@ljsalvatierra-factorlibre ljsalvatierra-factorlibre marked this pull request as ready for review October 31, 2024 13:29
PabloMartFL
PabloMartFL approved these changes Oct 31, 2024
View reviewed changes
Copy link

@PabloMartFL PabloMartFL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He probado a realizar el borrador desde el runboat y aparece correcto:
Captura desde 2024-10-31 14-30-20

@pedrobaeza
Copy link
Member

El modelo 390 está fallando, supongo que por alguno de los cambios introducidos aquí. ¿Podéis revisarlo?

ljsalvatierra-factorlibre added a commit to factorlibre/l10n-spain that referenced this pull request Nov 14, 2024
@ljsalvatierra-factorlibre
[16.0][IMP] l10n_es_aeat_mod303_extra_data: 2024/10
c370bf7 
Depends on OCA#3785
@ljsalvatierra-factorlibre ljsalvatierra-factorlibre mentioned this pull request Nov 14, 2024
Draft
ljsalvatierra-factorlibre added a commit to factorlibre/l10n-spain that referenced this pull request Nov 14, 2024
@ljsalvatierra-factorlibre
[11.0][IMP] l10n_es_aeat_mod303_oss: 2024/10
4776675 
Depends on OCA#3785
@ljsalvatierra-factorlibre ljsalvatierra-factorlibre mentioned this pull request Nov 14, 2024
Draft
ljsalvatierra-factorlibre added a commit to factorlibre/l10n-spain that referenced this pull request Nov 14, 2024
@ljsalvatierra-factorlibre
[11.0][IMP] l10n_es_aeat_mod303_extra_data: 2024/10
c151f4d 
Depends on OCA#3785
ljsalvatierra-factorlibre added a commit to factorlibre/l10n-spain that referenced this pull request Nov 19, 2024
@ljsalvatierra-factorlibre
[11.0][IMP] l10n_es_aeat_mod303_oss: 2024/10
49b6377 
Depends on OCA#3785
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabloMartFL PabloMartFL PabloMartFL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ljsalvatierra-factorlibre @OCA-git-bot @cubells @pedrobaeza @PabloMartFL @Shide