Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

Add isort third party detection from requirements.txt #629

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sample_files/pre-commit-13.0/.gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Limit conflicts in PRs by automatically merging lines of both sides
requirements.txt merge=union
1 change: 0 additions & 1 deletion sample_files/pre-commit-13.0/.isort.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,3 @@ line_length=88
known_odoo=odoo
known_odoo_addons=odoo.addons
sections=FUTURE,STDLIB,THIRDPARTY,ODOO,ODOO_ADDONS,FIRSTPARTY,LOCALFOLDER
known_third_party=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the default section, see #629 (comment).

11 changes: 5 additions & 6 deletions sample_files/pre-commit-13.0/.pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -85,13 +85,12 @@ repos:
rev: v1.26.2
hooks:
- id: pyupgrade
- repo: https://github.com/asottile/seed-isort-config
rev: v1.9.4
hooks:
- id: seed-isort-config
- repo: https://github.com/pre-commit/mirrors-isort
rev: v4.3.21
- repo: https://github.com/timothycrosley/isort
rev: 4.3.21-2
hooks:
- id: isort
name: isort except __init__.py
guewen marked this conversation as resolved.
Show resolved Hide resolved
exclude: /__init__\.py$
# TODO, the next time we upgrade isort's rev, we should remove 'types'
types: [python]
additional_dependencies: ["pipreqs==0.4.10", "pip-api==0.0.13"]
guewen marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is possibly not needed now.

Empty file.