Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update our tooling to support Odoo 15 #509

Closed
14 of 15 tasks
sbidoul opened this issue Oct 5, 2021 · 20 comments
Closed
14 of 15 tasks

Update our tooling to support Odoo 15 #509

sbidoul opened this issue Oct 5, 2021 · 20 comments

Comments

@sbidoul
Copy link
Member

sbidoul commented Oct 5, 2021

What needs to be done to create the 15.0 branches

@legalsylvain
Copy link
Contributor

@pedrobaeza

This comment has been minimized.

@sbidoul
Copy link
Member Author

sbidoul commented Oct 6, 2021

@pedrobaeza @hbrunn @StefanRijnhart to unlock various things depending on it, I pushed odoo/odoo:15.0 to oca/ocb:15.0. Let me know if this is not the right thing to do. Also if one of you feels like updating the ocb sync script in this repo and on the oca server, this is most welcome :)

@pedrobaeza
Copy link
Member

Yeah, it's OK to do such initial push, or even do manual pulls since now until we have the sync script. I don't know where such script is hosted and how it works, so I'm afraid I can't help there.

@pedrobaeza
Copy link
Member

Any news regarding 15.0 branches creation? People is expectant and asking in several places.

@sbidoul
Copy link
Member Author

sbidoul commented Oct 13, 2021

It's getting in good shape. We need to merge the two open PR in oca/oca-addons-repo-template and then I'll create the branches later this week, or this week-end.

@pedrobaeza
Copy link
Member

Should I review or do anything?

@sbidoul
Copy link
Member Author

sbidoul commented Oct 13, 2021

I'd like to do a test on one repo before creating all branches. So reviewing and merging and testing oca/oca-addons-repo-template can help.

@feketemihai
Copy link
Member

@sbidoul This week there was a branch 15.0 created in l10n-romania, https://github.com/OCA/l10n-romania/tree/15.0, is this intended, should we remove it?

@sbidoul
Copy link
Member Author

sbidoul commented Oct 14, 2021

@feketemihai this branch seems to be bound to the 14.0 project template, so yes it's better to remove it. I'll create them all in the coming days.

@sbidoul
Copy link
Member Author

sbidoul commented Oct 15, 2021

Yeah, it's OK to do such initial push, or even do manual pulls since now until we have the sync script. I don't know where such script is hosted and how it works, so I'm afraid I can't help there.

I'm going to deploy the OCB sync script. @pedrobaeza can you confirm that we start fresh with each new branch ? I.e. we don't carry over backports from previous branches ?

@pedrobaeza
Copy link
Member

Yes, we always start fresh, and if a backport/patch is still needed in new version, a new PR should be done.

@pedrobaeza
Copy link
Member

pedrobaeza commented Oct 15, 2021

Out of curiosity, this is the differences between OCB 14.0 and Odoo:

https://github.com/odoo/odoo/compare/14.0..OCA:14.0

(I have pushed today's changes manually for reducing the diff. This snapshot diff will be only valid after each sync)

@sbidoul
Copy link
Member Author

sbidoul commented Oct 15, 2021

I've tested the new linters on server-tools. The changes should be ok. Most of them are from black removing leading and trailing spaces from docstrings, which means black is stabilizing (good!). And a few minor changes from pyupgrades.

flake8 catches some new things but should be ok for most, we'll see how it goes.

I also ran it on OCA/web. There prettier is doing some more significant changes on js code. Not sure how much of that js code will have to be rewritten for owl though, so it might be less of an issue.

@pedrobaeza
Copy link
Member

Thanks for the insights

@sbidoul
Copy link
Member Author

sbidoul commented Oct 15, 2021

I initialized server-tools 15.0 using #472.

@pedrobaeza
Copy link
Member

And what about the rest of the process done by https://github.com/OCA/maintainer-tools/blob/master/tools/migrate_branch_empty.py?

  • Migration issue creation
  • Milestone creation
  • Default branch (if working again)

@sbidoul
Copy link
Member Author

sbidoul commented Oct 15, 2021

For the migration issue and milestone there is now oca-create-migration-issue. I think we can now decommission migrate-branch and migrate-branch-empty.

For the default branch I'd need to test again. Is it not ok to let each PSC representative change it?

@pedrobaeza
Copy link
Member

For the default branch I'd need to test again. Is it not ok to let each PSC representative change it?

In my experience, if I don't tell you about doing it or I do it myself (for the branches I have permissions), repositories languish unchanged.

@sbidoul
Copy link
Member Author

sbidoul commented Feb 8, 2022

I updated the weblate deployment to pick up 15.0 branches

@sbidoul sbidoul pinned this issue May 26, 2022
@sbidoul sbidoul closed this as completed Sep 21, 2022
@yajo yajo unpinned this issue Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants