This repository has been archived by the owner on May 16, 2024. It is now read-only.
[FIX] fix compatibility with 15.0 PyPI addon naming scheme #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
sbidoul
reviewed
Oct 6, 2021
Comment on lines
+132
to
139
| if [[ $VERSION < '15' ]] | ||
| then | ||
| SHORT_VERSION=$(echo $VERSION | cut -d '.' -f 1) | ||
| else | ||
| SHORT_VERSION="" | ||
| fi | ||
| for addon in $(ls setup/ -I README -I _metapackage) ; do | ||
| addon_dist="odoo${SHORT_VERSION}-addon-${addon}" |
There was a problem hiding this comment.
Suggested change
| if [[ $VERSION < '15' ]] | |
| then | |
| SHORT_VERSION=$(echo $VERSION | cut -d '.' -f 1) | |
| else | |
| SHORT_VERSION="" | |
| fi | |
| for addon in $(ls setup/ -I README -I _metapackage) ; do | |
| addon_dist="odoo${SHORT_VERSION}-addon-${addon}" | |
| if [[ $VERSION < '15' ]] | |
| then | |
| DIST_PREFIX_VERSION=$(echo $VERSION | cut -d '.' -f 1) | |
| else | |
| DIST_PREFIX_VERSION="" | |
| fi | |
| for addon in $(ls setup/ -I README -I _metapackage) ; do | |
| addon_dist="odoo${DIST_PREFIX_VERSION}-addon-${addon}" |
sbidoul
changed the title
sbidoul
suggested changes
Oct 15, 2021
| @@ -129,7 +129,12 @@ else | |||
| echo "Installing addons to test and their dependencies" | |||
| pip install setuptools-odoo | |||
| setuptools-odoo-make-default --clean --addons-dir . | |||
| SHORT_VERSION=$(echo $VERSION | cut -d '.' -f 1) | |||
| if [[ $VERSION < '15' ]] | |||
There was a problem hiding this comment.
This won't work for Odoo 8 and 9
|
Superseded by #699 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sbidoul