[17.0][MIG] mrp_bom_tracking: Migration to 17.0 #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: manufacture-15.0/manufacture-15.0-mrp_bom_tracking Translate-URL: https://translation.odoo-community.org/projects/manufacture-15-0/manufacture-15-0-mrp_bom_tracking/
Currently translated at 100.0% (19 of 19 strings) Translation: manufacture-15.0/manufacture-15.0-mrp_bom_tracking Translate-URL: https://translation.odoo-community.org/projects/manufacture-15-0/manufacture-15-0-mrp_bom_tracking/it/
Currently translated at 100.0% (19 of 19 strings) Translation: manufacture-15.0/manufacture-15.0-mrp_bom_tracking Translate-URL: https://translation.odoo-community.org/projects/manufacture-15-0/manufacture-15-0-mrp_bom_tracking/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: manufacture-16.0/manufacture-16.0-mrp_bom_tracking Translate-URL: https://translation.odoo-community.org/projects/manufacture-16-0/manufacture-16-0-mrp_bom_tracking/
Currently translated at 100.0% (19 of 19 strings) Translation: manufacture-16.0/manufacture-16.0-mrp_bom_tracking Translate-URL: https://translation.odoo-community.org/projects/manufacture-16-0/manufacture-16-0-mrp_bom_tracking/it/
Currently translated at 100.0% (19 of 19 strings) Translation: manufacture-16.0/manufacture-16.0-mrp_bom_tracking Translate-URL: https://translation.odoo-community.org/projects/manufacture-16-0/manufacture-16-0-mrp_bom_tracking/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: manufacture-16.0/manufacture-16.0-mrp_bom_tracking Translate-URL: https://translation.odoo-community.org/projects/manufacture-16-0/manufacture-16-0-mrp_bom_tracking/
GuillemCForgeFlow
suggested changes
Mar 11, 2024
mrp_bom_tracking/models/mrp_bom.py
Outdated
Comment on lines
58
to
74
| if "product_id" in values: | ||
| for bom in self.mapped("bom_id"): | ||
| # Bind bom variable for the current iteration to the lambda | ||
| lines = self.filtered(lambda x, bom=bom: x.bom_id == bom) | ||
| product_id = values.get("product_id") | ||
| if product_id: | ||
| product_id = self.env["product.product"].browse(product_id) | ||
| product_id = product_id or lines.product_id | ||
| if lines: | ||
| message_body = template_env._render_template( | ||
| "mrp_bom_tracking.track_bom_template_2", | ||
| values={"lines": lines, "product_id": product_id}, | ||
| ) | ||
| bom.message_post( | ||
| body=message_body, subtype_id=self.env.ref("mail.mt_note").id | ||
| ) |
There was a problem hiding this comment.
Suggested change
| if "product_id" in values: | |
| for bom in self.mapped("bom_id"): | |
| # Bind bom variable for the current iteration to the lambda | |
| lines = self.filtered(lambda x, bom=bom: x.bom_id == bom) | |
| product_id = values.get("product_id") | |
| if product_id: | |
| product_id = self.env["product.product"].browse(product_id) | |
| product_id = product_id or lines.product_id | |
| if lines: | |
| message_body = template_env._render_template( | |
| "mrp_bom_tracking.track_bom_template_2", | |
| values={"lines": lines, "product_id": product_id}, | |
| ) | |
| bom.message_post( | |
| body=message_body, subtype_id=self.env.ref("mail.mt_note").id | |
| ) | |
| if "product_id" in values: | |
| for bom_line in self: | |
| bom = bom_line.bom_id | |
| product_id = values.get("product_id") | |
| product = self.env["product.product"].browse(product_id) | |
| if product.exists(): | |
| message_body = template_env._render_template( | |
| "mrp_bom_tracking.track_bom_template_2", | |
| values={"lines": bom_line, "product_id": product}, | |
| ) | |
| bom.message_post( | |
| body=message_body, subtype_id=self.env.ref("mail.mt_note").id | |
| ) |
product_id check was already done at the beginning of the indentation, no need to do it again. Also, refactor to iterate over self, which contains the BoM lines, as before the change, it was already doing one message posting per line change. I believe this refactoring simplifies the understanding of the logic. What do you think?
I believe this is more of a general improvement, nothing related to the migration itself.
AndreuOForgeFlow
force-pushed
the
17.0-mig-mrp_bom_tracking
branch
from
7820a93 to
71dce9e
Compare
GuillemCForgeFlow
approved these changes
Mar 11, 2024
|
/ocabot migration mrp_bom_tracking |
AndreuOForgeFlow
force-pushed
the
17.0-mig-mrp_bom_tracking
branch
from
71dce9e to
eeb307e
Compare
Done @LoisRForgeFlow! |
LoisRForgeFlow
approved these changes
Mar 26, 2024
|
On my way to merge this fine PR! |
|
This PR has the |
|
Congratulations, your PR was merged at 817ade7. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard migration
@ForgeFlow