-
-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] mrp_lot_number_propagation #1299
base: 17.0
Are you sure you want to change the base?
Conversation
When defining a single BOM for a product template having multiple product variants, we can have different components where the lot number must be propagated for different product variants. Therefore we need to allow to mark multiple BOM line with propagate_lot_number, and to avoid complicating the check function on the BOM lines, we ensure at the manufacturing order confirmation that only a single component is set to propagate its lot number.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: manufacture-15.0/manufacture-15.0-mrp_lot_number_propagation Translate-URL: https://translation.odoo-community.org/projects/manufacture-15-0/manufacture-15-0-mrp_lot_number_propagation/
Currently translated at 100.0% (23 of 23 strings) Translation: manufacture-15.0/manufacture-15.0-mrp_lot_number_propagation Translate-URL: https://translation.odoo-community.org/projects/manufacture-15-0/manufacture-15-0-mrp_lot_number_propagation/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: manufacture-15.0/manufacture-15.0-mrp_lot_number_propagation Translate-URL: https://translation.odoo-community.org/projects/manufacture-15-0/manufacture-15-0-mrp_lot_number_propagation/
Currently translated at 100.0% (24 of 24 strings) Translation: manufacture-15.0/manufacture-15.0-mrp_lot_number_propagation Translate-URL: https://translation.odoo-community.org/projects/manufacture-15-0/manufacture-15-0-mrp_lot_number_propagation/it/
Currently translated at 100.0% (24 of 24 strings) Translation: manufacture-15.0/manufacture-15.0-mrp_lot_number_propagation Translate-URL: https://translation.odoo-community.org/projects/manufacture-15-0/manufacture-15-0-mrp_lot_number_propagation/it/
Currently translated at 100.0% (24 of 24 strings) Translation: manufacture-16.0/manufacture-16.0-mrp_lot_number_propagation Translate-URL: https://translation.odoo-community.org/projects/manufacture-16-0/manufacture-16-0-mrp_lot_number_propagation/es/
e8c931b
to
c02c060
Compare
for order in self: | ||
if ( | ||
order.is_lot_number_propagated | ||
and "lot_producing_id" in vals |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@astirpe if lot_producing_id is False we should not raise the error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CasVissers-360ERP done here c62f997 could you check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thnx resolved.
@astirpe Can you please squash your last commit? |
c62f997
to
bcbb8bb
Compare
@bosd squashed, thanks! |
This PR has the |
Seems like the @OCA-git-bot is still on holiday, as this one carries the approved label and can be merged. Just noticed the "confusing" naming of this module. |
The idea was to leave this option open in the technical name to also propagate LOT numbers in the future and not just SN. Also Odoo std naming only talks about LOT and not about SN. |
No description provided.