[9.0][MIG] quality_control #198

LoisRForgeFlow · 2017-05-24T15:26:33Z

Continue the works started in #100.

MiquelRForgeFlow

LGTM 👍
But I think some of the previous commits could be squashed.

LoisRForgeFlow · 2017-06-15T11:52:50Z

Cherry-picked fix done in #205

andhit-r

Code review

andhit-r · 2017-06-27T13:43:39Z

quality_control/wizard/qc_test_wizard.py

+# -*- coding: utf-8 -*-
+##############################################################################
+# For copyright and license notices, see __openerp__.py file in root directory
+##############################################################################


Change into short header

andhit-r · 2017-06-27T13:43:48Z

quality_control/wizard/__init__.py

+# -*- encoding: utf-8 -*-
+##############################################################################
+# For copyright and license notices, see __openerp__.py file in root directory
+##############################################################################


Change into short header

andhit-r · 2017-06-27T13:44:35Z

quality_control/models/qc_trigger_line.py

+# -*- coding: utf-8 -*-
+##############################################################################
+# For copyright and license notices, see __openerp__.py file in root directory
+##############################################################################


Change into short header

andhit-r · 2017-06-27T13:44:44Z

quality_control/models/qc_trigger.py

+# -*- coding: utf-8 -*-
+##############################################################################
+# For copyright and license notices, see __openerp__.py file in root directory
+##############################################################################


Change into short header

andhit-r · 2017-06-27T13:44:52Z

quality_control/models/qc_test_category.py

+# -*- coding: utf-8 -*-
+##############################################################################
+# For copyright and license notices, see __openerp__.py file in root directory
+##############################################################################


Change into short header

andhit-r · 2017-06-27T13:45:27Z

quality_control/models/product_template.py

+# -*- coding: utf-8 -*-
+##############################################################################
+# For copyright and license notices, see __openerp__.py file in root directory
+##############################################################################


Change into short header

andhit-r · 2017-06-27T13:45:34Z

quality_control/models/product_product.py

+# -*- coding: utf-8 -*-
+##############################################################################
+# For copyright and license notices, see __openerp__.py file in root directory
+##############################################################################


Change into short header

andhit-r · 2017-06-27T13:45:40Z

quality_control/models/product_category.py

+# -*- coding: utf-8 -*-
+##############################################################################
+# For copyright and license notices, see __openerp__.py file in root directory
+##############################################################################


Change into short header

andhit-r · 2017-06-27T13:45:48Z

quality_control/models/__init__.py

+# -*- encoding: utf-8 -*-
+##############################################################################
+# For copyright and license notices, see __openerp__.py file in root directory
+##############################################################################


Change into short header

andhit-r · 2017-06-27T13:46:11Z

quality_control/__init__.py

+# -*- coding: utf-8 -*-
+##############################################################################
+# For copyright and license notices, see __openerp__.py file in root directory
+##############################################################################


Change into short header

LoisRForgeFlow · 2017-07-03T15:29:13Z

Open PRs in v8:

: [FIX] quality_control: Fix TypeError on new test category #193
: [IMP] quality_control: show action_cancel button in inspections even if it is autogenerated #213 (merged and added here)

LoisRForgeFlow · 2017-07-24T08:21:02Z

@andhit-r Is this ok for you now? could you update your review?

LoisRForgeFlow · 2017-10-30T12:11:48Z

@andhit-r ping

LoisRForgeFlow · 2017-11-09T09:52:28Z

@OCA/manufacturing-maintainers can we get an update on this?

damendieta · 2017-11-13T18:25:05Z

Hi, on creation of the Test Categories there there is an error that tries to compute the name but as It's a new record, the value is still false:

File "/mnt/extra-addons/manufacture/quality_control/models/qc_test_category.py", line 23, in _get_complete_name
self.complete_name = " / ".join(reversed(names))
TypeError: sequence item 0: expected string, bool found

Replacing:
names = [self.name]
With:
names = [self.name or '']

Solves the issue.

Daniel.

damendieta · 2017-11-13T19:25:05Z

Hi, I already fixed it and added some minor changes that I needed to test the module.

I made a PR with the changes:
ForgeFlow#2

Also, could you please explain the logic of triggers on the readme, I coudn't find a way to make triggers work.

Thanks a lot.

LoisRForgeFlow · 2017-11-14T10:41:55Z

Hi @damendieta

First of all: thanks for your review!

Regarding the bug you reported, it is already being fixed in v8 and waiting to be ported to this PR after its merge, as noted here: #198 (comment). Please review that PR (#193) in order to move forward.

About the qc triggers, let me clarify that to make use of them you need either quality_control_mrp or quality_control_stock modules. However, they still need to be migrated to v9.

Your help would be appreciated 😉

damendieta · 2017-11-14T17:41:45Z

@lreficent ok, I approved the PR #193, what else do we need for it to get merged?

LoisRForgeFlow · 2017-11-20T10:08:44Z

@damendieta fix from #193 added. Now you can review this PR and approve it if everything is ok for you.

eLBati · 2017-11-20T11:13:34Z

@lreficent hi, could you check commits like e6d8961 with no message and unrecognised author?
Also please check if some commits can be squashed

LoisRForgeFlow · 2017-11-20T11:30:35Z

Hi @eLBati

It looks like "alfredo" has changed either his github email or name and that's why the author is unrecognized, however I don't know his current github account (If someone could point it to me I'll change the commit author accordingly). Regarding the squashing, I've already squashed consecutive transifex commits, I don't know if I can squash further since I'm not the author of any of the previous versions commits.

eLBati · 2017-11-20T11:34:23Z

Maybe @oihane or @pedrobaeza know about his account?

oihane · 2017-11-20T11:45:54Z

Alfredo de la Fuente's github user is alfredoavanzosc

…ondelete="cascade" * required changes

Making it a regular field, you can put any manual quantity in inspections

…rigger lines

…if it is autogenerated

`TestQualityControl` is failing on `QcTestTemplateCatergory._get_complete_name` when `name` is set as `False`.

LoisRForgeFlow · 2017-11-20T14:09:23Z

@oihane Thanks!

@eLBati history has been fixed.

eLBati

Just a remark

eLBati · 2017-11-20T16:01:20Z

quality_control/views/product_category_view.xml

@@ -0,0 +1,24 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>


Please use odoo

Done, Thanks!

SimoRubi

Just code review, looks good

LoisRForgeFlow · 2017-11-21T10:42:13Z

@SimoRubi Hi, please use the option to approve when submitting the review:

LoisRForgeFlow · 2017-11-21T10:43:05Z

@damendieta If you are ok with this we can merge it I think

SimoRubi

Code review, looks good

LoisRForgeFlow force-pushed the 9.0-mig-quality_control branch from 103f1b6 to 374ba42 Compare May 24, 2017 15:28

This was referenced May 24, 2017

[ADD] Added quality_control_* modules #100

Closed

Migration to version 9.0 #41

Closed

LoisRForgeFlow mentioned this pull request May 25, 2017

[9.0][ADD] quality_control_issue #199

Merged

3 tasks

LoisRForgeFlow force-pushed the 9.0-mig-quality_control branch from 374ba42 to 6d262f5 Compare June 6, 2017 10:41

MiquelRForgeFlow approved these changes Jun 12, 2017

View reviewed changes

andhit-r suggested changes Jun 27, 2017

View reviewed changes

LoisRForgeFlow mentioned this pull request Jul 3, 2017

[9.0][ADD] quality_control_team #214

Merged

1 task

JordiBForgeFlow force-pushed the 9.0-mig-quality_control branch from 784cce1 to e12fbd6 Compare July 11, 2017 14:01

LoisRForgeFlow requested a review from JordiBForgeFlow November 9, 2017 11:46

damendieta mentioned this pull request Nov 14, 2017

9.0 [WIP] [MIG] quality_control_samples #236

Closed

1 task

This was referenced Nov 15, 2017

[9.0] [WIP] quality_control_stock #238

Closed

[9.0] [WIP] quality_control_mrp #237

Closed

oihane and others added 3 commits November 20, 2017 15:05

Modulos de calidad sin migrar

7f53e59

quality_control * PEP8 * some fixing * translations

5eed926

quality_control * PEP8 * Travis * Size in field (deprecated)

e5d3406

oihane and others added 18 commits November 20, 2017 15:08

quality_control: Fixing coveralls

41d2e55

quality_control_stock: * added demo data * replaced unlink method by …

c87cea9

…ondelete="cascade" * required changes

OCA Transbot updated translations from Transifex

38f40c8

quality_control_*: Make use of qty field

7b73721

Making it a regular field, you can put any manual quantity in inspections

OCA Transbot updated translations from Transifex

e4f9568

quality_control: deleting qc.inspection does not delete its lines fixed

8421d24

OCA Transbot updated translations from Transifex

038a471

remove en.po that was erroneously created by transbot

f64a226

OCA Transbot updated translations from Transifex

c307a8c

quality_control: decimal precision configurable

7f2ec23

OCA Transbot updated translations from Transifex

a86e94a

quality_control: approving inspections only quality control managers

0b61361

OCA Transbot updated translations from Transifex

9ee316d

[9.0][MIG] quality_control

1baa7c9

[9.0][FIX] quality_control: not take into account inactivated tests t…

57b16de

…rigger lines

headers

edd1df0

[IMP] quality_control: show action_cancel button in inspections even …

871b35e

…if it is autogenerated

[FIX] quality_control: Fix TypeError on new test category (OCA#193)

00f2af7

`TestQualityControl` is failing on `QcTestTemplateCatergory._get_complete_name` when `name` is set as `False`.

LoisRForgeFlow force-pushed the 9.0-mig-quality_control branch from c3f8d94 to 00f2af7 Compare November 20, 2017 14:08

eLBati approved these changes Nov 20, 2017

View reviewed changes

SimoRubi reviewed Nov 21, 2017

View reviewed changes

[9.0][FIX] quality_control: use odoo tag on views

d845893

LoisRForgeFlow removed the request for review from JordiBForgeFlow November 21, 2017 10:40

SimoRubi approved these changes Nov 21, 2017

View reviewed changes

SimoRubi mentioned this pull request Nov 21, 2017

10.0 mig quality control #239

Merged

andhit-r approved these changes Nov 23, 2017

View reviewed changes

LoisRForgeFlow merged commit b2faed4 into OCA:9.0 Nov 23, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[9.0][MIG] quality_control #198

[9.0][MIG] quality_control #198

LoisRForgeFlow commented May 24, 2017

MiquelRForgeFlow left a comment

LoisRForgeFlow commented Jun 15, 2017

andhit-r left a comment

andhit-r Jun 27, 2017

andhit-r Jun 27, 2017

andhit-r Jun 27, 2017

andhit-r Jun 27, 2017

andhit-r Jun 27, 2017

andhit-r Jun 27, 2017

andhit-r Jun 27, 2017

andhit-r Jun 27, 2017

andhit-r Jun 27, 2017

andhit-r Jun 27, 2017

LoisRForgeFlow commented Jul 3, 2017 •

edited

Loading

LoisRForgeFlow commented Jul 24, 2017

LoisRForgeFlow commented Oct 30, 2017

LoisRForgeFlow commented Nov 9, 2017

damendieta commented Nov 13, 2017

damendieta commented Nov 13, 2017 •

edited

Loading

LoisRForgeFlow commented Nov 14, 2017

damendieta commented Nov 14, 2017

LoisRForgeFlow commented Nov 20, 2017

eLBati commented Nov 20, 2017

LoisRForgeFlow commented Nov 20, 2017

eLBati commented Nov 20, 2017

oihane commented Nov 20, 2017

LoisRForgeFlow commented Nov 20, 2017

eLBati left a comment

eLBati Nov 20, 2017

LoisRForgeFlow Nov 21, 2017

SimoRubi left a comment

LoisRForgeFlow commented Nov 21, 2017

LoisRForgeFlow commented Nov 21, 2017

SimoRubi left a comment

		@@ -0,0 +1,24 @@
		<?xml version="1.0" encoding="utf-8"?>
		<openerp>

[9.0][MIG] quality_control #198

[9.0][MIG] quality_control #198

Conversation

LoisRForgeFlow commented May 24, 2017

MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

LoisRForgeFlow commented Jun 15, 2017

andhit-r left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LoisRForgeFlow commented Jul 3, 2017 • edited Loading

LoisRForgeFlow commented Jul 24, 2017

LoisRForgeFlow commented Oct 30, 2017

LoisRForgeFlow commented Nov 9, 2017

damendieta commented Nov 13, 2017

damendieta commented Nov 13, 2017 • edited Loading

LoisRForgeFlow commented Nov 14, 2017

damendieta commented Nov 14, 2017

LoisRForgeFlow commented Nov 20, 2017

eLBati commented Nov 20, 2017

LoisRForgeFlow commented Nov 20, 2017

eLBati commented Nov 20, 2017

oihane commented Nov 20, 2017

LoisRForgeFlow commented Nov 20, 2017

eLBati left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SimoRubi left a comment

Choose a reason for hiding this comment

LoisRForgeFlow commented Nov 21, 2017

LoisRForgeFlow commented Nov 21, 2017

SimoRubi left a comment

Choose a reason for hiding this comment

LoisRForgeFlow commented Jul 3, 2017 •

edited

Loading

damendieta commented Nov 13, 2017 •

edited

Loading