[16.0] sale_margin_delivery: Store percentage value as into odoo #215
Conversation
'price_reduce' is deprecated and removed into the next version. Compute the prirce_reduct from the price_subotal / product_uom_qty. We might be tempted to use the 'price_reduce_taxecl' field from the sale order line but this field is rounded by default to the monetary precision. As an additional benefit this change ensures the compatibility with the 'sale_triple_discount' addon. Indeed, when 'sale_triple_discount' is installed, the discount field is not used as an aggregation of all the applied discount. It's only use to store the first discount applied. Therefore, the field is not properly computed since it doesn't include the second and third discount.
Put all the new fields after the orginal margin fields from odoo. (prior to this change, the new fields were displayed among the margin fields from Odoo
|
Hi @sergio-teruel, @Shide, |
|
@Shide @yajo @Gelojr @fcvalgar following my comment #214 (comment) |
lmignon
force-pushed
the
16.0-sale-margin-percent-storage-lmi
branch
2 times, most recently
from
c8c48cd
to
68d883c
Compare
|
@lmignon It seems dropshipping module should be updated too. |
lmignon
force-pushed
the
16.0-sale-margin-percent-storage-lmi
branch
from
68d883c
to
9da2131
Compare
it's done. |
…ion of 1 As it's done into the sale_margin addon from odoo
lmignon
force-pushed
the
16.0-sale-margin-percent-storage-lmi
branch
from
a358e2c
to
40f3658
Compare
|
/ocabot merge nobump Done with nobump because version is already updated manually |
|
This PR looks fantastic, let's merge it! |
|
@Shide your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-215-by-Shide-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
/ocabot mege nobump |
|
Hi @Shide. Your command failed:
Ocabot commands
More information
|
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 556cf3f. Thanks a lot for contributing to OCA. ❤️ |
Prior to this change
margin_percent
100% = 1.0
50% = 0.5
margin_delivered_percent
100% = 100
50% = 50
After
margin_percent
100% = 1.0
50% = 0.5
margin_delivered_percent
100% = 1.0
50% = 0.5
includes [16.0][FIX] sale_margin_delivered: Avoid rounding error #214