Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit check does not detect missing setup.py files #93

Closed
sbidoul opened this issue Nov 28, 2021 · 0 comments · Fixed by #95
Closed

pre-commit check does not detect missing setup.py files #93

sbidoul opened this issue Nov 28, 2021 · 0 comments · Fixed by #95
Labels
bug Something isn't working

Comments

@sbidoul
Copy link
Member

sbidoul commented Nov 28, 2021

Describe the bug

When the setup.py files are missing (they are normally generated by the pre-commit config), the pre-commit check running in GitHub actions does not detect the problem.

To Reproduce

Example: OCA/l10n-italy#2229 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check that pre-commit generated files are in git OCA/oca-addons-repo-template
1 participant
@sbidoul