Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that pre-commit generated files are in git #95

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Check that pre-commit generated files are in git #95

merged 1 commit into from
Dec 15, 2021

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Nov 28, 2021

Fixes #93

@sbidoul
Copy link
Member Author

sbidoul commented Nov 28, 2021

Example run here: https://github.com/OCA/mis-builder/runs/4346459664?check_suite_focus=true

ivantodorovich
ivantodorovich approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@ivantodorovich ivantodorovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@OCA-git-bot
Copy link

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@yajo yajo merged commit 7a81b22 into master Dec 15, 2021
@OCA-git-bot OCA-git-bot deleted the pre-commit-detect-new-files branch December 15, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joao-p-marques joao-p-marques joao-p-marques approved these changes

@ivantodorovich ivantodorovich ivantodorovich approved these changes

Assignees
No one assigned
Labels
approved needs review ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pre-commit check does not detect missing setup.py files
5 participants
@sbidoul @OCA-git-bot @ivantodorovich @joao-p-marques @yajo