Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow addon maintainers to ocabot merge migration PRs #122

Closed
sbidoul opened this issue Jun 25, 2020 · 6 comments
Closed

Allow addon maintainers to ocabot merge migration PRs #122

sbidoul opened this issue Jun 25, 2020 · 6 comments
Labels
Bot Task A task the bot does or should do enhancement New feature or request

Comments

@sbidoul
Copy link
Member

sbidoul commented Jun 25, 2020

First thing is to write down the algorithm...

@sbidoul sbidoul added enhancement New feature or request Bot Task A task the bot does or should do labels Jun 25, 2020
@legalsylvain
Copy link
Collaborator

Hi @sbidoul : I'm very interested by this one. I don't know how to implement it however.

Use case :

Different approaches at the first sight :

  1. git fetch various previous branches (13.0, 12.0, 11.0, ...), until founding a branch that contain an installable module name account_template_active. Check if the user that call ocabot merge is the maintainer of the latest version of the module.
  2. Call github and wget https://github.com/OCA/account-financial-tools/blob/XX.0/account_template_active/__manifest__.py files and check if the manifest contains the author of the call.
  3. Call via API, odoo-community.org. (not sure, it seems that somebody said me it was not possible). (BTW, it seems that the instance doesn't fetch latest modules because the module account_template_active is not available on OCA website)
  4. Other ?

@joao-p-marques
Copy link
Member

Cool 👍 This would, indeed, be very helpfull... There would still be some cases the bot wouldn't pick up (when it is renamed or moved to a different repo) but it would still cover the majority of the cases and would already be of great help.

Option 1 gived by @legalsylvain seems to be the easiest one

@legalsylvain
Copy link
Collaborator

thanks @joao-p-marques for your review.

@sbidoul, @pedrobaeza : any point of view regarding the different possibilities ?

@pedrobaeza
Copy link
Member

pedrobaeza commented Oct 11, 2021

As I don't know the internals of how this is done, I can't say which one is the best approach, but it seems the third option is not very feasible. I see the number 1 as the way to go.

@sbidoul
Copy link
Member Author

sbidoul commented Oct 11, 2021

Yep, 1 or 2.

Option 2 (with requests.get) is probably faster and since it is not the API it should not be sensitive to API rate limits.

@pedrobaeza
Copy link
Member

Cool, then 2 is lighter

legalsylvain added a commit to legalsylvain/oca-github-bot that referenced this issue Apr 13, 2022
legalsylvain added a commit to legalsylvain/oca-github-bot that referenced this issue Apr 13, 2022
legalsylvain added a commit to legalsylvain/oca-github-bot that referenced this issue Apr 13, 2022
legalsylvain added a commit to legalsylvain/oca-github-bot that referenced this issue Apr 14, 2022
legalsylvain added a commit to legalsylvain/oca-github-bot that referenced this issue Apr 14, 2022
legalsylvain added a commit to legalsylvain/oca-github-bot that referenced this issue Apr 14, 2022
legalsylvain added a commit to legalsylvain/oca-github-bot that referenced this issue Apr 14, 2022
legalsylvain added a commit to legalsylvain/oca-github-bot that referenced this issue Apr 14, 2022
legalsylvain added a commit to legalsylvain/oca-github-bot that referenced this issue Apr 14, 2022
sbidoul added a commit that referenced this issue May 29, 2022
…ther-branches

[IMP] Search addons maintainers in other branches. Fix : #122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Task A task the bot does or should do enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants