Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] merge: publish wheels also in nobump mode #123

Merged
merged 1 commit into from
Jul 19, 2020

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Jul 2, 2020

This exception was probably done with the goal of saving space,
but for migration PRs where people use ocabot merge nobump,
we want to publish too.

This exception was probably done with the goal of saving space,
but for migration PRs where people use ocabot merge nobump,
we want to publish too.
@sbidoul
Copy link
Member Author

sbidoul commented Jul 2, 2020

@simahawk

# Update HISTORY.rst using towncrier, before generating README.rst.
# We don't do this if nobump is specified, because updating the changelog
# is something we only do when "releasing", and patch|minor|major is
# the way to mean "release" in OCA.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this means that - say - 13.0.1.0.0 is not added to the history?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simahawk Yes. There is #54 to discuss the special case of migration PRs.

@simahawk
Copy link

@sbidoul can we merge this?

@sbidoul sbidoul merged commit 9b37942 into OCA:master Jul 19, 2020
@sbidoul sbidoul deleted the publish-in-nobump-mode branch July 19, 2020 08:55
@sbidoul
Copy link
Member Author

sbidoul commented Jul 19, 2020

Yep, done and deployed on the OCA server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants