Make 'oca-port' available as a Python package + JSON output #26
Conversation
sebalix
force-pushed
the
oca_port-scripting
branch
9 times, most recently
from
66580ba to
31a1179
Compare
This class consolidates all the parameters required by oca-port to run and expose the features.
MigrateAddon: if an addon could be migrated on the target branch, the process will return 100 as exit code. PortAddonPullRequest: if some pull requests/commits could be ported for the given addon, the process will return 110 as exit code.
And an 'Output' mixin used by all the classes that need to print/render data to the user. If oca-port is not used through the CLI but instead through its API, messages won't be printed on the std output. Thanks to this change, tests can be easily added now.
sebalix
force-pushed
the
oca_port-scripting
branch
from
31a1179 to
30bbc6f
Compare
sebalix
changed the title
sebalix
force-pushed
the
oca_port-scripting
branch
2 times, most recently
from
5cd04eb to
71b667d
Compare
| @@ -38,15 +38,19 @@ | |||
| in one branch and creating a draft PR against the upstream repository with all | |||
| of them. | |||
| """ | |||
| import pathlib | |||
There was a problem hiding this comment.
not-so-nitpicking: can we please move everything out of __init__.py file? 🙏
Maybe in another round... 😉
| commit = repo.index.commit(f"[FIX] {self._settings['addon']}: fix dependency") | ||
| return commit.hexsha | ||
|
|
||
| def tearDown(self): |
There was a problem hiding this comment.
IMO you should use https://click.palletsprojects.com/en/8.1.x/testing/#file-system-isolation
| app.run() | ||
| except SystemExit as exc: | ||
| # exit code 100 means the module could be migrated | ||
| self.assertEqual(exc.args[0], 100) |
There was a problem hiding this comment.
those exceptions should have a code attribute IMO.
There was a problem hiding this comment.
I agree, but that's the std SystemExit exception that accepts only one value, like the sys.exit(...) function.
Not sure it deserves a dedicated exception inheriting from SystemExit here for such little need in a test?
sebalix
force-pushed
the
oca_port-scripting
branch
2 times, most recently
from
82115ff to
a103c93
Compare
|
This PR has the |
sebalix
force-pushed
the
oca_port-scripting
branch
from
67b00fb to
e57b65f
Compare
It currently supports only the 'json' value.
sebalix
force-pushed
the
oca_port-scripting
branch
from
e57b65f to
6cf6f7d
Compare
|
@sebalix what is left here to merge? |
Several things here (see commits):
Appclass (used by all subsequent classes to not duplicate parameters everywhere)oca_portPython package (and ease the writing of tests! So some basic tests added)--non-interactiveoption, 3 exit codes can be returned:0: all good, nothing to migrate or port (the Git history is the same on the source & target branches)100: the module could be migrated on the target branch110: some commits/pull requests could be ported on the target branch for the given module--outputto return a parse-able result (working both in CLI mode or through the API) which:--non-interactivemode automatically--fetchoption to force the fetch of source & target branches--fetchto update the remote branches (or update them by her/himself)Example:
Module already migrated but some commits could be ported:
{ "process": "port_commits", "results": { "2471": { "url": "https://github.com/OCA/server-tools/pull/2471", "author": "etobella", "title": "[OU] auditlog: Improve time of upgrade", "merged_at": "2022-11-23T22:20:50Z", "missing_commits": [ "f9976a36bc1c0142e8c803b557859c35bee4d0a1" ] }, "2485": { "url": "https://github.com/OCA/server-tools/pull/2485", "author": "SilvioC2C", "title": "[14.0][FIX] auditlog: consistency with Many2one fields", "merged_at": "2022-12-07T08:08:30Z", "missing_commits": [ "f52b024ba141fbbde1999ad5fb127720bc28a847" ] } } }Module alreay migrated and nothing to port:
TODO:
This PR implements (partially) issue #17