App: make returned result consistent with output options #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on the running mode (CLI, non-interactive, JSON output...) the
result of `App.run()` has to be consistent with the user parameters:
- with non-interactive and without output, return a boolean or exception:
- something to migrate/port: `True`
- nothing to do: `False`
- module doesn't exist on source branch: `ValueError`
- with a format output defined, return the expected format, e.g. with JSON:
- something to migrate/port: non-empty JSON document
- nothing to migrate/port: empty JSON document
- module doesn't exist on source branch: `ValueError`
- as CLI: return an exit code (+ text printed on std output):
- something to migrate: 100
- something to port: 110
- nothing to migrate/port: 0
- module doesn't exist on source branch: 1
sebalix
force-pushed
the
fix-result-consistency
branch
from
becba02
to
f2cf1f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #33
Depending on the running mode (CLI, non-interactive, JSON output...) the result of
App.run()has to be consistent with the user parameters:TrueFalseValueErrorValueError