utils.git.Commit: leverage user's cache to get commit file paths #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebalix
commented
Aug 19, 2024
sebalix
force-pushed
the
imp-commits-data-cache
branch
from
8647175
to
dca22d5
Compare
And avoid useless IO:
- do not fetch file paths when initializing Commit objects, wait for
the first access to Commit.files or Commit.paths attributes
- save cached data on disk at the end of the analyze
sebalix
force-pushed
the
imp-commits-data-cache
branch
2 times, most recently
from
abdb7ee
to
70c19b0
Compare
sebalix
force-pushed
the
imp-commits-data-cache
branch
from
70c19b0
to
ab55314
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And do not fetch file paths when initializing
Commitobjects, wait for the first access toCommit.filesorCommit.pathsattributes to avoid useless IO.Requesting files modified by a commit is taking quite a lot of time by
git, especially on big repositories (basicallygit show --stat).Before this change, the following command is taking about ~2min to execute in
OCA/wmsrepository (with others cache already built):After, it takes ~2s.