Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md + fix port of modules located in a subfolder #58

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

sebalix
Copy link
Collaborator

@sebalix sebalix commented Nov 20, 2024

No description provided.

@sebalix sebalix marked this pull request as ready for review November 20, 2024 07:48
An exception 'ValueError: 'path' is not in the subpath of './subfolder'"
could be raised when porting modules located in a subfolder if one of
its commit is also updating a file outside of this subfolder.

Keep things simple: ignore such file paths, we focus only on commits
located in the subfolder.

This should have no impact in OCA-like repositories as modules are all
located in the root folder (subfolder='.').
@sebalix sebalix changed the title Update README.md Update README.md + fix port of modules located in a subfolder Nov 20, 2024
@sebalix sebalix added the bug Something isn't working label Nov 20, 2024
@sebalix sebalix added this to the 0.16 milestone Nov 20, 2024
@sebalix sebalix merged commit 4321115 into OCA:main Nov 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant