-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically commit blacklisted ports #7
Conversation
I wonder if we should add a comment when we blacklist something, explaining the reason why we did it (changes already ported, lint, doesn't apply anymore, module replaced by another one or renamed...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to store this file in .oca/oca-port/blacklist/{MODULE}.json
(or similar)
Goal is to put it under an .oca
directory that we can use for (possible) future oca tools
Also maybe use a yml
file instead of json
, that's more common than json in this kind of tools
@ivantodorovich good ideas. For YAML the only drawback is to introduce a new dependency, while JSON is part of the Python std lib. |
I agree on the path, I agree on keeping JSON. And, yes, let's collect a comment! |
b550fa7
to
7060b2c
Compare
@simahawk I'll try to pop-up the editor during the |
Here is a demo of a blacklisted PR with the current changes: OCA/wms#464 |
e7ea359
to
a263bcd
Compare
a263bcd
to
118fd27
Compare
I'm quite happy with these changes at the moment, and want to build a new release for that, so... merging :) |
This change is not backward-compatible.
This feature will store blacklisted PR or module migration in a
./oca-port/blacklist/{MODULE}.json
file (one file per module) and this will be committed in the working branch so this information will be shared with other contributors (PR or module blacklisted won't be listed anymore, but the reason why it was blacklisted will be displayed instead).Here is a demo of a blacklisted PR with the current changes: OCA/wms#464
fix #4