Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] operating_unit to v10.0 #45

Merged
merged 7 commits into from
Jan 26, 2017
Merged

[MIG] operating_unit to v10.0 #45

merged 7 commits into from
Jan 26, 2017

Conversation

MiquelRForgeFlow
Copy link
Contributor

Operating Unit

An operating unit (OU) is an organizational entity part of a company, with
separate management ownership. Management by OU is aimed to introduce the
following features:

  • Data partitioning from other OU.
  • Own sequencing schemes.
  • User access administration for data processing and reporting.
  • Product and customer independence of OU.
  • OU specific P&L and Balance sheet.

JordiBForgeFlow
JordiBForgeFlow reviewed Jan 26, 2017
View reviewed changes
operating_unit/README.rst
.. image:: https://img.shields.io/badge/license-LGPLv3-blue.svg
:target: https://www.gnu.org/licenses/lgpl.html
:alt: License: LGPL-3
.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License should be LGPL

JordiBForgeFlow
JordiBForgeFlow reviewed Jan 26, 2017
View reviewed changes
operating_unit/README.rst
@@ -39,6 +39,14 @@ Other modules extend the standard Odoo apps with the OU.
:alt: Try me on Runbot
:target: https://runbot.odoo-community.org/runbot/213/9.0

.. repo_id is available in https://github.com/OCA/maintainer-tools/blob/master/tools/repos_with_ids.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove that. It is only used to help newcomers

JordiBForgeFlow
JordiBForgeFlow reviewed Jan 26, 2017
View reviewed changes
operating_unit/README.rst
.. repo_id is available in https://github.com/OCA/maintainer-tools/blob/master/tools/repos_with_ids.txt
.. branch is "10.0" for example

Known issues / Roadmap
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused sections

JordiBForgeFlow
JordiBForgeFlow reviewed Jan 26, 2017
View reviewed changes
operating_unit/__manifest__.py
# License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl.html).

{
"name": "Operating Unit",
"summary": "An operating unit (OU) is an organizational entity part of a "
"company",
"version": "9.0.1.0.0",
"version": "10.0.1.0.0",
"author": "Eficent Business and IT Consulting Services S.L., "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename Eficent Business and IT Consulting Services S.L. to just Eficent

@JordiBForgeFlow
Copy link
Member

JordiBForgeFlow commented Jan 26, 2017 •
edited
Loading

I am missing the place where you change in manifest.py the 'installable': True

This was referenced Jan 26, 2017
Merged
Merged
Merged
Merged
Merged
@LoisRForgeFlow LoisRForgeFlow mentioned this pull request Jan 26, 2017
Merged
LoisRForgeFlow
LoisRForgeFlow suggested changes Jan 26, 2017
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check tags.

operating_unit/demo/operating_unit_demo.xml
<openerp>
<data noupdate="0">

<odoo>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy the noupdate="0" to the renamed <odoo> tag.

operating_unit/data/operating_unit_data.xml
@@ -1,7 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<openerp>
<odoo>
<data noupdate="1">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy the noupdate="1" to the renamed tag.

operating_unit/security/operating_unit_security.xml
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<openerp>
<odoo>
<data noupdate="1">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy the noupdate="1" to the renamed <odoo> tag. Remove <data> tag.

@LoisRForgeFlow
Copy link
Contributor

Travis seems to be stuck. I don't know the reason.

AaronHForgeFlow
AaronHForgeFlow reviewed Jan 26, 2017
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO The group Administration / Access Right should be Operating unit user and the group Administration / Settings should be able to be manage Operating units

@LoisRForgeFlow
Copy link
Contributor

Agree with @aheficent comment about rights.

@AaronHForgeFlow
Copy link
Contributor

Why travis is not starting? Is because transifex is missing in travis config file?

@JordiBForgeFlow
Copy link
Member

@moylop260 Can you help us here? Travis fails

@LoisRForgeFlow
Copy link
Contributor

Runbot is running correctly now.

I agree with @aheficent changes but if you want to leave it as it is this PR is ready to merge.

cc @jbeficent @guewen

AaronHForgeFlow
AaronHForgeFlow approved these changes Jan 26, 2017
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runbot is working perfectly 👍

Regarding my previous comment, in case of changes those have to be done in another PR. The security settings have to be the same as they are in v9

@JordiBForgeFlow JordiBForgeFlow merged commit d121b80 into OCA:10.0 Jan 26, 2017
@LoisRForgeFlow LoisRForgeFlow mentioned this pull request Jan 27, 2017
Closed
7 tasks
JordiBForgeFlow pushed a commit that referenced this pull request Feb 20, 2018
@MiquelRForgeFlow @JordiBForgeFlow
[MIG] operating_unit to v10.0 (#45)
6dbf0d5 
* [MIG] operating_unit to v10.0
AaronHForgeFlow pushed a commit that referenced this pull request Nov 21, 2018
@MiquelRForgeFlow @AaronHForgeFlow
[MIG] operating_unit to v10.0 (#45)
8a63ef8 
* [MIG] operating_unit to v10.0
alan196 pushed a commit to Jarsa-dev/operating-unit that referenced this pull request Dec 29, 2019
@MiquelRForgeFlow @alan196
[MIG] operating_unit to v10.0 (OCA#45)
7a9de09 
* [MIG] operating_unit to v10.0
alan196 pushed a commit to Jarsa-dev/operating-unit that referenced this pull request Dec 30, 2019
@MiquelRForgeFlow @alan196
[MIG] operating_unit to v10.0 (OCA#45)
e79eb28 
* [MIG] operating_unit to v10.0
alan196 pushed a commit to Jarsa-dev/operating-unit that referenced this pull request Oct 10, 2020
@MiquelRForgeFlow @alan196
[MIG] operating_unit to v10.0 (OCA#45)
ec6b866 
* [MIG] operating_unit to v10.0
alan196 pushed a commit to Jarsa-dev/operating-unit that referenced this pull request Oct 23, 2021
@MiquelRForgeFlow @alan196
[MIG] operating_unit to v10.0 (OCA#45)
f2b15dd 
* [MIG] operating_unit to v10.0
huguesdk pushed a commit to coopiteasy/operating-unit that referenced this pull request Mar 17, 2023
@MiquelRForgeFlow @huguesdk
[MIG] operating_unit to v10.0 (OCA#45)
f5d3774 
* [MIG] operating_unit to v10.0
jdidderen-nsi pushed a commit to jdidderen-nsi/operating-unit that referenced this pull request May 27, 2024
@MiquelRForgeFlow @jdidderen-nsi
[MIG] operating_unit to v10.0 (OCA#45)
259f0df 
* [MIG] operating_unit to v10.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow requested changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@JordiBForgeFlow JordiBForgeFlow JordiBForgeFlow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MiquelRForgeFlow @JordiBForgeFlow @LoisRForgeFlow @AaronHForgeFlow