14.0 mig sale operating unit #470
Conversation
|
/ocabot migration sale_operating_unit |
|
@AaronHForgeFlow Travis is indicating errors in the module tests that have nothing to do with the sale_operating_unit. How to proceed |
|
We need to migrate the branch 14.0 to use github actions instead of travis. That will be done in separate PR, I will check how to do that. |
ok |
|
I mean to fix that here: #471 but I am not sure if I did well, I will wait for others to check. |
sale_operating_unit/__manifest__.py
Outdated
| "license": "LGPL-3", | ||
| "website": "https://github.com/OCA/operating-unit", | ||
| "category": "Sales Management", | ||
| "depends": ["sale", "account_operating_unit", "sales_team_operating_unit"], |
There was a problem hiding this comment.
change dependecy "sale" to "sale_management" since it's not installing the module
There was a problem hiding this comment.
Functional review installing the sales module manually is working ok
|
/ocabot rebase |
Currently translated at 100.0% (9 of 9 strings) Translation: operating-unit-13.0/operating-unit-13.0-sale_operating_unit Translate-URL: https://translation.odoo-community.org/projects/operating-unit-13-0/operating-unit-13-0-sale_operating_unit/es/
|
Congratulations, PR rebased to 14.0. |
|
@cramosh @AaronHForgeFlow same issue as described here |
|
@cramosh I am sorry, but this PR should be closed in favor of #464, that was created before. Can you close it? You can reopen later on if needed. |
I don't know if there are specific rules about this situation, but I think it's better to keep working on a PR where the dev is active rather than one that's been inactive for weeks, don't you think? It is important that everyone involved is aware that there are two PRs, but the community's interest is just reaching the fastest merge, regardless of who opened first |
Ok I will rectify the test and upload it again |
|
@francesco-ooops it is ok to me to keep this open if @olveracuenca is not going to work on #464 anymore. I will ask in that PR. |
|
It fails 2 things now: pre-commit (just run pre-commit run -a) I think you have to create a new product in the test, instead of using a reference. That way you will be able to change the type |
No description provided.