[17.0][FIX] crm_operating_unit: warning in logs #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurneyalex
force-pushed
the
fix-crm_operating_unit
branch
from
a5fe19c
to
c6cd966
Compare
When crm_operating_unit is installed, warning messages are sent to the Odoo logs: WARNING odoodb_test odoo.fields: Redundant default on crm.lead.operating_unit_id This is caused by the setting of a default value on a related field. We change the field to be computed, read-only with a compute method which implements the logic of the default value in case the team of the lead does not have an operating unit.
gurneyalex
force-pushed
the
fix-crm_operating_unit
branch
from
c6cd966
to
7707301
Compare
yankinmax
approved these changes
Oct 15, 2024
| ) | ||
|
|
||
| @api.depends("team_id.operating_unit_id") |
There was a problem hiding this comment.
shouldn't we add the team_id also in the api.depends?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When crm_operating_unit is installed, warning messages are sent to the Odoo logs:
WARNING odoodb_test odoo.fields: Redundant default on crm.lead.operating_unit_id
This is caused by the setting of a default value on a related field.
We change the field to be computed, read-only with a compute method which implements the logic of the default value in case the team of the lead does not have an operating unit.