[14.0][MIG] base_location: Migration to 14.0 #1003

pedrobaeza · 2020-10-24T18:18:52Z

Standard procedure
invisible > attrs in view
Changed method

… when company country is filled.

…tter-zip field

…ssues with module partner_address_street3

…some views. Added two columns in respective tree views.

…ooks * Added Icon. * Improve module description and extracted to README.rst. * Pass country instead of country_id for advance comparisons. * Allow to transform city name. * Some code style. * Do not remove all entries of a country, but only not found. * Include hooks for transforming some things. * Include spanish translation.

Brussels Belgium city

…y, state and country in order to allow search using '%' from the m2o widget

* Headers shortened * Move cities management to settings

… state view

* [IMP] base_location: Add lat & long to `better.zip` * Add latitude and longitude columns to `better.zip` * [IMP] base_location_geonames_import: Add lat/long * Add support for latitude & longitude to genomes importer

Incredibly not included in Odoo core.

Currently translated at 66.7% (24 of 36 strings) Translation: partner-contact-11.0/partner-contact-11.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-11-0/partner-contact-11-0-base_location/es/

Currently translated at 100,0% (36 of 36 strings) Translation: partner-contact-11.0/partner-contact-11.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-11-0/partner-contact-11-0-base_location/de/

This module has now been refactored to be more consistent with what base_address_city offers to the location management. Added dependency to contacts so that I could change the menu location for cities / zip management. Now, every res.city record has a relation One2many to res.city.zip (old res.better.zip). This way, every zip has a realted city too. Zips can be searched through city code, zip or city name (same as before). Modified tests and deleted not needed tests. Added sql contraints so that zips and cities are unique within it's country / state / city.

Steps: - Open company form - Set 'city completion' field Get 'The state of the partner My Company differs from that in location X' Disabling _check_zip while writing 'zip' fields from company, as incompatible with the sequence of write operations. Automatic test is added too.

Currently translated at 57.6% (19 of 33 strings) Translation: partner-contact-12.0/partner-contact-12.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-base_location/es/

* Don't need cities for migrating Previous script required to have cities populated for working, but that's not usual thing, as people in v11 may choose to not import them, and for older databases they even weren't that option. With this improve script, now we populate city table for ZIP entries without city, so the rest of the queries are properly executed in any case. * Cover case of res_better_zip w/o country_id * Avoid error on null zip numbers

* Standard procedure * Change v13 specifics * Adapt tests + correct some practices

OsoTranquilo · 2020-11-24T13:23:57Z

Correct functionality test

alexis-via · 2020-11-26T21:41:08Z

Sorry if my question is stupid... I haven't followed the development of base_location since v12. Why do we need the res.city.zip object ? I really don't understand the role of this object: res.city is enough, isn't it ?

alexis-via · 2020-11-26T21:59:33Z

Another question: res.city object has a zipcode field (cf https://github.com/odoo/odoo/blob/14.0/addons/base_address_city/models/res_city.py#L13), and that field existed since the beginning of base_address_city, but its value is not set by base_location_geonames_import, cf https://github.com/OCA/partner-contact/blob/13.0/base_location_geonames_import/wizard/geonames_import.py#L98
So it would mean that we don't want to use zipcode on res.city, but we use res.city.zip to store the zipcode ? Maybe it's the answer to my previous question...

alexis-via · 2020-11-26T22:02:10Z

FYI, as geonames.org is down (https://download.geonames.org/export/zip/ is empty), I can't test easily the base_location + base_location_geonames_import modules... which makes things more difficult.

pedrobaeza · 2020-11-27T08:57:01Z

@alexis-via Geonames is up again. About the data model, it was the same in v12. The idea of the refactoring of this module was to have a normalized data model, where there's an specific model that represents a city, not a city + zip. Your colleague @rvalyi claimed for it sometime ago in v7/v8. Then, we have a cardinality of 1..N from city to zips linked to that city. There's an ongoing conversation in #1020 for relaxing current constraint for having a hybrid data model.

I'm finishing the conversion to computed writable for having it as example for things like OCA/odoo-community.org#50. I will write back when finished.

alexis-via · 2020-11-27T09:32:57Z

I'll study it more in depth and talk with @rvalyi about it. Now that geonames is back up and running, I will be easier for me to test. I'll see if I arrive to the conclusion that res.city.zip is needed or if it should be dropped.

alexis-via · 2020-11-27T09:38:33Z

Just to facilitate the debate:

in v10, we had a single object res.better.zip with zip + city name + state_id + country_id, cf https://github.com/OCA/partner-contact/blob/10.0/base_location/models/better_zip.py#L17
starting from v12, there is a new official addon base_address_city with an object res.city with the same information cf https://github.com/odoo/odoo/blob/14.0/addons/base_address_city/models/res_city.py#L12

pedrobaeza · 2020-11-28T10:48:05Z

I have adapted the code to new computed writable fields for depicting the possibilities.

Please take a look to this new "style", and if you give your blessings, I finally merge this.

* Adapt code to this style * Adapt tests and use Form for mimicking UI behavior

OCA-git-bot · 2020-11-28T11:58:48Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

NL66278 · 2020-11-28T12:04:40Z

base_location/README.rst

+
+This module introduces a zip model that allows you to manage locations in a better way.
+
+The zips will allow the users to complete automatically all address-related fields by just filling the zip.


Actually not all address related fields. You will not be able to fill in house_number and door_number from the zip. In most countries also not the street. Maybe replace 'all' with 'many'?

AFAIK, that fields are added through extension modules, so it's OK to say that with current dependency set.

It is only a minor point anyway. Very glad with the module as is. But street is also not filled automatically, and this is definitely also address related.

Yeah, I get your point about the street, although it's impossible to fill a not known data derived from the ZIP. If I read the text, I understand that the "address-related" text refers exactly to this: the address fields that are linked with the ZIP, not the non related ones, and street (and the others) is not related, as a ZIP code contains a lot of streets.

OsoTranquilo

It works well

pedrobaeza · 2020-11-30T16:44:19Z

Can I merge?

HaraldPanten · 2020-11-30T17:31:06Z

Can I merge?

👍

alexis-via · 2020-11-30T17:44:30Z

I talked with @rvalyi about res.city.zip object, and he told me that we doesn't use base_location in Bazil, so he's not concerned about the issue.
As I still think that base_location is now useless, I developed this afternoon a new module base_address_city_geonames_import, that does NOT depend on base_location. KISS concept. I wonder if I should propose this module in OCA/partner-contact or keep it in some Akretion Github project.

pedrobaeza · 2020-11-30T17:54:06Z

OK, I still see valuable this structure as base instead of the base_address_city one. You can propose if you want the other module to OCA for having both options.

Merging this one:

/ocabot merge nobump

OCA-git-bot · 2020-11-30T17:54:22Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-1003-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2020-11-30T18:19:03Z

Congratulations, your PR was merged at f3238eb. Thanks a lot for contributing to OCA. ❤️

alexis-via · 2020-11-30T23:08:21Z

Unless if somebody explicitly says in this thread that he's interested in removing the res.city.zip object and in the associated simplification of the code, I think I'll publish my module base_address_city_geonames_import for v14 under akretion/odoo-usability (I'll do that probably tomorrow). The extra work needed for publishing in OCA is not worth it if I'm the only person interested.

alexis-via · 2020-12-01T13:23:17Z

I just published my new module base_address_city_geonames_import in a dedicated Github project:
https://github.com/akretion/geonames-import-simple
I'm very happy with the result:
base_location + base_location_geonames_import = 208 + 212 lines of python (tests excluded) = 420 lines total
base_address_city_geonames_import = 186 lines of python (tests excluded)
55% less lines of python code. KISS.

As a consequence, I'll stop maintaining l10n_fr_base_location_geonames_import in OCA/l10n-france (I'll move the equivalent code elsewhere).
If one day the strategy changes and the object res.city.zip is dropped, I may propose my module base_address_city_geonames_import to OCA or go back to using base_location + base_location_geonames_import.

fmdl · 2020-12-02T20:10:10Z

@alexis-via I interessed to have this module in OCA.

nbessi and others added 30 commits October 18, 2020 12:46

[MV] rename better_zip to base_location

89ac818

base_location: [IMP] Spanish translation and translation template.

1c764a8

[FIX] mutable default in function signature

10d0c49

[FIX] base_location: Changed partner view to avoid extrange behaviour…

d514dd8

… when company country is filled.

[FIX] Add context propagation to base_location

4bf8c6b

[Add] Add italian translation, change field class to edit-only for be…

077e61a

…tter-zip field

base_location: Don't position zip_id after street2, to avoid layout i…

ebb0d5d

…ssues with module partner_address_street3

Danish translation

cf2c2e9

[IMP] base_location: Updated to v8 syntax and uses. Added filters in …

46427a4

…some views. Added two columns in respective tree views.

Add demo data

73adbd0

Brussels Belgium city

IMP Create new computed stored field 'display_name' that use zip, cit…

12e14a0

…y, state and country in order to allow search using '%' from the m2o widget

Translated to Danish

b56c8c3

[MIG] base_location: Migration to 9.0

2562d80

[MIG] base_location: Migrated to 10.0

626eedd

* Headers shortened * Move cities management to settings

[FIX][10.0] base_location : "better_zip_ids" field set colspan="2" in…

c251817

… state view

[10.0][IMP] base_location(geonames): Add Lat/Long (OCA#405)

676590f

* [IMP] base_location: Add lat & long to `better.zip` * Add latitude and longitude columns to `better.zip` * [IMP] base_location_geonames_import: Add lat/long * Add support for latitude & longitude to genomes importer

OCA Transbot updated translations from Transifex

a8b45de

[MIG] base_location

e72a32b

OCA Transbot updated translations from Transifex

6a531aa

[IMP] base_location: Include onchange for state

2539b2f

Incredibly not included in Odoo core.

[IMP] base_location: name_search improvement (OCA#585)

58c93fb

Translated using Weblate (Spanish)

57b5fd8

Currently translated at 66.7% (24 of 36 strings) Translation: partner-contact-11.0/partner-contact-11.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-11-0/partner-contact-11-0-base_location/es/

Translated using Weblate (German)

2e9c125

Currently translated at 100,0% (36 of 36 strings) Translation: partner-contact-11.0/partner-contact-11.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-11-0/partner-contact-11-0-base_location/de/

[IMP] base_location: Add migration scripts

8b29cac

Translated using Weblate (Spanish)

99aa1f1

Currently translated at 57.6% (19 of 33 strings) Translation: partner-contact-12.0/partner-contact-12.0-base_location Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-base_location/es/

[MIG] base_location: Migration to 13.0

1da1248

* Standard procedure * Change v13 specifics * Adapt tests + correct some practices

fmdl approved these changes Nov 17, 2020

View reviewed changes

newtratip approved these changes Nov 17, 2020

View reviewed changes

[IMP] base_location: Switch to computed writable fields

4a71fae

* Adapt code to this style * Adapt tests and use Form for mimicking UI behavior

pedrobaeza force-pushed the 14.0-mig-base_location branch from 32befed to 4a71fae Compare November 28, 2020 11:02

OCA-git-bot added the ready to merge label Nov 28, 2020

NL66278 reviewed Nov 28, 2020

View reviewed changes

OsoTranquilo approved these changes Nov 30, 2020

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Nov 30, 2020

OCA-git-bot merged commit c140a11 into OCA:14.0 Nov 30, 2020

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Nov 30, 2020

alexis-via mentioned this pull request Dec 1, 2020

[14.0] adding l10n_fr_city module OCA/l10n-france#259

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0][MIG] base_location: Migration to 14.0 #1003

[14.0][MIG] base_location: Migration to 14.0 #1003

pedrobaeza commented Oct 24, 2020

OsoTranquilo commented Nov 24, 2020

alexis-via commented Nov 26, 2020

alexis-via commented Nov 26, 2020

alexis-via commented Nov 26, 2020

pedrobaeza commented Nov 27, 2020 •

edited

Loading

alexis-via commented Nov 27, 2020

alexis-via commented Nov 27, 2020

pedrobaeza commented Nov 28, 2020

OCA-git-bot commented Nov 28, 2020

NL66278 Nov 28, 2020 •

edited

Loading

pedrobaeza Nov 28, 2020

NL66278 Nov 28, 2020

pedrobaeza Nov 28, 2020 •

edited

Loading

OsoTranquilo left a comment

pedrobaeza commented Nov 30, 2020

HaraldPanten commented Nov 30, 2020

alexis-via commented Nov 30, 2020

pedrobaeza commented Nov 30, 2020

OCA-git-bot commented Nov 30, 2020

OCA-git-bot commented Nov 30, 2020

alexis-via commented Nov 30, 2020

alexis-via commented Dec 1, 2020

fmdl commented Dec 2, 2020


		This module introduces a zip model that allows you to manage locations in a better way.

		The zips will allow the users to complete automatically all address-related fields by just filling the zip.

[14.0][MIG] base_location: Migration to 14.0 #1003

[14.0][MIG] base_location: Migration to 14.0 #1003

Conversation

pedrobaeza commented Oct 24, 2020

OsoTranquilo commented Nov 24, 2020

alexis-via commented Nov 26, 2020

alexis-via commented Nov 26, 2020

alexis-via commented Nov 26, 2020

pedrobaeza commented Nov 27, 2020 • edited Loading

alexis-via commented Nov 27, 2020

alexis-via commented Nov 27, 2020

pedrobaeza commented Nov 28, 2020

OCA-git-bot commented Nov 28, 2020

NL66278 Nov 28, 2020 • edited Loading

Choose a reason for hiding this comment

pedrobaeza Nov 28, 2020

Choose a reason for hiding this comment

NL66278 Nov 28, 2020

Choose a reason for hiding this comment

pedrobaeza Nov 28, 2020 • edited Loading

Choose a reason for hiding this comment

OsoTranquilo left a comment

Choose a reason for hiding this comment

pedrobaeza commented Nov 30, 2020

HaraldPanten commented Nov 30, 2020

alexis-via commented Nov 30, 2020

pedrobaeza commented Nov 30, 2020

OCA-git-bot commented Nov 30, 2020

OCA-git-bot commented Nov 30, 2020

alexis-via commented Nov 30, 2020

alexis-via commented Dec 1, 2020

fmdl commented Dec 2, 2020

pedrobaeza commented Nov 27, 2020 •

edited

Loading

NL66278 Nov 28, 2020 •

edited

Loading

pedrobaeza Nov 28, 2020 •

edited

Loading