Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] [MIG] partner contact birthplace #1196

Merged
merged 8 commits into from
Feb 1, 2022

Conversation

primes2h
Copy link
Contributor

No description provided.

@primes2h primes2h mentioned this pull request Dec 12, 2021
45 tasks
Copy link

@marcelofrare marcelofrare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you!

"summary": "This module allows to define a birthplace for partners.",
"version": "14.0.1.0.0",
"category": "Customer Relationship Management",
"website": "https://github.com/OCA/partner-contact" "partner_contact_birthplace",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"website": "https://github.com/OCA/partner-contact" "partner_contact_birthplace",
"website": "https://github.com/OCA/partner-contact",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@newtratip
Done, thank you!

@primes2h primes2h force-pushed the 14.0-mig-partner_contact_birthplace branch from 272f937 to f866ff9 Compare December 14, 2021 07:50
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review
Thanks
LGTM

@dreispt
Copy link
Member

dreispt commented Feb 1, 2022

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1196-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 1, 2022
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 14.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 14.0-ocabot-merge-pr-1196-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c67b802 into OCA:14.0 Feb 1, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7011488. Thanks a lot for contributing to OCA. ❤️

Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review, LGTM

@primes2h primes2h deleted the 14.0-mig-partner_contact_birthplace branch November 15, 2022 16:59
CLaurelB pushed a commit to vauxoo-dev/partner-contact that referenced this pull request Mar 6, 2024
Signed-off-by rafaelbn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants