[ADD] sale_partner_company_group #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 24, 2022
yankinmax
changed the title
yankinmax
force-pushed
the
add-partner_company_group_sale
branch
from
2b233fd to
f98d007
Compare
gurneyalex
approved these changes
Mar 30, 2022
yankinmax
force-pushed
the
add-partner_company_group_sale
branch
2 times, most recently
from
49a23e0 to
777c132
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
yankinmax
force-pushed
the
add-partner_company_group_sale
branch
from
777c132 to
f5dbec6
Compare
yankinmax
force-pushed
the
add-partner_company_group_sale
branch
from
f5dbec6 to
67fd228
Compare
4 tasks
file no longer required now that the base PR is merged.
gurneyalex
removed
the
stale
grindtildeath
approved these changes
Oct 11, 2022
Co-authored-by: Akim Juillerat <akim.juillerat@camptocamp.com>
Co-authored-by: Akim Juillerat <akim.juillerat@camptocamp.com>
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
OCA-git-bot
added a commit
that referenced
this pull request
Oct 11, 2022
|
It looks like something changed on |
|
Congratulations, your PR was merged at 2727ee1. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to split
partner_company_groupto several modules depending on each of core modules. This is needed to avoid installing unwanted dependencies on the project, for example we needpartner_company_group, but without additional installedaccount,saleorcrm.So, finally we want it to be:
base_partner_company_group-> [15.0][ADD] base_partner_company_group #1244account_partner_company_groupdepending onbase_partner_company_groupandaccount-> [ADD] account_partner_company_group #1246crm_partner_company_groupdepending onbase_partner_company_groupandcrm-> [ADD] crm_partner_company_group #1245sale_partner_company_groupdepending onbase_partner_company_groupandsale-> [ADD] sale_partner_company_group #1247