Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG] partner_default_sale_discount #1438

Closed

Conversation

lbelorgey
Copy link

Migration to 14.0

@lbelorgey lbelorgey mentioned this pull request Dec 29, 2022
45 tasks
Copy link

@quannguyen1560 quannguyen1560 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

github-actions bot commented Jul 2, 2023

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 2, 2023
pedrobaeza and others added 9 commits August 3, 2023 09:08
* [ADD] partner_default_sale_discount

Default sales discount per partner
==================================

This module allows to define at partner level a default discount to be applied
on sales orders as the default one. As the field is a company dependent one,
you can configure a different value for the partner for each of your companies.

Configuration
=============

Enabling the use of discounts in Odoo:

* Go to *Sales > Configuration > Settings*
* On the group "Quotations & Sales", select the option "Allow discounts on
  sales order lines" for the "Discount" section.

Setting a default sales discount:

* Then, go to *Sales > Customers*.
* Create or modify a customer.
* Go to "Sales & Purchases" page.
* In the "Sale" section, there's a field called "Default sales discount (%)"
  where you can fill the default discount percentage.
* This value can only be filled at company partners, not for contacts.

Usage
=====

To use this module, you need to:

* Go to Sales > Quotations.
* Create a new quotation.
* Select a partner with a default discount applied.
* Create an order line, and you will see this discount as default in the line.

Known issues / Roadmap
======================

* This module doesn't work with *product_visible_discount*, as it overwrites
  the discount field with its own value.
Squashed commit:

[deb6424] OCA Transbot updated translations from Transifex

[4eee6a2] OCA Transbot updated translations from Transifex

[4805b0c] OCA Transbot updated translations from Transifex
Squashed commit:

[ADD] icon.png

[UPD] README.rst

[UPD] Update partner_default_sale_discount.pot
Currently translated at 100.0% (3 of 3 strings)

Translation: partner-contact-12.0/partner-contact-12.0-partner_default_sale_discount
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_default_sale_discount/de/
Currently translated at 100.0% (3 of 3 strings)

Translation: partner-contact-12.0/partner-contact-12.0-partner_default_sale_discount
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-12-0/partner-contact-12-0-partner_default_sale_discount/it/
@lbelorgey lbelorgey force-pushed the 14.0-mig-partner_default_sale_discount branch from a952edf to 24dab36 Compare August 3, 2023 07:08
Copy link

@FranciscoExposito FranciscoExposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test ok

@Christian-RB
Copy link

@pedrobaeza Could be possible to reopen this PR? It was even approved and looks ok to me

@pedrobaeza
Copy link
Member

Sorry, GitHub is not allowing me to reopen the PR. Maybe @lbelorgey or you can propose it again and pinging me, I will take care of the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants