Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [FIX] partner_company_default: fix warning about create method in batch #1712

Merged
merged 1 commit into from
Aug 19, 2024
Merged

[16.0] [FIX] partner_company_default: fix warning about create method in batch #1712

merged 1 commit into from
Aug 19, 2024

Conversation

ivantodorovich
Copy link
Contributor

@ivantodorovich ivantodorovich commented Mar 20, 2024 •
edited
Loading

fix warning about create method in batch

yostashiro
yostashiro approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

AungKoKoLin1997
AungKoKoLin1997 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@AungKoKoLin1997 AungKoKoLin1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt
Copy link
Member

dreispt commented May 19, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1712-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 19, 2024
@OCA-git-bot
Merge PR #1712 into 16.0
6b14552 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1712-by-dreispt-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@RodrigoBM
Copy link

RodrigoBM commented Aug 2, 2024 •
edited
Loading

can @dreispt re-merge it? thanks

@RodrigoBM RodrigoBM mentioned this pull request Aug 2, 2024
Closed
@RodrigoBM
Copy link

can @yostashiro merge it?

@yostashiro
Copy link
Member

can @yostashiro merge it?

Sorry, I don't have the authority to do so.

@ivantodorovich I'm not sure what the issue was in #1712 (comment), but could you perhaps rebase so that @dreispt can try to merge again.

@dreispt
Copy link
Member

dreispt commented Aug 19, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1712-by-dreispt-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ce712d6 into OCA:16.0 Aug 19, 2024
8 of 9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3c674c0. Thanks a lot for contributing to OCA. ❤️

@ivantodorovich ivantodorovich deleted the 16.0-fix-partner-company-default-multi branch August 19, 2024 11:33
@giarve giarve mentioned this pull request Oct 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AungKoKoLin1997 AungKoKoLin1997 AungKoKoLin1997 approved these changes

@yostashiro yostashiro yostashiro approved these changes

@RodrigoBM RodrigoBM RodrigoBM approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ivantodorovich @OCA-git-bot @dreispt @RodrigoBM @yostashiro @AungKoKoLin1997