Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] account_partner_company_group: Migration to 17.0 #1753

Merged
merged 7 commits into from
May 21, 2024
Merged

[17.0][MIG] account_partner_company_group: Migration to 17.0 #1753

merged 7 commits into from
May 21, 2024

Conversation

MohamedOsman7
Copy link

Follow-up PR for #1689

@MohamedOsman7 MohamedOsman7 force-pushed the 17.0-mig-account_partner_company_group branch from 89fa416 to dc79050 Compare May 6, 2024 14:53
CRogos
CRogos approved these changes May 6, 2024
View reviewed changes
Copy link

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code + Functional review LGTM

@MohamedOsman7 MohamedOsman7 force-pushed the 17.0-mig-account_partner_company_group branch from dc79050 to 2d73455 Compare May 13, 2024 12:36
@CRogos
Copy link

CRogos commented May 16, 2024

@ConesaJM could you review this new PR as well?

@CRogos
Copy link

CRogos commented May 21, 2024

@pedroguirao, @Christian-RB could you make a review on these *_company_group modules?

@gurneyalex gurneyalex mentioned this pull request May 21, 2024
Merged
@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1753-by-gurneyalex-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 21, 2024
@OCA-git-bot
Merge PR #1753 into 17.0
32fdef6 
Signed-off-by gurneyalex
@gurneyalex
Copy link
Member

/ocabot migration account_partner_company_group

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone May 21, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request May 21, 2024
Open
65 tasks
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 17.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 17.0-ocabot-merge-pr-1753-by-gurneyalex-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 21, 2024
@OCA-git-bot
Merge PR #1753 into 17.0
eea9310 
Signed-off-by gurneyalex
@MohamedOsman7 MohamedOsman7 force-pushed the 17.0-mig-account_partner_company_group branch from 2d73455 to 4c1f49b Compare May 21, 2024 15:28
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 17.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 17.0-ocabot-merge-pr-1753-by-gurneyalex-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 21, 2024
@OCA-git-bot
Merge PR #1753 into 17.0
c51228d 
Signed-off-by gurneyalex
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 17.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 17.0-ocabot-merge-pr-1753-by-gurneyalex-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1b1a9b6 into OCA:17.0 May 21, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0ad9a72. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurneyalex gurneyalex gurneyalex approved these changes

@CRogos CRogos CRogos approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
9 participants
@MohamedOsman7 @CRogos @gurneyalex @OCA-git-bot @yankinmax @Highcooley @adrianojprado @Ivorra78 @mymage