[16.0][FIX] base_location_geonames_import: Fixes for re-imports #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Befor this commit, there were 2 possible errors re-importing ZIPs: - If city names are changed on the import process (like capitalization), the code for detecting existing entries was not taking that into account, failing to find the city. - If there's more than one found result, using `discard` for removing the result from the ZIPs to remove gives an error. TT52020
victoralmau
approved these changes
Dec 2, 2024
sebalix
approved these changes
Dec 4, 2024
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 199fc4c. Thanks a lot for contributing to OCA. ❤️ |
pedrobaeza
deleted the
16.0-fix-base_location_geonames_import-reimport
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, there were 2 possible errors re-importing ZIPs:
discardfor removing the result from the ZIPs to remove gives an error.@Tecnativa TT52020