Skip to content

[MIG][18.0] partner_contact_tags_in_popup from 16.0 #1943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 18, 2025
Merged

[MIG][18.0] partner_contact_tags_in_popup from 16.0 #1943

merged 6 commits into from
Mar 18, 2025

Conversation

acsonefho
Copy link
Contributor

Migration in 18.0 of partner_contact_tags_in_popup from 16.0

flotho
flotho approved these changes Jan 11, 2025
View reviewed changes
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this PR

@acsonefho
Copy link
Contributor Author

@carmenbianca @victor-champonnois @huguesdk @NL66278 Can you review this please? (as you already did the review for v16)

NL66278
NL66278 approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@NL66278 NL66278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@acsonefho
Copy link
Contributor Author

@rousseldenis Do you have super-power to merge this? 🦸

@acsonefho
Copy link
Contributor Author

Hi @pedrobaeza is it possible to merge this? 🙏

pedrobaeza
pedrobaeza requested changes Mar 17, 2025
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the version bumping in the proper commit (the migration one), not the previous of the pre-commit.

This is very evident in this one, as there's almost nothing in the migration commit.

@acsonefho acsonefho force-pushed the 18.0-mig-partner_contact_tags_in_popup branch from 69d4f7e to 34d6a99 Compare March 18, 2025 06:26
@acsonefho acsonefho force-pushed the 18.0-mig-partner_contact_tags_in_popup branch from 34d6a99 to 49afe50 Compare March 18, 2025 06:29
@acsonefho acsonefho requested a review from pedrobaeza March 18, 2025 06:30
@acsonefho
Copy link
Contributor Author

Please do the version bumping in the proper commit (the migration one), not the previous of the pre-commit.

This is very evident in this one, as there's almost nothing in the migration commit.

Thanks for the review @pedrobaeza !
All is done 💪

pedrobaeza
pedrobaeza approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still a mix of things between commits. Please follow next time strictly the migration guide (https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0), but I'm not blocking this time.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-1943-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 62816fe into OCA:18.0 Mar 18, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at fe60ac6. Thanks a lot for contributing to OCA. ❤️

@acsonefho acsonefho deleted the 18.0-mig-partner_contact_tags_in_popup branch March 18, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NL66278 NL66278 NL66278 approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

+2 more reviewers

@flotho flotho flotho approved these changes

@SamyBrahimi SamyBrahimi SamyBrahimi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@acsonefho @OCA-git-bot @flotho @NL66278 @pedrobaeza @SamyBrahimi @carmenbianca @mymage