[ADD] res.partner: Porting partner_street_number module to Odoo 9.0 #207

DarkoNikolovski · 2015-11-24T14:41:36Z

No description provided.

moylop260 · 2015-11-24T16:43:44Z

👍

gurneyalex · 2015-11-25T13:36:01Z

partner_street_number/views/assets.xml

+<openerp>
+  <data>
+
+    <template id="assets_backend" name="partner_street_number backend assets" inherit_id="web.assets_backend">


this is causing a crash on runbot. Can you double check?

I checked it once again locally on fresh odoo 9 installation and everything looks fine.

yvaucher · 2016-01-13T14:03:44Z

Added it in #184

rafaelbn · 2016-07-01T23:07:40Z

Please @DarkoNikolovski could you review this PR?
Runbot fails:

2015-12-24 18:03:45     CRITICAL    server  openerp.service.server:898 preload_registries

Failed to initialize database `3138409-207-9715fc-all`.
Traceback (most recent call last):
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3138409-207-9715fc/openerp/service/server.py", line 885, in preload_registries
    registry = RegistryManager.new(dbname, update_module=update_module)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3138409-207-9715fc/openerp/modules/registry.py", line 385, in new
    openerp.modules.load_modules(registry._db, force_demo, status, update_module)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3138409-207-9715fc/openerp/modules/loading.py", line 337, in load_modules
    loaded_modules, update_module)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3138409-207-9715fc/openerp/modules/loading.py", line 237, in load_marked_modules
    loaded, processed = load_module_graph(cr, graph, progressdict, report=report, skip_modules=loaded_modules, perform_checks=perform_checks)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3138409-207-9715fc/openerp/modules/loading.py", line 156, in load_module_graph
    _load_data(cr, module_name, idref, mode, kind='data')
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3138409-207-9715fc/openerp/modules/loading.py", line 98, in _load_data
    tools.convert_file(cr, module_name, filename, idref, mode, noupdate, kind, report)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3138409-207-9715fc/openerp/tools/convert.py", line 852, in convert_file
    convert_xml_import(cr, module, fp, idref, mode, noupdate, report)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3138409-207-9715fc/openerp/tools/convert.py", line 939, in convert_xml_import
    obj.parse(doc.getroot(), mode=mode)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3138409-207-9715fc/openerp/tools/convert.py", line 802, in parse
    self.parse(rec, mode)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3138409-207-9715fc/openerp/tools/convert.py", line 805, in parse
    self._tags[rec.tag](self.cr, rec, de, mode=mode)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3138409-207-9715fc/openerp/tools/convert.py", line 778, in _tag_template
    return self._tag_record(cr, record, data_node)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3138409-207-9715fc/openerp/tools/convert.py", line 701, in _tag_record
    f_val = self.id_get(cr, f_ref)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3138409-207-9715fc/openerp/tools/convert.py", line 783, in id_get
    res = self.model_id_get(cr, id_str, raise_if_not_found)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3138409-207-9715fc/openerp/tools/convert.py", line 794, in model_id_get
    raise_if_not_found=raise_if_not_found)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3138409-207-9715fc/openerp/api.py", line 238, in wrapper
    return old_api(self, *args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3138409-207-9715fc/openerp/addons/base/ir/ir_model.py", line 960, in xmlid_to_res_model_res_id
    return self.xmlid_lookup(cr, uid, xmlid)[1:3]
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3138409-207-9715fc/openerp/api.py", line 238, in wrapper
    return old_api(self, *args, **kwargs)
  File "<string>", line 2, in xmlid_lookup
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3138409-207-9715fc/openerp/tools/cache.py", line 85, in lookup
    value = d[key] = self.method(*args, **kwargs)
  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3138409-207-9715fc/openerp/addons/base/ir/ir_model.py", line 950, in xmlid_lookup
    raise ValueError('External ID not found in the system: %s' % (xmlid))
ParseError: "External ID not found in the system: web.assets_backend" while parsing None:5, near
<data name="partner_street_number backend assets" inherit_id="web.assets_backend">
      <xpath expr="." position="inside">
        <link rel="stylesheet" href="/partner_street_number/static/src/css/field.css"/>
      </xpath>
    </data>

yvaucher · 2016-07-04T13:48:50Z

You might need a dependency on module web to solve the error pointed out by @rafaelbn

pedrobaeza · 2016-10-14T12:58:19Z

Please add the dependency as stated, and we will be able to merge this.

astirpe · 2017-03-15T12:41:22Z

Ping @DarkoNikolovski, will you work on this PR next days?

DarkoNikolovski · 2017-03-15T12:46:57Z

Yeah, I will add the dependency, no problem. Sorry I have missed previous comments on this PR.

moylop260 · 2017-03-16T23:36:13Z

partner_street_number/__openerp__.py

    "author": "Therp BV,Odoo Community Association (OCA)",
    "website": "https://github.com/oca/partner-contact",
    "category": 'Tools',
    "depends": [
-        'base'
-        ],
+        'web',


Why is required install web?

The placement of the street name and number fields is now tweaked using CSS instead of using inline style, and the css link is inserted in an assets view from the web module.

@moylop260 please could you finish you review? thanks!

rafaelbn · 2017-05-31T09:49:19Z

Rebuilding runbot for testing

yajo · 2017-05-31T11:12:28Z

partner_street_number/static/src/css/field.css

@@ -0,0 +1,11 @@
+.o_address_street_name {
+	   float: left !important;


yajo · 2017-05-31T11:12:35Z

partner_street_number/static/src/css/field.css

+	   float: left !important;
+       margin-right: 2% !important;
+       width: 75% !important;
+   }


Fix indentation in this whole file

yajo · 2017-05-31T11:12:47Z

partner_street_number/static/src/css/field.css

+       margin-right: 0% !important;
+       width: 25% !important;
+   }
+


yajo · 2017-05-31T11:13:22Z

partner_street_number/static/src/css/field.css

+
+.o_address_street_number {
+       margin-right: 0% !important;
+       width: 25% !important;


Never use !important. Use more explicit selectors instead.

yajo · 2017-05-31T11:13:31Z

partner_street_number/views/assets.xml

@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<openerp>


yajo · 2017-05-31T11:13:39Z

partner_street_number/views/assets.xml

@@ -0,0 +1,12 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<openerp>
+  <data>


Put only <odoo> tag

yajo · 2017-05-31T11:14:48Z

partner_street_number/views/res_partner.xml

                       position="attributes">
                    <attribute name="invisible">1</attribute>
                </xpath>

                <xpath expr="//field[@name='child_ids']" position="attributes">
-                    <attribute name="context">{'default_parent_id': active_id, 'default_street_name': street_name, 'default_street_number': street_number, 'default_street2': street2, 'default_city': city, 'default_state_id': state_id, 'default_zip': zip, 'default_country_id': country_id, 'default_supplier': supplier, 'default_customer': customer, 'default_use_parent_address': True}</attribute>


Please don't remove this

rafaelbn · 2017-05-31T14:47:28Z

Hi @DarkoNikolovski , thanks for this contribution. Please is it possible to review comments for merging? Let me know thanks!

rafaelbn

Tested in runbot

[ADD] res.partner: Porting partner_street_number to 9.0

9715fc4

gurneyalex reviewed Nov 25, 2015
View reviewed changes

gurneyalex added the needs fixing label Nov 25, 2015

pedrobaeza mentioned this pull request Jan 13, 2016

Migration to version 9.0 #184

Closed

31 tasks

rafaelbn added this to the 9.0 milestone Jul 1, 2016

astirpe mentioned this pull request Oct 14, 2016

[MIG][10.0] Porting partner_street_number to V10 #314

Merged

astirpe mentioned this pull request Mar 15, 2017

[9.0][MIG] Port l10n_nl_postcodeapi OCA/l10n-netherlands#69

Merged

Darko Nikolovski added 2 commits March 15, 2017 16:03

partner_street_number: Add 'web' module as dependency

a1392bc

partner_street_number: PEP8 corrections

4910be3

StefanRijnhart approved these changes Mar 16, 2017

View reviewed changes

StefanRijnhart added needs review and removed needs fixing labels Mar 16, 2017

moylop260 reviewed Mar 16, 2017

View reviewed changes

astirpe approved these changes May 31, 2017

View reviewed changes

yajo requested changes May 31, 2017

View reviewed changes

rafaelbn approved these changes May 31, 2017

View reviewed changes

astirpe mentioned this pull request Jun 21, 2017

[FIX][9.0] NL BTW statement, onchange date range OCA/l10n-netherlands#89

Merged

hbrunn mentioned this pull request Mar 12, 2018

[9.0] [FIX] l10n_nl_xaf_auditfile_export: fix rounding issues OCA/l10n-netherlands#160

Merged

NL66278 merged commit db0cd31 into OCA:9.0 Apr 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD] res.partner: Porting partner_street_number module to Odoo 9.0 #207

[ADD] res.partner: Porting partner_street_number module to Odoo 9.0 #207

DarkoNikolovski commented Nov 24, 2015

moylop260 commented Nov 24, 2015

gurneyalex Nov 25, 2015

DarkoNikolovski Nov 25, 2015

yvaucher commented Jan 13, 2016

rafaelbn commented Jul 1, 2016

yvaucher commented Jul 4, 2016

pedrobaeza commented Oct 14, 2016

astirpe commented Mar 15, 2017

DarkoNikolovski commented Mar 15, 2017

moylop260 Mar 16, 2017

StefanRijnhart Mar 17, 2017

rafaelbn May 31, 2017

rafaelbn commented May 31, 2017

yajo May 31, 2017

yajo May 31, 2017

yajo May 31, 2017

yajo May 31, 2017

yajo May 31, 2017

yajo May 31, 2017

pedrobaeza Jun 8, 2017

yajo May 31, 2017

pedrobaeza Jun 8, 2017

rafaelbn commented May 31, 2017

rafaelbn left a comment

		@@ -0,0 +1,11 @@
		.o_address_street_name {
		float: left !important;

		@@ -0,0 +1,12 @@
		<?xml version="1.0" encoding="UTF-8"?>
		<openerp>

[ADD] res.partner: Porting partner_street_number module to Odoo 9.0 #207

[ADD] res.partner: Porting partner_street_number module to Odoo 9.0 #207

Conversation

DarkoNikolovski commented Nov 24, 2015

moylop260 commented Nov 24, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yvaucher commented Jan 13, 2016

rafaelbn commented Jul 1, 2016

yvaucher commented Jul 4, 2016

pedrobaeza commented Oct 14, 2016

astirpe commented Mar 15, 2017

DarkoNikolovski commented Mar 15, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rafaelbn commented May 31, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rafaelbn commented May 31, 2017

rafaelbn left a comment

Choose a reason for hiding this comment