-
-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] partner_contact_lang: Manage language in contacts #302
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg | ||
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html | ||
:alt: License: AGPL-3 | ||
|
||
=========================== | ||
Manage language in contacts | ||
=========================== | ||
|
||
Odoo by default propagate language field to the created contacts from their | ||
form, but it doesn't allow to change it once created. | ||
|
||
This module fills this gap, and also provides other facilities for the | ||
contact language management: | ||
|
||
* Put the language of the parent company when the contact doesn't have a | ||
language and this parent company is assigned. | ||
* When the company changes the language, it fills with the same language all | ||
the contacts that don't have any. | ||
|
||
Usage | ||
===== | ||
|
||
Go to any partner that is a company and has contacts. Click on one contact | ||
and you will be able to edit the language. | ||
|
||
.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas | ||
:alt: Try me on Runbot | ||
:target: https://runbot.odoo-community.org/runbot/134/8.0 | ||
|
||
Bug Tracker | ||
=========== | ||
|
||
Bugs are tracked on `GitHub Issues | ||
<https://github.com/OCA/partner-contact/issues>`_. In case of trouble, please | ||
check there if your issue has already been reported. If you spotted it first, | ||
help us smashing it by providing a detailed and welcomed feedback. | ||
|
||
Credits | ||
======= | ||
|
||
Contributors | ||
------------ | ||
|
||
* Pedro M. Baeza <pedro.baeza@tecnativa.com> | ||
|
||
Icon | ||
---- | ||
* Original Odoo icons. | ||
|
||
Maintainer | ||
---------- | ||
|
||
.. image:: https://odoo-community.org/logo.png | ||
:alt: Odoo Community Association | ||
:target: http://odoo-community.org | ||
|
||
This module is maintained by the OCA. | ||
|
||
OCA, or the Odoo Community Association, is a nonprofit organization whose | ||
mission is to support the collaborative development of Odoo features and | ||
promote its widespread use. | ||
|
||
To contribute to this module, please visit https://odoo-community.org. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
# -*- coding: utf-8 -*- | ||
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). | ||
|
||
from . import models |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
# -*- coding: utf-8 -*- | ||
# © 2016 Pedro M. Baeza <pedro.baeza@tecnativa.com> | ||
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). | ||
|
||
{ | ||
'name': 'Manage language in contacts', | ||
'version': '8.0.1.0.0', | ||
'category': 'Partner Management', | ||
'license': 'AGPL-3', | ||
'author': 'Tecnativa,' | ||
'Odoo Community Association (OCA)', | ||
'website': 'https://www.tecnativa.com', | ||
'depends': [ | ||
'base', | ||
], | ||
'data': [ | ||
'views/res_partner_view.xml', | ||
], | ||
'installable': True | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
# -*- coding: utf-8 -*- | ||
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). | ||
|
||
from . import res_partner |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
# -*- coding: utf-8 -*- | ||
# © 2016 Pedro M. Baeza <pedro.baeza@tecnativa.com> | ||
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html). | ||
|
||
from openerp import api, models | ||
|
||
|
||
class ResPartner(models.Model): | ||
_inherit = 'res.partner' | ||
|
||
@api.multi | ||
def write(self, vals): | ||
if 'lang' in vals and vals['lang']: | ||
if 'child_ids' in vals: | ||
childs = self.browse(vals['child_ids']) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This line fails. STR:
|
||
else: | ||
childs = self.mapped('child_ids') | ||
childs = childs.filtered(lambda x: not x.lang) | ||
if childs: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This if does not much, since if not childs, next call to write will iterate over a 0-length recordset and do nothing. Not a blocker, but I'd personally remove it. |
||
childs.write({'lang': vals['lang']}) | ||
return super(ResPartner, self).write(vals) | ||
|
||
@api.multi | ||
def onchange_address(self, use_parent_address, parent_id): | ||
"""Change language if the parent company changes and there's no | ||
language defined yet""" | ||
res = super(ResPartner, self).onchange_address( | ||
use_parent_address, parent_id) | ||
if parent_id and self.parent_id.id != parent_id and not self.lang: | ||
parent = self.browse(parent_id) | ||
val = res.setdefault('value', {}) | ||
val['lang'] = parent.lang | ||
return res | ||
|
||
@api.multi | ||
@api.onchange('lang') | ||
def onchange_lang(self): | ||
if self.lang: | ||
childs = self.child_ids.filtered(lambda x: not x.lang) | ||
for child in childs: | ||
child.lang = self.lang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vals.get("lang")
is simpler.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not exactly the same. We can do anyway
if vals.get('lang') is not None:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I understand what you mean. However, in this case is better
vals.get("lang")
, because otherwise, if you are editing a parent partner and unsetting its lang, then you would search for all children that have no lang and unset it (which is redundant).